SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-mbim: fix warnings with -Wtype-limits

Browse Source 
This change is exclusively to make the compiler happy, don't even like
it myself...

  mm-broadband-modem-mbim.c: In function ‘signal_state_query_ready’:
  /usr/include/glib-2.0/glib/gmacros.h:811:63: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
    811 | #define CLAMP(x, low, high)  (((x) > (high)) ? (high) : (((x) < (low)) ? (low) : (x)))
        |                                                               ^
  mm-broadband-modem-mbim.c:1680:19: note: in expansion of macro ‘CLAMP’
   1680 |         quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31;
        |                   ^~~~~
This commit is contained in:
Aleksander Morgado
2020-01-30 19:09:52 +01:00
parent 7e67cbfe42
commit ac70712f1f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mm-broadband-modem-mbim.c
+1 -1
View File
@@ -1677,7 +1677,7 @@ signal_state_query_ready (MbimDevice *device,
guint32 quality;
/* Normalize the quality. 99 means unknown, we default it to 0 */
quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31;
quality = CLAMP (rssi == 99 ? 0 : (gint)rssi, 0, 31) * 100 / 31;
g_task_return_int (task, quality);
} else