From ac70712f1f5c12a2f85abf4e814efff8b41ff385 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Sat, 11 Jan 2020 13:15:21 +0100 Subject: [PATCH] broadband-modem-mbim: fix warnings with -Wtype-limits MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change is exclusively to make the compiler happy, don't even like it myself... mm-broadband-modem-mbim.c: In function ‘signal_state_query_ready’: /usr/include/glib-2.0/glib/gmacros.h:811:63: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] 811 | #define CLAMP(x, low, high) (((x) > (high)) ? (high) : (((x) < (low)) ? (low) : (x))) | ^ mm-broadband-modem-mbim.c:1680:19: note: in expansion of macro ‘CLAMP’ 1680 | quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31; | ^~~~~ --- src/mm-broadband-modem-mbim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c index 4910b299..f1f1b868 100644 --- a/src/mm-broadband-modem-mbim.c +++ b/src/mm-broadband-modem-mbim.c @@ -1677,7 +1677,7 @@ signal_state_query_ready (MbimDevice *device, guint32 quality; /* Normalize the quality. 99 means unknown, we default it to 0 */ - quality = CLAMP (rssi == 99 ? 0 : rssi, 0, 31) * 100 / 31; + quality = CLAMP (rssi == 99 ? 0 : (gint)rssi, 0, 31) * 100 / 31; g_task_return_int (task, quality); } else