SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

port-qmi: fix warnings with -Wimplicit-fallthrough

Browse Source 
mm-port-qmi.c:353:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    353 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:356:5: note: here
    356 |     case PORT_OPEN_STEP_CHECK_OPENING:
        |     ^~~~
  mm-port-qmi.c:366:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    366 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:369:5: note: here
    369 |     case PORT_OPEN_STEP_CHECK_ALREADY_OPEN:
        |     ^~~~
  mm-port-qmi.c:376:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    376 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:379:5: note: here
    379 |     case PORT_OPEN_STEP_DEVICE_NEW: {
        |     ^~~~
  mm-port-qmi.c:424:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    424 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:427:5: note: here
    427 |     case PORT_OPEN_STEP_ALLOCATE_WDA_CLIENT:
        |     ^~~~
  mm-port-qmi.c:474:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    474 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:477:5: note: here
    477 |     case PORT_OPEN_STEP_SET_KERNEL_DATA_FORMAT:
        |     ^~~~
This commit is contained in:
Aleksander Morgado
2020-01-31 14:52:49 +01:00
parent a4b5419287
commit 02e5015b5c
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mm-port-qmi.c
+5 -5
View File
@@ -397,7 +397,7 @@ port_open_step (GTask *task)
case PORT_OPEN_STEP_FIRST:
mm_dbg ("Opening QMI device...");
ctx->step++;
/* Fall down to next step */
/* Fall through */
case PORT_OPEN_STEP_CHECK_OPENING:
mm_dbg ("Checking if QMI device already opening...");
@@ -410,7 +410,7 @@ port_open_step (GTask *task)
return;
}
ctx->step++;
/* Fall down to next step */
/* Fall through */
case PORT_OPEN_STEP_CHECK_ALREADY_OPEN:
mm_dbg ("Checking if QMI device already open...");
@@ -420,7 +420,7 @@ port_open_step (GTask *task)
return;
}
ctx->step++;
/* Fall down to next step */
/* Fall through */
case PORT_OPEN_STEP_DEVICE_NEW: {
GFile *file;
@@ -468,7 +468,7 @@ port_open_step (GTask *task)
return;
}
ctx->step++;
/* Fall down to next step */
/* Fall through */
case PORT_OPEN_STEP_ALLOCATE_WDA_CLIENT:
/* Allocate WDA client */
@@ -518,7 +518,7 @@ port_open_step (GTask *task)
}
ctx->step++;
/* Fall down to next step */
/* Fall through */
case PORT_OPEN_STEP_SET_KERNEL_DATA_FORMAT:
/* Update the data format to be expected by the kernel */