From 02e5015b5c98ca9903bf3ea296165aea40b9f381 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander@aleksander.es>
Date: Sat, 11 Jan 2020 13:39:36 +0100
Subject: [PATCH] port-qmi: fix warnings with -Wimplicit-fallthrough

  mm-port-qmi.c:353:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    353 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:356:5: note: here
    356 |     case PORT_OPEN_STEP_CHECK_OPENING:
        |     ^~~~
  mm-port-qmi.c:366:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    366 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:369:5: note: here
    369 |     case PORT_OPEN_STEP_CHECK_ALREADY_OPEN:
        |     ^~~~
  mm-port-qmi.c:376:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    376 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:379:5: note: here
    379 |     case PORT_OPEN_STEP_DEVICE_NEW: {
        |     ^~~~
  mm-port-qmi.c:424:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    424 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:427:5: note: here
    427 |     case PORT_OPEN_STEP_ALLOCATE_WDA_CLIENT:
        |     ^~~~
  mm-port-qmi.c:474:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    474 |         ctx->step++;
        |         ~~~~~~~~~^~
  mm-port-qmi.c:477:5: note: here
    477 |     case PORT_OPEN_STEP_SET_KERNEL_DATA_FORMAT:
        |     ^~~~
---
 src/mm-port-qmi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mm-port-qmi.c b/src/mm-port-qmi.c
index a0fd131a..efaa3d15 100644
--- a/src/mm-port-qmi.c
+++ b/src/mm-port-qmi.c
@@ -397,7 +397,7 @@ port_open_step (GTask *task)
     case PORT_OPEN_STEP_FIRST:
         mm_dbg ("Opening QMI device...");
         ctx->step++;
-        /* Fall down to next step */
+        /* Fall through */
 
     case PORT_OPEN_STEP_CHECK_OPENING:
         mm_dbg ("Checking if QMI device already opening...");
@@ -410,7 +410,7 @@ port_open_step (GTask *task)
             return;
         }
         ctx->step++;
-        /* Fall down to next step */
+        /* Fall through */
 
     case PORT_OPEN_STEP_CHECK_ALREADY_OPEN:
         mm_dbg ("Checking if QMI device already open...");
@@ -420,7 +420,7 @@ port_open_step (GTask *task)
             return;
         }
         ctx->step++;
-        /* Fall down to next step */
+        /* Fall through */
 
     case PORT_OPEN_STEP_DEVICE_NEW: {
         GFile *file;
@@ -468,7 +468,7 @@ port_open_step (GTask *task)
             return;
         }
         ctx->step++;
-        /* Fall down to next step */
+        /* Fall through */
 
     case PORT_OPEN_STEP_ALLOCATE_WDA_CLIENT:
         /* Allocate WDA client */
@@ -518,7 +518,7 @@ port_open_step (GTask *task)
         }
 
         ctx->step++;
-        /* Fall down to next step */
+        /* Fall through */
 
     case PORT_OPEN_STEP_SET_KERNEL_DATA_FORMAT:
         /* Update the data format to be expected by the kernel */