Commit Graph
91269 Commits
Author SHA1 Message Date
Stephanie Wilde-Hobbs fc08ae472c hwdb: mark Lenovo ThinkPad X1 Tablet Gen 3 touchpad as internal
Similar to d13c07ecd8 and 373a4020d5, 65-integration.rules sets
ID_INPUT_TOUCHPAD_INTEGRATION=external, and libinput skips
disable-while-typing (DWT) for the device.

The touchpad is integrated into a detachable keyboard which isn't usable
on other devices so it should be marked as internal. This enables palm
detection and DWT.
2026-08-20 04:04:16 +09:00
Yu Watanabe e67956f31c Another batch of conversions to COMMAND and additions of --introspect-cli (#43436)
This is another batch of straightforward conversions. I wanted to do
udevadm here too, but it requires some design work.
2026-08-20 01:41:53 +09:00
Yu Watanabe d971596a02 verbs: fix typo
Found by Fossies.

Follow-up for 7ea090f41b.
2026-08-19 22:58:22 +09:00
Yu Watanabe 6e652b53c6 man: expand documentation for systemd-sysctl --verify
Follow-up for 0b9ac2e675.
2026-08-19 11:01:40 +02:00
Zbigniew Jędrzejewski-Szmek ebd9040b30 Fix memleak and double free in varlink methods (#43431) 2026-08-19 10:58:40 +02:00
Zbigniew Jędrzejewski-Szmek 963b2323ef report-sign-tsm: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract is now wrapped automatically.
2026-08-19 08:21:30 +02:00
Zbigniew Jędrzejewski-Szmek 8d8cf2cf1a report-sign-plain: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-19 08:21:30 +02:00
Zbigniew Jędrzejewski-Szmek 578e5c1b38 report-files: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 8f42146976 report-cgroup: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The referenced systemd-report-cgroup(8) man
page does not exist, so the reference is dropped.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 45966bcf8e report-basic: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract gets a trailing period. There is
no man page for this helper, so none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek c226b876c0 pull: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. There is no man page for this internal helper,
so none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 9832927a08 import-fs: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. There is no man page for this internal helper,
so none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 3e61b718a5 import: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. There is no man page for this internal helper,
so none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 3a45066bce export: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. There is no man page for this internal helper,
so none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek df618014a5 udev/scsi_id: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract is changed to the imperative.
There is no man page for this udev helper, so none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 9cd507ed5b udev/v4l_id: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract is changed to the imperative.
There is no man page for this udev helper, so none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 7038981d86 udev/mtd_probe: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. There is no man page for this udev helper, so
none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek 5b745242c5 udev/fido_id: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. There is no man page for this udev helper, so
none is referenced.
2026-08-19 08:21:29 +02:00
Zbigniew Jędrzejewski-Szmek c90fafdd04 udev/dmi_memory_id: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The help output had no abstract, so one is
added. There is no man page for this udev helper, so none is referenced.
2026-08-18 23:04:06 +02:00
Zbigniew Jędrzejewski-Szmek cc139a73b8 udev/cdrom_id: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The help output had no abstract, so one is
added. There is no man page for this udev helper, so none is referenced.
2026-08-18 23:04:06 +02:00
Zbigniew Jędrzejewski-Szmek 43c9d274e9 udev/ata_id: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The help output had no abstract, so one is
added. There is no man page for this udev helper, so none is referenced.
2026-08-18 23:04:06 +02:00
Zbigniew Jędrzejewski-Szmek c62bfac025 udev/iocost: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The tool has no man page of its own, so
iocost.conf(5), which describes it, is referenced. The test now also looks
for commands in /usr/lib/udev, where the udev helpers are installed.
2026-08-18 23:04:06 +02:00
Yu Watanabe 4430adbd76 sysinstall: refuse multiple requests
Otherwise, that triggers memory leak and double free.
2026-08-19 03:45:14 +09:00
Yu Watanabe 515121f7b3 resolve: refuse multiple requests
Otherwise, that triggers memory leak and double free.
2026-08-19 03:45:11 +09:00
Yu Watanabe b52f89e53b repart: refuse multiple requests with subscribe mode
Otherwise, that triggers memory leak and double free.
2026-08-19 03:29:26 +09:00
Yu Watanabe 112e4fe00a mute-console: refuse multiple requests per connection
Otherwise, that triggers memory leak and multiple free on the same
object.
2026-08-19 03:29:26 +09:00
Yu Watanabe 54253d2a9c journalctl: do not accept multiple requests to get journal entries with following mode
Otherwise, the previously attached FollowState object will be leaked,
and the latest object will be freed multiple times.
2026-08-19 03:29:26 +09:00
Yu Watanabe c2806a8c1d journal: do not accept multiple requests to sync journal per varlink connection
Otherwise, previously allocated SyncReq object will be leaked,
and the latest SyncReq object will be freed multiple times.
2026-08-19 03:29:26 +09:00
Yu Watanabe 0566d7aa35 journal: coding style fix 2026-08-19 03:29:26 +09:00
Yu Watanabe a7ba64356a journal: update comments
The Manager object was renamed from Server.
Maybe we forget to update these comments at that time.
2026-08-19 03:29:17 +09:00
dongshengyuan 3e55065ccf resolvectl: merge JSON error fields
Follow-up for: 32b3aabfe7
2026-08-19 02:31:39 +09:00
Daan De Meyer 57c4a1ea32 vmspawn: terminate the child processes before removing the runtime directory
The runtime directory holds what the helpers we fork off need: swtpm's socket
and, unless --tpm-state= points elsewhere, its state, the virtiofsd sockets,
the varlink control socket, and the QEMU config file. runtime_dir was declared
after the CLEANUP_ARRAY() that terminates those helpers, and cleanup handlers
run in reverse declaration order, so the directory was removed while all of
them were still running. That produces spurious errors from the helpers, and
anything they create while rm_rf() walks the tree can make the final rmdir fail
and leave the runtime directory behind.

Declare runtime_dir before the CLEANUP_ARRAY() instead, so the helpers are sent
SIGTERM and reaped first and the directory only goes away once nothing writes
to it anymore.

While at it, drop the rm_rf_physical_and_freep() destructors from the SSH key
paths. They are only ever assigned paths below the runtime directory, whose
removal takes them along, so those destructors never had an effect.
2026-08-19 02:30:42 +09:00
dongshengyuan 844c44a0d4 timedated: roll back state on config write failure
SetTimezone() and SetLocalRTC() updated the Context before writing
/etc/localtime or /etc/adjtime. If the write failed, D-Bus properties
showed the new value and a repeated request with the same value returned
success without retrying the file update.

Keep the write helpers Context-based, but save the old value before
installing the requested state. Restore the old Context value when the
backing file update fails.

Add TEST-45 coverage for failed alternate localtime and adjtime paths.

Follow-up for: f401e48c2d
2026-08-19 02:29:39 +09:00
dongshengyuan 31ef154f15 core: fix integer truncation checks
Use explicit bounds checks for size_t and long conversions
so compilers cannot optimize away round-trip cast checks.

Follow-up for 78238fd7c9.
2026-08-19 02:28:19 +09:00
Zbigniew Jędrzejewski-Szmek f969973b90 Another batch of conversions to COMMAND and additions of --introspect-cli (#43428) 2026-08-18 18:32:55 +02:00
Zbigniew Jędrzejewski-Szmek 92a97a2b9d dissect: describe the mount.ddi helper interface
Add a second COMMAND() for the mount.ddi helper namespace, like for
mount.storage and mount.mstack, so that it is exposed by --introspect-cli
too.

Fixes 1a54ce154c +
66246c98b5.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek da26e6f744 run0: add --no-pager
Since run0 --help now goes through the pager, provide a way to turn that
off from the command line, like all other commands that page --help. The
option is documented the same way as for systemd-run.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 38d854b114 vpick: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. An explicit "Lookup Keys" option group is added
so that the section heading stays the same.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek b4199e7376 vmspawn: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 60dee66134 tmpfiles: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. An explicit "Commands" option group is added
so that the section heading stays the same. The synopsis is now the same
as for systemd-sysusers, i.e. the "commands" are the options listed in the
Commands section. --help now goes through the pager, like other commands
with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 6109c2a707 sysusers: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. An explicit "Commands" option group is added
so that the section heading stays the same. The abstract is changed to the
imperative. --help now goes through the pager, like other commands with
--no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 0cbeceaea2 updatectl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The odd "Verbs" option group marker is dropped,
so that all options are listed in one section after the verbs, with --help
and --version first. The synopsis now uses the generic "[OPTION…] COMMAND …"
form: a bare VERSION is not accepted as the first argument, and the man
page does not list it either. --help now goes through the pager, like
other commands with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek adc83f020a sysupdate: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The "Options" group marker after --help/--version
is dropped, so that all options are listed in one section after the verbs.
The synopsis now uses the generic "[OPTION…] COMMAND …" form: a bare
VERSION is not accepted as the first argument, and the man page does not
list it either. --help now goes through the pager, like other commands
with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 388eb27018 sysctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. An explicit "Commands" option group is added
so that the section heading stays the same. The abstract is changed to the
imperative. --help now goes through the pager, like other commands with
--no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek ae6f195d63 storagectl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager. The mount.storage helper interface is described
by a second COMMAND(), so that it is exposed by --introspect-cli too.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 3a2d587313 run: convert to VERB_COMMAND and add --introspect-cli
The custom help() and help_sudo_mode() are replaced by COMMAND()
descriptions for systemd-run and run0, and --introspect-cli is added to
both. run0 --help now goes through the pager, like systemd-run --help.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek be5ae9fb40 repart: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 19a24f926d pcrlock: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek bf08fc692a nspawn: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The generic options at the top now get an
"Options" heading like the other groups.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek a9f42ed015 mstack: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The "Commands" option group is moved before the
other options and an explicit "Options" group is added, so that the sections
are printed in the same order as before. --help now goes through the pager,
like other commands with --no-pager. The mount.mstack helper interface is
described by a second COMMAND(), so that it is exposed by --introspect-cli
too.
2026-08-18 16:54:09 +02:00