Commit Graph
87061 Commits
Author SHA1 Message Date
Daan De Meyer 8f56e54a91 ci: Add workflow url to tracking comment in claude-review workflow
Simplifies debugging of failed claude-review workflows.
2026-03-10 19:58:17 +01:00
Daan De Meyer 1254f4f2d2 ci: Don't make a single failed review comment fail the entire job
Let's handle failure to post individual review comments gracefully.
Reduces the impact of failures like in
https://github.com/systemd/systemd/actions/runs/22904601370/job/66461528144.
2026-03-10 19:57:11 +01:00
Daan De Meyer d9cd9b2a1d ci: Update claude review prompt to insist on valid lines
Hopefully fixes the failure in
https://github.com/systemd/systemd/actions/runs/22904601370/job/66461528144.
2026-03-10 19:56:09 +01:00
Daan De Meyer 74c903a28f mount-util: Use new mount API in bind_mount_submounts() (#41008) 2026-03-10 19:49:10 +01:00
Cyrus Xi 9d15e09d5c core/cgroup: fix TasksMaxScale percentage serialization (#41011)
bus_cgroup_set_tasks_max_scale() used a hand-rolled percentage format
that produced values ~10x too small (e.g., "TasksMax=4.0%" instead of
"TasksMax=40.00%").

On daemon-reload, the incorrect value was re-read, silently reducing
the effective TasksMax by ~10x and causing fork rejections on systems
with high thread counts.

Fix by using the existing PERMYRIAD macros, consistent with memory
property handlers (MemoryMax, MemoryHigh, MemoryLow, etc.).

Fixes: #41009
2026-03-11 03:36:21 +09:00
Yu Watanabe f6857cfaf2 fuzz: fix typo
Follow-up for be0db50cad.
2026-03-11 03:23:53 +09:00
Luca Boccassi d42445763e Translations update from Fedora Weblate (#41021)
Translations update from [Fedora
Weblate](https://translate.fedoraproject.org) for
[systemd/main](https://translate.fedoraproject.org/projects/systemd/main/).



Current translation status:

![Weblate translation
status](https://translate.fedoraproject.org/widget/systemd/main/horizontal-auto.svg)
2026-03-10 17:55:43 +00:00
Jesse Guo b15d769b38 po: Translated using Weblate (Chinese (Simplified) (zh_CN))
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: Jesse Guo <jesseguotech@outlook.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/zh_CN/
Translation: systemd/main
2026-03-10 17:30:13 +00:00
naly zzwd 7e0c26e0b2 po: Translated using Weblate (Catalan)
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: naly zzwd <xeanhort007@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/ca/
Translation: systemd/main
2026-03-10 17:30:13 +00:00
Marcel Leismann 9177786a5c po: Translated using Weblate (German)
Currently translated at 99.6% (265 of 266 strings)

Co-authored-by: Marcel Leismann <tiixrigjekfv@use.startmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/de/
Translation: systemd/main
2026-03-10 17:30:13 +00:00
Nandakumar Raghavan 6d7cb9a6b8 networkd: fix for networkd crash when client sends Option 82 via SendOption=
When a DHCP client uses SendOption=82:string:..., option_append() calls
the SD_DHCP_OPTION_RELAY_AGENT_INFORMATION case which was written for
the server relay path. It casts optval to sd_dhcp_server* and calls
strlen() on its members, but optval is actually raw binary data from
the client, causing SIGSEGV. The same is applicable when option 43 and
option 77 are passed to SendOption.

Fix by checking optlen > 0 and appending the option as a plain TLV,
skipping the server-specific relay agent logic.
2026-03-10 18:29:59 +01:00
Luca Boccassi 5647a19a58 nsresourced: downgrade benign log message to debug
This is very noisy as there's a dozen of these message every
time it gets called, and it's not really an error but an
expected situation, so downgrade from info to debug
2026-03-10 18:23:14 +01:00
Lennart Poettering a790339f8b update TODO 2026-03-10 18:19:49 +01:00
Luca Boccassi 128ff3582a mkosi: update debian commit reference to 56e0eed69a4782eb8e110650d93daebcf1ece49a
* 56e0eed69a Update changelog for 260~rc2-1 release
* 36e6a6d247 Install new files
* 692d0ffde5 Install new files for upstream build
* 04e77a9300 Enable getty@ via packaging scriptlets, not static anymore
* 65e7898ab5 Remove build-depend on rsync, meson is new enough
* 1ab5e82a93 Update changelog for 260~rc1-2 release
* 17a8004c53 sd-boot-efi: do not pick up hwids, they are shipped by sd-ukify
* b620f379b3 Update changelog for 260~rc1-1 release
* 8eb95fc404 Drop unused Lintian overrides
* 82a111e7ef Update symbols file for v260~rc1
* 9cb8e0457b Disable remaining deprecated sysv interfaces
* 100d97ba82 Install new files for v260~rc1
* b8e9e50f4d initramfs-tools: copy udev link files from /usr/local/lib/systemd/network too
2026-03-10 16:59:52 +00:00
Zbigniew Jędrzejewski-Szmek 0692870fe4 network: fix issue when configuring route (#41000)
Fixes #40106.
2026-03-10 17:14:15 +01:00
Lennart Poettering 39f118d909 pcrlock: minor tweaks (#41018) 2026-03-10 16:47:18 +01:00
Luca Boccassi 71d023dbca Two claude improvements (#41019) 2026-03-10 15:40:55 +00:00
Daan De Meyer 8e59fb6248 ci: Use one more variable in claude-review workflow 2026-03-10 14:40:00 +01:00
Lennart Poettering 0306b2c20e pcrlock: add .pcrlock file for recently added NvPCR separator
Follow-up for: 867e64737a
2026-03-10 13:52:25 +01:00
Lennart Poettering 2fb2428296 pcrlock: do not pass wrong error to log message 2026-03-10 12:03:17 +01:00
Lennart Poettering 809cb1b4d8 pcrlock: add an extra assert() 2026-03-10 12:03:17 +01:00
Daan De Meyer f2a75354bc ci: Use github MCP in claude review instead of gh command line tool
MCP was specifically made for AI and is available, so we might as well
use it.
2026-03-10 10:58:27 +01:00
Yu Watanabe e7485799a4 semaphore: use Ubuntu 24.04
Semaphore CI/CD now emits the following error.
```
OS image 'ubuntu2004' for machine type 'e1-standard-2' is currently in a brownout phase.
Please use another OS image.
```
Let's use newer image.
2026-03-10 00:47:53 +00:00
ppkramer-hubandpatrick e1877e6b06 mount: honor --timeout-idle-sec=SEC option (#41010)
When using systemd-mount to create a transient .mount/.automount file
for removable storage, the option to specify the idle timeout on the
commandline using **--timeout-idle-sec=SEC** is not reflected in the
generated .automount file. Instead, the idle timeout is always set to 1
second.

arg_timeout_idle_set was never set to true when passing the argument, so
arg_timeout_idle was always set to 1s.

Fixes #41007.

Co-authored-by: patrick <patrick@localhost>
2026-03-10 04:31:53 +09:00
Daan De Meyer 8a19cad8ae ci: Drop tracking comment update from claude review
Too noisy, let's drop it.
2026-03-09 17:55:33 +01:00
Daan De Meyer d733009141 mount-util: Use new mount API in bind_mount_submounts() 2026-03-09 16:25:05 +01:00
Daan De Meyer fbdc5ded88 AGENTS.md: Tell agents to use mkosi box for running commands
mkosi box will run in the tools tree if there is one which is guaranteed
to contain basic tools.
2026-03-09 16:24:20 +01:00
Daan De Meyer b5b21d53c0 ci: Two claude fixes (#41004) 2026-03-09 12:05:27 +01:00
Daan De Meyer 47e9876312 ci: Update claude action to v1 commit
I accidentally picked a random commit instead of the one pointing
to the official v1 release, let's fix that.
2026-03-09 11:18:44 +01:00
Daan De Meyer 48b3642dd1 ci: Don't cancel in progress jobs for claude-review workflow
This workflow runs on any comment to a github PR. 99% of the time the
workflow will be skipped yet it will still cancel any previous ongoing
workflows. Let's not cancel in progress workflow but instead queue the
workflow so we don't cancel in progress reviews any time a comment is
posted on a PR that is being reviewed.
2026-03-09 11:15:34 +01:00
Daan De Meyer a023d2bbdb ci: privilege-separate Claude review workflow
The workflow is split into two jobs for least-privilege:

1. 'review' job — runs Claude with read-only permissions (contents: read,
   id-token: write for AWS OIDC, actions: read). Claude produces a structured
   JSON review via --json-schema with a 'comments' array and a 'summary'
   string. Its tools are restricted to read-only operations (Read, LS, Grep,
   Glob, Task, and various Bash prefixes for common read-only commands).
   Claude also has access to CI MCP tools to analyze failed workflow runs.

2. 'post' job — only has pull-requests: write. Reads the structured JSON
   output from the review job and posts inline comments individually (so
   re-runs only add new comments). Maintains a tracking comment with a
   <!-- claude-pr-review --> marker that is created on first run and updated
   in-place on subsequent runs, preserving existing item order, wording,
   and checkbox state. Posts a notification comment when the tracking
   comment is updated or left unchanged.

Comment deduplication is handled by Claude in the prompt rather than in
the posting script, allowing for better semantic understanding of whether
two comments address the same issue.

The PR number is resolved via github.event.pull_request.number with a
fallback to github.event.issue.number for issue_comment events where
github.event.pull_request is not populated. The concurrency group uses
the same fallback.

Co-developed-by: Claude <claude@anthropic.com>
2026-03-09 09:45:31 +01:00
Yu Watanabe f47d180b85 test-network: add test case for issue #40106 2026-03-09 12:31:41 +09:00
Yu Watanabe ed54648b47 network: route bound to a link requires the link is up
We checked if the link is up only when configuring (explicit) nexthop,
but we did not checked that when configuring route which has (implicit)
nexthop.

Let's move the checks from nexthop_is_ready_to_configure() to
gateway_is_ready(), which is called for both implicit and explict
nexthops.

Fixes #40106.
2026-03-09 11:46:14 +09:00
Yu Watanabe 43989de642 network: check if gateway is ready only when the nexthop is bound to link
Currently, we support three types of nexthop:
1. simple nexthop, which is bound to link, may have specific gateway
   address,
2. blackhole nexthop, which is global configuration and is not bound to
   any links,
3. group nexthop, which is also global configuration and is not bound to
   any links.

Thus, gateway_is_ready() is only necessary to call for simple nexthop
case. Let's make the logic simpler.
2026-03-09 11:42:45 +09:00
Yu Watanabe ec4f646759 network: introduce link_is_up() helper function 2026-03-09 10:57:06 +09:00
Malcolm Frazier 20911fe177 man: fix SendHostname= and Hostname= descriptions to allow multi-label DNS names in [DHCPv4] 2026-03-09 09:42:21 +09:00
Yu Watanabe 2cb0ccebf6 Shorten format-table code and fix potential memleak (#40917) 2026-03-09 09:26:30 +09:00
Martin Srebotnjak 3db5a017d3 po: Translated using Weblate (Slovenian)
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/sl/
Translation: systemd/main
2026-03-09 00:11:40 +00:00
Andrii Zora 42e3801efc hwdb: update HP Envy x360 patterns to cover newer 14-fc0xxx models
Signed-off-by: Andrii Zora <anaxarsys@gmail.com>
2026-03-08 22:24:15 +00:00
David Santamaría Rogado c2d0465582 hwdb: sensor: bncf reformat match 2026-03-08 21:18:21 +00:00
The-An0nym 09c92eef12 Fix media keys for Lenovo ThinkBook 14 2-in-1 G5 IAU 2026-03-08 10:52:34 +00:00
Arjun-C-S da1cedd144 hwdb: map Xiaomi Mi Notebook Pro star key to KEY_MACRO
The Xiaomi Mi Notebook Pro keyboard has a "star" key that
generates AT keyboard scancode 0x72 but is not mapped in
the default hwdb.

Map it to KEY_MACRO so it appears as a usable input key.

Verified using evtest.

Signed-off-by: Arjun <arjunchoozhi1234@gmail.com>
2026-03-08 10:51:56 +00:00
Zbigniew Jędrzejewski-Szmek 0bec1191a9 user-record: fix segfault when processing matchHostname field (#40979)
Fix a typo which causes a segfault when processing a user record
with `matchHostname` when it's an array instead of a simple string:

```
$ echo '{"userName":"crashhostarray","perMachine":[{"matchHostname":["host1","host2"],"locked":false}]}' | userdbctl -F -
Segmentation fault         (core dumped)

$ coredumpctl info
...
       Message: Process 1172301 (userdbctl) of user 1000 dumped core.

                Module libz.so.1 from rpm zlib-ng-2.3.3-1.fc43.x86_64
                Module libcrypto.so.3 from rpm openssl-3.5.4-2.fc43.x86_64
                Stack trace of thread 1172301:
                #0  0x00007fded7b3a656 __strcmp_evex (libc.so.6 + 0x159656)
                #1  0x00007fded7e95397 per_machine_hostname_match (libsystemd-shared-260.so + 0x295397)
                #2  0x00007fded7e955b5 per_machine_match (libsystemd-shared-260.so + 0x2955b5)
                #3  0x00007fded7e957c6 dispatch_per_machine (libsystemd-shared-260.so + 0x2957c6)
                #4  0x00007fded7e96c97 user_record_load (libsystemd-shared-260.so + 0x296c97)
                #5  0x000000000040572d display_user (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x572d)
                #6  0x00007fded7ea9727 dispatch_verb (libsystemd-shared-260.so + 0x2a9727)
                #7  0x000000000041077c run (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x1077c)
                #8  0x00000000004107ce main (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x107ce)
                #9  0x00007fded79e45b5 __libc_start_call_main (libc.so.6 + 0x35b5)
                #10 0x00007fded79e4668 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x3668)
                #11 0x00000000004038d5 _start (/home/fsumsal/repos/@systemd/systemd/build/userdbctl + 0x38d5)
                ELF object binary architecture: AMD x86-64
```
2026-03-07 16:22:02 +01:00
Luca Boccassi 3c98810142 Translations update from Fedora Weblate (#40984)
Translations update from [Fedora
Weblate](https://translate.fedoraproject.org) for
[systemd/main](https://translate.fedoraproject.org/projects/systemd/main/).



Current translation status:

![Weblate translation
status](https://translate.fedoraproject.org/widget/systemd/main/horizontal-auto.svg)
2026-03-07 10:55:42 +00:00
Oğuz Ersen 41bb2bcb1d po: Translated using Weblate (Turkish)
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: Oğuz Ersen <oguz@ersen.moe>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/tr/
Translation: systemd/main
2026-03-07 01:58:37 +00:00
Daniel Nylander 9352803619 po: Translated using Weblate (Swedish)
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: Daniel Nylander <po@danielnylander.se>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/sv/
Translation: systemd/main
2026-03-07 01:58:36 +00:00
Baurzhan Muftakhidinov aadee8f817 po: Translated using Weblate (Kazakh)
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: Baurzhan Muftakhidinov <baurthefirst@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/kk/
Translation: systemd/main
2026-03-07 01:58:36 +00:00
김인수 4089bc7485 po: Translated using Weblate (Korean)
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: 김인수 <simmon@nplob.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/ko/
Translation: systemd/main
2026-03-07 01:58:35 +00:00
A S Alam 4e95ea0dab po: Translated using Weblate (Punjabi)
Currently translated at 34.5% (92 of 266 strings)

Co-authored-by: A S Alam <aalam@users.noreply.translate.fedoraproject.org>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/pa/
Translation: systemd/main
2026-03-07 01:58:35 +00:00
Léane GRASSER 4020a4d76d po: Translated using Weblate (French)
Currently translated at 100.0% (266 of 266 strings)

Co-authored-by: Léane GRASSER <leane.grasser@proton.me>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/fr/
Translation: systemd/main
2026-03-07 01:58:34 +00:00