SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
91,860 Commits 2 Branches 1 Tag
main-with-ancient-kernel
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Antonio Alvarez Feijoo e1515be25b clonesetup-generator: set IgnoreOnIsolate=yes on generated units 
If /sysroot is mounted in the initrd on a cloned device, initrd-cleanup.service
will stop this unit (via `systemctl isolate initrd-switch-root.target`).

cryptsetup-generator, veritysetup-generator and integritysetup-generator all set
"IgnoreOnIsolate=yes" on their generated units for this reason.
 2026-08-18 20:18:03 +09:00
Antonio Alvarez Feijoo efc207d7ab rules: do not install 60-tpm2-id.rules without TPM2 support 
This change also allows to import `tpm2_id` as a built-in instead of as a
program.
 2026-07-29 01:23:14 +09:00
Antonio Alvarez Feijoo b888e6b99f ssl-util: set log level to debug in dlopen_many_sym_or_warn() 
Otherwise in systems with OpenSSL 3 the journal contains multiple error entries
because the preferred library libssl.so.4 is not present.

Follow-up for 6caa50183e
 2026-06-30 11:29:10 +02:00
Antonio Alvarez Feijoo 7b305b05af crypto-util: set log level to debug in dlopen_many_sym_or_warn() 
Otherwise in systems with OpenSSL 3 the journal contains multiple error entries
because the preferred library libcrypto.so.4 is not present.

Follow-up for ccdd42351f
 2026-06-30 10:39:16 +02:00
Antonio Alvarez Feijoo 7b2c004345 resolve: only write one ELF note for libcrypto 
systemd-resolved has 2 contradictory ELF notes for libcrypto:

```
$ systemd-analyze dlopen-metadata /usr/lib/systemd/systemd-resolved
FEATURE   DESCRIPTION                                SONAME         PRIORITY
libcrypto Support for cryptographic operations       libcrypto.so.3 recommended
idn       Support for internationalized domain names libidn2.so.0   recommended
libcrypto Support for cryptographic operations       libcrypto.so.3 required
libssl    Support for TLS                            libssl.so.3    required
```

In order to have a single note, condition its priority based on whether
DNS-over-TLS is enabled.
 2026-06-04 18:33:19 +01:00
Antonio Alvarez Feijoo dfa5aa07b5 man: clarify that /etc/verity.d only parses certificates with the .crt extension 
Exposed in the dracut testsuite while adding tests for sysexts:

```
[    2.972948] localhost (sd-merge)[510]: Validation of dm-verity signature failed via the kernel, trying userspace validation instead: Required key not available
[    2.972993] localhost (sd-merge)[510]: Skipping file '/etc/verity.d/dracut.pem', suffix is not '.crt'.
[    2.973045] localhost (sd-merge)[510]: No userspace dm-verity certificates found.
```
 2026-04-23 15:39:29 +02:00
Antonio Alvarez Feijoo 341251b6e3 dissect-image: fix typo in log message 2026-04-23 15:39:14 +02:00
Antonio Alvarez Feijoo f9ac6aced9 repart: raise log level to LOG_ERR if dlopen_fdisk() fails 
libfdisk is required by systemd-repart and it silently exits if dlopen fails
(unless the debug log level is set):

```
$ SYSTEMD_LOG_LEVEL=debug systemd-repart
Shared library 'libfdisk.so.1' is not available: libfdisk.so.1: cannot open shared object file: No such file or directory
$ echo $?
1
```

Follow-up for d49f3f287a
 2026-04-23 12:16:58 +02:00
Antonio Alvarez Feijoo d2983ba6e7 man: fix typos in some binary names 2026-03-31 09:47:27 +01:00
Antonio Alvarez Feijoo fb292e18d8 mkosi: fix typo in UKI profile title 2026-03-17 17:50:04 +00:00
Antonio Alvarez Feijoo 4ef56f30b8 mkosi/opensuse: fix package name systemd-network -> systemd-networkd 
```
'systemd-network' not found in package names. Trying capabilities.
```

Follow-up for 00f7afebb4
 2026-03-06 10:10:53 +00:00
Antonio Alvarez Feijoo 8ea1ae25ab import/pull-oci: fix several OOM checks 
Follow-up for a9f6ba0496
 2026-02-24 17:34:09 +01:00
Antonio Alvarez Feijoo 29a5ffb82b man/systemd.mstack: use <varname> instead of <variable> 
Otherwise, `<variable>location</variable>` is rendered:

```
[2365/2925] Generating man/systemd.mstack.7 with a custom command
Element variable in namespace '' encountered in para, but no template matches.
```
 2026-02-23 10:07:30 +01:00
Antonio Alvarez Feijoo 16e7869cf3 mstack: parse --mkdir option 
```
systemd-mstack: unrecognized option '--mkdir'
```

Follow-up for 8187cd18d6
 2026-02-20 16:56:16 +01:00
Antonio Alvarez Feijoo 2f76b10b94 import-generator: fix sysext/confext ordering in initrd 
In the initrd, order the generated `systemd-import@.service` units before the
initrd-specific sysext/confext units.
 2026-02-03 08:18:41 +09:00
Antonio Alvarez Feijoo 5327755f8b discover-image: fix typo in log message 2026-02-02 22:24:28 +09:00
Antonio Alvarez Feijoo b0b2a71d81 tar-util: do not error out if archive_read_next_header() returns ARCHIVE_WARN 
archive_read_header(3) states that `archive_read_next_header()` returns
`ARCHIVE_WARN` if it succeeds but a non-critical error is found, so issue a
warning instead of stopping the untar process in this case.
 2026-01-29 02:41:11 +09:00
Antonio Alvarez Feijoo 236033fd48 man/fstab-generator: correct root= options 
Remove duplicate "fstab" option, and add missing "tmpfs" and "bind:" options.
 2026-01-23 13:29:31 +01:00
Antonio Alvarez Feijoo 96138c6237 tree-wide: use full paths to tools defined in config.h 2026-01-12 22:17:36 +01:00
Antonio Alvarez Feijoo 5b603f4d06 systemctl-preset-all: do not return 0 if unit_file_preset_all() fails 
Follow-up for ae9ff778cd
 2026-01-03 04:53:44 +09:00
Antonio Alvarez Feijoo 2824182a12 inhibit: allow filtering --list also by what, who and why 
Currently the list can only be filtered by mode, so make use of the remaining
options available to filter the output.
 2025-12-17 23:23:44 +00:00
Antonio Alvarez Feijoo c40ab2337f inhibit: add --json support for --list 2025-12-17 23:23:44 +00:00
Antonio Alvarez Feijoo 2ed0cc458f vmspawn: fix typo in log specifier 
Follow-up for 179dcf924f
 2025-12-11 01:12:27 +09:00
Antonio Alvarez Feijoo a308e97ad2 run-generator: use generator_add_symlink() 2025-12-03 15:52:55 +01:00
Antonio Alvarez Feijoo 6b892f85e2 man/inhibit: mention handle-reboot-key operation 2025-12-03 17:55:50 +09:00
Antonio Álvarez Feijoo 4ae16cf9b7 kernel-install: exit with option --json=help (#39974) 
In that case, `parse_json_argument()` returns 0.

Follow-up for bdd36c003d (v255).
 2025-12-03 01:56:01 +09:00
Antonio Alvarez Feijoo 7599d26436 run: fix two minor memory leaks 
```
==19541== 8 bytes in 1 blocks are still reachable in loss record 1 of 3
==19541==    at 0x4841744: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==19541==    by 0x50125C9: strdup (strdup.c:42)
==19541==    by 0x4C55925: getusername_malloc (user-util.c:154)
==19541==    by 0x1121D6: parse_argv_sudo_mode (run.c:1098)
==19541==    by 0x123B13: run (run.c:3032)
==19541==    by 0x124198: main (run.c:3100)
==19541==
==19541== 11 bytes in 1 blocks are still reachable in loss record 2 of 3
==19541==    at 0x4841744: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==19541==    by 0x50125C9: strdup (strdup.c:42)
==19541==    by 0x112A9C: parse_argv_sudo_mode (run.c:1182)
==19541==    by 0x123B13: run (run.c:3032)
==19541==    by 0x124198: main (run.c:3100)
```
 2025-11-24 16:03:34 +00:00
Antonio Alvarez Feijoo 3eabddbe9f gpt-auto-generator: fix typo in crypttab option name 
Spotted while debugging a ParticleOS build:

```
Nov 13 14:44:32 localhost systemd-cryptsetup[591]: Encountered unknown /etc/crypttab option 'tpm2-measure-slot-nvpcr=cryptsetup', ignoring.
```

Follow-up for e5a2e78665
 2025-11-14 03:50:15 +09:00
Antonio Alvarez Feijoo b8ad88a407 meson: fix HAVE_LIBARCHIVE_* conditions 
Follow-up for a7c8f92d1f
 2025-10-16 11:48:53 +01:00
Antonio Alvarez Feijoo 2fbfbfc5fa test: enable TEST-06-SELINUX in openSUSE 
openSUSE switched to SELinux by default for quite some time now, so this test is
also successful.
 2025-10-14 17:56:39 +01:00
Antonio Alvarez Feijoo a35780d5d0 creds: fix return type from normalize_separator() 
Follow-up for 097374f3b9
 2025-10-09 12:09:06 +01:00
Antonio Alvarez Feijoo 575087d68b man/factory-reset: fix typo in EFI variable name 2025-10-08 17:02:21 +02:00
Antonio Alvarez Feijoo 13abd21c9f mute-console: remove unimplemented option 
```
$ build/systemd-mute-console -q
Code should not be reached at src/mute-console/mute-console.c:103, function parse_argv(). Aborting. 💥
Aborted (core dumped)
```
 2025-10-06 16:11:39 +02:00
Antonio Alvarez Feijoo e77566fbca libblkid: fix build with blkid disabled 
Prompted by c349edfe49, but it didn't work before.
 2025-09-25 11:03:24 +02:00
Antonio Alvarez Feijoo f784a63cfa libaudit-util: fix build with audit disabled 
```
In file included from ../src/test/test-dlopen-so.c:21:
../src/test/test-dlopen-so.c: In function ‘run’:
../src/test/test-dlopen-so.c:53:23: error: implicit declaration of function ‘dlopen_libaudit’; did you mean ‘dlopen_libfido2’? [-Werror=implicit-function-declaration]
   53 |         ASSERT_DLOPEN(dlopen_libaudit, HAVE_AUDIT);
      |                       ^~~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-dlopen-so.c:53:9: note: in expansion of macro ‘ASSERT_DLOPEN’
   53 |         ASSERT_DLOPEN(dlopen_libaudit, HAVE_AUDIT);
      |         ^~~~~~~~~~~~~
../src/test/test-dlopen-so.c:53:23: warning: nested extern declaration of ‘dlopen_libaudit’ [-Wnested-externs]
   53 |         ASSERT_DLOPEN(dlopen_libaudit, HAVE_AUDIT);
      |                       ^~~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-dlopen-so.c:53:9: note: in expansion of macro ‘ASSERT_DLOPEN’
   53 |         ASSERT_DLOPEN(dlopen_libaudit, HAVE_AUDIT);
      |         ^~~~~~~~~~~~~

```

Follow-up for 4d8c5c657a
 2025-09-22 18:17:52 +01:00
Antonio Alvarez Feijoo 559da4a509 bash-completion/bootctl: add missing options and verb 2025-09-08 12:37:26 +02:00
Antonio Alvarez Feijoo aa089759ad man/bootctl: replace reference to --no-variables with --variables=no 2025-09-08 12:32:13 +02:00
Antonio Alvarez Feijoo 5a70aa5315 bootctl: clarify that --secure-boot-auto-enroll requires a boolean value 2025-09-08 12:31:27 +02:00
Antonio Alvarez Feijoo 992716c9ab bootctl: fix reference to non-existent option in error log 2025-09-08 12:30:35 +02:00
Antonio Alvarez Feijoo 3eb590f2b0 tree-wide: avoid logging 2 error messages if table_print_with_pager() fails 
`table_print_with_pager()` already calls `table_log_print_error()` internally if
there is an error.
 2025-08-28 14:09:50 +02:00
Antonio Alvarez Feijoo 134fde8666 resolvectl: add missing error check 
Follow-up for 45817e9245
 2025-08-28 14:09:14 +02:00
Antonio Alvarez Feijoo a83ba27b89 test-nss-hosts: do not call seccomp functions if HAVE_SECCOMP is not set 
Otherwise, the build fails:

```
  Features
...
    disabled                                 : ACL, SECCOMP, ...
...
[1592/2115] Compiling C object test-nss-hosts.p/src_test_test-nss-hosts.c.o
FAILED: test-nss-hosts.p/src_test_test-nss-hosts.c.o
...
In file included from ../src/test/test-nss-hosts.c:27:
../src/test/test-nss-hosts.c: In function ‘run’:
../src/test/test-nss-hosts.c:497:43: error: implicit declaration of function ‘seccomp_filter_set_add_by_name’ [-Werror=implicit-function-declaration]
  497 |                                 ASSERT_OK(seccomp_filter_set_add_by_name(filter, /* add = */ true, s));
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-nss-hosts.c:497:43: warning: nested extern declaration of ‘seccomp_filter_set_add_by_name’ [-Wnested-externs]
  497 |                                 ASSERT_OK(seccomp_filter_set_add_by_name(filter, /* add = */ true, s));
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-nss-hosts.c:498:35: error: implicit declaration of function ‘seccomp_load_syscall_filter_set_raw’ [-Werror=implicit-function-declaration]
  498 |                         ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing = */ true));
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-nss-hosts.c:498:35: warning: nested extern declaration of ‘seccomp_load_syscall_filter_set_raw’ [-Wnested-externs]
  498 |                         ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing = */ true));
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-nss-hosts.c:498:71: error: ‘SCMP_ACT_ALLOW’ undeclared (first use in this function)
  498 |                         ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing = */ true));
      |                                                                       ^~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-nss-hosts.c:498:71: note: each undeclared identifier is reported only once for each function it appears in
  498 |                         ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing = */ true));
      |                                                                       ^~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-nss-hosts.c:498:95: error: implicit declaration of function ‘SCMP_ACT_ERRNO’ [-Werror=implicit-function-declaration]
  498 |                         ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing = */ true));
      |                                                                                               ^~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
../src/test/test-nss-hosts.c:498:95: warning: nested extern declaration of ‘SCMP_ACT_ERRNO’ [-Wnested-externs]
  498 |                         ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing = */ true));
      |                                                                                               ^~~~~~~~~~~~~~
../src/shared/tests.h:181:24: note: in definition of macro ‘ASSERT_OK’
  181 |                 typeof(expr) _result = (expr);                                                                  \
      |                        ^~~~
cc1: some warnings being treated as errors
```

Fixes 788b3e030e
 2025-08-18 13:02:21 +01:00
Antonio Alvarez Feijoo 13358b7ce2 bootctl: specify that kernel image commands require a kernel image argument 2025-08-13 11:28:22 +01:00
Antonio Alvarez Feijoo 600bbac35f systemctl: remove unnecessary assignment 2025-07-16 21:03:10 +09:00
Antonio Alvarez Feijoo dee77ac201 generate-bpf-delegate-configs: fix compatibility with Python 3.7 
- Operator ":=" requires Python 3.8 or newer.
- list[str] requires Python 3.9 or newer.

Follow-up for ea9826eb94
 2025-07-10 13:30:44 +09:00
Antonio Alvarez Feijoo e16769b8c0 ptyfwd: use hostname argument in pty_forward_set_window_title() if set 
Fixes 23f9ff4724
 2025-06-09 16:24:44 +01:00
Antonio Alvarez Feijoo 0425fc5eb7 log: fix declaration of log_dispatch_internal() 2025-05-12 23:42:19 +09:00
Antonio Alvarez Feijoo cec81b234c gpt-auto-generator: fix memory leak 
Follow-up for 74cfd0921c
 2025-04-04 20:02:02 +09:00
Antonio Alvarez Feijoo cef2181cda umount: do not move busy network mounts 
If a network mount returns EBUSY on umount, the logic introduced in
6dc68a00cf causes shutdown to hang indefinitely on
`fstatat()` (i.e., within `is_dir(m->path, true)`). Hence, skip this logic for
network mounts (following the same motivation we use to skip read-only mounts in
this kind of file systems).

Fixes 6dc68a00cf
 2025-03-11 05:53:31 +09:00
Antonio Alvarez Feijoo 5d2d0c055b import/pull-tar: fix flag set 
There is a typo passing flags to `install_file()`, if `IMPORT_READ_ONLY` is set,
`IMPORT_SYNC` is never checked.
 2025-02-26 13:06:31 +00:00
Antonio Alvarez Feijoo 49879a32b6 tools/fetch-distro: support the case where the sources are in a subdirectory 
If the GIT_SUBDIR environment variable is set, do not checkout the full sources
of the git repository, but perform a sparse checkout of the directory containing
the package. In this case, check only the commit history in this subdirectory.
 2025-01-15 15:33:00 +00:00
Antonio Alvarez Feijoo 5c79396def units: some improvements in breakpoint-* units. 
- Set `RefuseManualStart=yes`.
- Order before shutdown.target and emergency.target.
- Remove wrong `Wants=remote-fs.target` dependency from
breakpoint-pre-switch-root.service.
- Remove unneeded `After=sysroot.mount` from breakpoint-pre-switch-root.service
(implied by initrd.target).
 2025-01-03 08:32:43 +01:00
Antonio Alvarez Feijoo aeb97a49c3 debug-generator: use helper to check breakpoint validity 2025-01-03 08:32:27 +01:00
Antonio Alvarez Feijoo b70ba82241 units/breakpoint-pre-basic.service: explicitly order it before sysroot.mount 
If `rd.systemd.break=pre-mount` is not set during boot, there is no unit that
prevents sysroot.mount from being activated.
 2025-01-02 15:00:34 +01:00
Antonio Alvarez Feijoo e6922ac334 man/debug-generator: replace "main system" with "host" 2025-01-02 14:59:00 +01:00
Antonio Alvarez Feijoo 07638ce2a4 mkosi: switch to github mirror of openSUSE sources from build.opensuse.org 
The current src.opensuse.org is very unstable and commit hashes are reset (or
even removed) every now and then. While the official repo is not fixed, let's
move to a more stable source, the github mirror of code.opensuse.org, maintained
since 2019.
 2024-12-30 17:39:16 +01:00
Antonio Alvarez Feijoo 8a6ad7c837 mkosi: add libopenssl devel package to openSUSE tools tree 
Otherwise, the build fails with:

```
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /mnt/work/src/systemd/upstream-fork/main/build-mkosi
ninja: Entering directory `/mnt/work/src/systemd/upstream-fork/main/build-mkosi'
[463/2561] Compiling C object src/shared/libsystemd-shared-258.a.p/openssl-util.c.o
FAILED: src/shared/libsystemd-shared-258.a.p/openssl-util.c.o
cc -Isrc/shared/libsystemd-shared-258.a.p -Isrc/shared -I../src/shared -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I. -I.. -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-json -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-path -I../src/libsystemd/sd-resolve -I../src/libsystemd/sd-varlink -I/usr/include/blkid -I/usr/include/libmount -I/usr/include/p11-kit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -Wno-missing-field-initializers -Wno-unused-parameter -Wno-nonnull-compare -Warray-bounds -Warray-bounds=2 -Wdate-time -Wendif-labels -Werror=format=2 -Werror=format-signedness -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=missing-declarations -Werror=missing-prototypes -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=strict-flex-arrays -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wzero-length-bounds -fdiagnostics-show-option -fno-common -fstack-protector -fstack-protector-strong -fstrict-flex-arrays=3 --param=ssp-buffer-size=4 -Wno-unused-result -Werror=shadow -fPIC -fno-strict-aliasing -fstrict-flex-arrays=1 -fvisibility=hidden -fno-omit-frame-pointer -include config.h -pthread -fvisibility=default -MD -MQ src/shared/libsystemd-shared-258.a.p/openssl-util.c.o -MF src/shared/libsystemd-shared-258.a.p/openssl-util.c.o.d -o src/shared/libsystemd-shared-258.a.p/openssl-util.c.o -c ../src/shared/openssl-util.c
../src/shared/openssl-util.c: In function ‘openssl_ask_password_ui_read’:
../src/shared/openssl-util.c:1395:65: error: implicit declaration of function ‘UI_method_get_ex_data’; did you mean ‘UI_method_get_reader’? [-Wimplicit-function-declaration]
 1395 |                 AskPasswordRequest *req = (AskPasswordRequest*) UI_method_get_ex_data(UI_get_method(ui), 0);
      |                                                                 ^~~~~~~~~~~~~~~~~~~~~
      |                                                                 UI_method_get_reader
../src/shared/openssl-util.c:1395:65: warning: nested extern declaration of ‘UI_method_get_ex_data’ [-Wnested-externs]
../src/shared/openssl-util.c:1395:43: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 1395 |                 AskPasswordRequest *req = (AskPasswordRequest*) UI_method_get_ex_data(UI_get_method(ui), 0);
      |                                           ^
../src/shared/openssl-util.c: In function ‘openssl_ask_password_ui_new’:
../src/shared/openssl-util.c:1479:13: error: implicit declaration of function ‘UI_method_set_ex_data’; did you mean ‘UI_method_set_reader’? [-Wimplicit-function-declaration]
 1479 |         if (UI_method_set_ex_data(ui->method, 0, &ui->request) == 0)
      |             ^~~~~~~~~~~~~~~~~~~~~
      |             UI_method_set_reader
../src/shared/openssl-util.c:1479:13: warning: nested extern declaration of ‘UI_method_set_ex_data’ [-Wnested-externs]
[480/2561] Compiling C object src/shared/libsystemd-shared-258.a.p/pkcs11-util.c.o
ninja: build stopped: subcommand failed.
```
 2024-12-30 17:38:36 +01:00
Antonio Alvarez Feijoo 37c2be73e7 mkosi: update openSUSE commit reference 
Force-pushed as usual, now HEAD is v257.1.
 2024-12-30 11:31:38 +00:00
Antonio Alvarez Feijoo 84624d8c99 ukify: fix typos 2024-12-30 10:50:25 +00:00
Antonio Alvarez Feijoo 7cb72bdaeb udevd: add missing header for glibc < 2.34 
```
[77/1697] Compiling C object udevadm.p/src_udev_udevd.c.o
FAILED: udevadm.p/src_udev_udevd.c.o
cc -Iudevadm.p -I. -I.. -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-json -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-path -I../src/libsystemd/sd-resolve -I../src/libsystemd/sd-varlink -Isrc/shared -I../src/shared -I/usr/include/blkid -I/usr/include/kmod -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -Wno-missing-field-initializers -Wno-unused-parameter -Wno-nonnull-compare -Warray-bounds -Warray-bounds=2 -Wdate-time -Wendif-labels -Werror=format=2 -Werror=format-signedness -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=missing-declarations -Werror=missing-prototypes -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wzero-length-bounds -fdiagnostics-show-option -fno-common -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -Wno-unused-result -Werror=shadow -fno-strict-aliasing -fvisibility=hidden -fno-omit-frame-pointer -include config.h -pthread -MD -MQ udevadm.p/src_udev_udevd.c.o -MF udevadm.p/src_udev_udevd.c.o.d -o udevadm.p/src_udev_udevd.c.o -c ../src/udev/udevd.c
../src/udev/udevd.c: In function ‘run_udevd’:
../src/udev/udevd.c:67:23: error: implicit declaration of function ‘fork’ [-Werror=implicit-function-declaration]
   67 |                 pid = fork();
      |                       ^~~~
../src/udev/udevd.c:75:24: error: implicit declaration of function ‘setsid’; did you mean ‘setbit’? [-Werror=implicit-function-declaration]
   75 |                 (void) setsid();
      |                        ^~~~~~
      |                        setbit
../src/udev/udevd.c:75:24: warning: nested extern declaration of ‘setsid’ [-Wnested-externs]
```

Follow-up for 394a678aec
 2024-12-26 11:02:55 +01:00
Antonio Alvarez Feijoo b1378b4c01 vmspawn-register: add missing header for glibc < 2.34 
Fixes #35755
 2024-12-26 11:02:34 +01:00
Antonio Alvarez Feijoo e9f781a5a4 debug-generator: add a kernel cmdline option to pause the boot process 
Introduce the `systemd.break=` kernel command line option to allow stopping the
boot process at a certain point and spawn a debug shell. After exiting this
shell, the system will resume booting.

It accepts the following values:
- `pre-udev`: before starting to process kernel uevents (initrd and host).
- `pre-basic`: before leaving early boot and regular services start (initrd and
host).
- `pre-mount`: before the root filesystem is mounted (initrd).
- `pre-switch-root`: before switching root (initrd).
 2024-12-20 08:51:23 +01:00
Antonio Alvarez Feijoo cb3801a4c9 man/debug-generator: add a section for kernel command line options 2024-12-20 08:48:23 +01:00
Antonio Alvarez Feijoo 5aab7ad075 boot: do not build test-hwids-section.c if ukify is disabled 
Otherwise the build fails:

```
[22/3075] Generating src/boot/test-hwids-section.c with a custom command (wrapped by meson to capture output)
FAILED: src/boot/test-hwids-section.c
/usr/bin/meson --internal exe --capture src/boot/test-hwids-section.c -- /usr/bin/python3.10 /mnt/work/systemd/upstream-fork/main/src/boot/generate-hwids-section.py /mnt/work/systemd/upstream-fork/main/src/boot/hwids
--- stderr ---
Traceback (most recent call last):
  File "/mnt/work/systemd/upstream-fork/main/src/boot/generate-hwids-section.py", line 12, in <module>
    import ukify
  File "/mnt/work/systemd/upstream-fork/main/src/boot/../ukify/ukify.py", line 61, in <module>
    import pefile  # type: ignore
ModuleNotFoundError: No module named 'pefile'
```

Follow-up for 640f8c3eb8
 2024-12-17 11:15:39 +00:00
Antonio Alvarez Feijoo b31e63960d libfido2-util: show also verity features when listing FIDO2 devices 
This way, users don't have to check those features using an external program, or
wait for later failure when trying to enroll using an unsupported feature.
 2024-12-11 17:28:30 +01:00
Antonio Alvarez Feijoo d950f897d9 libfido2-util: reorder dl symbols alphabetically 2024-12-11 07:33:02 +01:00
Antonio Alvarez Feijoo 62b7b70bb7 man/systemd-cryptenroll: sort --fido2-credential-algorithm after --fido2-device 
And also fix a typo.
 2024-12-11 07:32:04 +01:00
Antonio Alvarez Feijoo 61cf8472e7 man: remove references to invalid rd.systemd.image_policy option 
The option with the `rd.` prefix is not implemented, the image policy is not
applied in the initrd.
 2024-12-03 19:36:41 +01:00
Antonio Alvarez Feijoo 9ed090230e tpm2-util: fix parameter name 2024-11-22 16:04:16 +01:00
Antonio Alvarez Feijoo 2ccacdd57c bash-completion: add --list-devices to systemd-cryptenroll 
And also use it to list suitable block devices.
 2024-11-22 10:38:19 +01:00
Antonio Alvarez Feijoo 58c3c2886d cryptenroll: fix typo 2024-11-20 18:03:44 +00:00
Antonio Alvarez Feijoo a04d42821b man/kernel-command-line: fix typo 2024-11-19 13:59:11 +01:00
Antonio Alvarez Feijoo 2b251491de cryptenroll: show better log message if slot to wipe does not exist 
```
$ systemd-cryptenroll /dev/vda3
SLOT TYPE
   0 password
$ systemd-cryptenroll --wipe-slot 1 /dev/vda3
Failed to wipe slot 1, continuing: No such file or directory
```
 2024-11-19 12:00:50 +01:00
Antonio Alvarez Feijoo 2a310c0ad6 sbsign: remove unused --no-pager option 2024-11-12 17:52:48 +01:00
Antonio Alvarez Feijoo 05a0366381 man/systemd-keyutil: fix rendering typo 2024-11-12 17:54:07 +09:00
Antonio Alvarez Feijoo 215292d09e sbsign: remove unimplemented options 2024-11-07 09:47:50 +00:00
Antonio Alvarez Feijoo 11de19f3da veritysetup-generator: remove unused code 2024-10-24 10:07:45 +02:00
Antonio Alvarez Feijoo e98e3f856d man/veritysetup-generator: document veritytab kernel command line option 2024-10-24 10:07:28 +02:00
Antonio Alvarez Feijoo dcbfc7872e man: fix links to veritysetup(8) 2024-10-24 09:54:48 +02:00
Antonio Alvarez Feijoo 5b9de8adef updatectl: remove unimplemented option 2024-10-14 13:30:46 +02:00
Antonio Alvarez Feijoo 16b50d4018 core: fix copy/paste error 2024-10-02 22:15:41 +01:00
Antonio Alvarez Feijoo fb4c82b643 nsresourced: fix build without libbpf 
```
In file included from ../src/nsresourced/nsresourced-manager.c:9:
../src/shared/bpf-link.h:5:10: fatal error: bpf/libbpf.h: No such file or directory
    5 | #include <bpf/libbpf.h>
      |          ^~~~~~~~~~~~~~
```

Follow-up for 46718d344f
 2024-09-18 16:44:12 +02:00
Antonio Alvarez Feijoo bf39626d61 man/repart: use <varname> instead of <variable> 
Otherwise, `<variable>$BOOT</variable>` is rendered:

```
[2548/2992] Generating man/repart.d.5 with a custom command
Element variable in namespace '' encountered in para, but no template matches.
Element variable in namespace '' encountered in para, but no template matches.
```
 2024-09-18 16:03:56 +02:00
Antonio Alvarez Feijoo b268a71069 man/varlinkctl: add list-methods command to synopsis and fix typo 
Follow-up for 16cfe84c24
 2024-06-28 15:14:59 +02:00
Antonio Alvarez Feijoo b3244d2b0a conf-parser: print why config_parse_iec_uint64() fails 
Print the same output as `config_parse_iec_size()` and
`config_parse_si_uint64()` if `parse_size()` fails, not only the `rvalue`.
 2024-06-20 12:54:32 +02:00
Antonio Alvarez Feijoo 152f349385 conf-parser: set standard pointer alignment 2024-06-20 12:53:08 +02:00
Antonio Alvarez Feijoo 111f988992 kernel-install: correct the place where it works in man and help text 2024-06-20 03:01:22 +09:00
Antonio Alvarez Feijoo fdd4263cac udev-spawn: fix typo and simplify code 
Follow-up for 11706971e8
 2024-06-19 19:36:53 +09:00
Antonio Alvarez Feijoo a81f5ffd40 repart: fix memory leak 2024-06-18 15:47:12 +01:00
Antonio Alvarez Feijoo 064d87e81f test-ip-protocol-list: include missing_network.h instead of netinet/in.h 
This fixes the build for glibc < 2.32

Follow-up for 3f69070598
 2024-06-12 14:02:46 +01:00
Antonio Alvarez Feijoo fb17510ede importctl: fix flag checking against wrong variable 
Fixes 67c7ee11af
 2024-05-02 13:58:20 +02:00
Antonio Alvarez Feijoo 1434754430 network-generator: add missing return on error after the logging refactor 
Fixes 3cb618084a
 2024-04-30 18:09:37 +02:00
Antonio Alvarez Feijoo c355b6af19 boot: fix argument name mismatch in two functions 2024-04-29 14:34:37 +02:00
Antonio Alvarez Feijoo 509871e6d5 NEWS: fix minimum dracut version required for systemd v256 
Follow-up for d4e9be97a3
 2024-04-29 11:19:31 +02:00
Antonio Alvarez Feijoo 5cef6b5393 cryptsetup-tokens: fix pin asserts 
If a user only presses ENTER when the PIN is requested (without actually typing
the PIN), an assertion is reached and no other unlock method is requested.

```
sh-5.2# systemctl status systemd-cryptsetup@cr_root
× systemd-cryptsetup@cr_root.service - Cryptography Setup for cr_root
     Loaded: loaded (/etc/crypttab; generated)
    Drop-In: /etc/systemd/system/systemd-cryptsetup@.service.d
             └─pcr-signature.conf
     Active: failed (Result: core-dump) since Thu 2024-04-25 08:44:30 UTC; 10min ago
       Docs: man:crypttab(5)
             man:systemd-cryptsetup-generator(8)
             man:systemd-cryptsetup@.service(8)
    Process: 559 ExecStartPre=/usr/bin/pcr-signature.sh (code=exited, status=0/SUCCESS)
    Process: 604 ExecStart=/usr/bin/systemd-cryptsetup attach cr_root /dev/disk/by-uuid/a8cbd937-6975-4e61-9120-ce5c03138700 none x-initrd.attach,tpm2-device=auto (code=dumped, signal=ABRT)
   Main PID: 604 (code=dumped, signal=ABRT)
        CPU: 19ms

Apr 25 08:44:29 localhost systemd[1]: Starting Cryptography Setup for cr_root...
Apr 25 08:44:30 localhost systemd-cryptsetup[604]: Assertion '!pin || pin_size > 0' failed at src/cryptsetup/cryptsetup-tokens/cryptsetup-token-systemd-tpm2.c:60, function cryptsetup_token_open_pin(). Aborting.
Apr 25 08:44:30 localhost systemd[1]: systemd-cryptsetup@cr_root.service: Main process exited, code=dumped, status=6/ABRT
Apr 25 08:44:30 localhost systemd[1]: systemd-cryptsetup@cr_root.service: Failed with result 'core-dump'.
Apr 25 08:44:30 localhost systemd[1]: Failed to start Cryptography Setup for cr_root.
```

In this case, `cryptsetup_token_open_pin()` receives an empty (non-NULL) `pin`
with `pin_size` equals to 0.

```
🔐 Please enter LUKS2 token PIN:

Breakpoint 3, cryptsetup_token_open_pin (cd=0x5555555744c0, token=0, pin=0x5555555b3cc0 "", pin_size=0, ret_password=0x7fffffffd380,
    ret_password_len=0x7fffffffd378, usrptr=0x0) at ../src/cryptsetup/cryptsetup-tokens/cryptsetup-token-systemd-tpm2.c:42
42	                void *usrptr /* plugin defined parameter passed to crypt_activate_by_token*() API */) {
(gdb) continue
Assertion '!pin || pin_size > 0' failed at src/cryptsetup/cryptsetup-tokens/cryptsetup-token-systemd-tpm2.c:60, function cryptsetup_token_open_pin(). Aborting.
```
 2024-04-25 17:07:11 +02:00
Antonio Alvarez Feijoo 8ebfef5c96 sysext: do not return 0 if unmerge() fails in the refresh() function. 
Actually, return the result of `unmerge()` if it is called in the `refresh()`
function.

Fixes 8662fcbcf1
 2024-04-23 16:15:55 +02:00
Antonio Alvarez Feijoo cc51dbe999 cpio: fix assert 2024-04-19 20:38:44 +02:00
Antonio Alvarez Feijoo 2f49ed9a01 stub: get uname from image before loading addons 
Otherwise uname is always NULL before calling `load_addons()`, so it's not being
checked if .uname matches between addons and UKI.

Fixes 68f85761e2
 2024-04-19 20:37:39 +02:00
Antonio Alvarez Feijoo d72835f819 man/systemd-stub: fix typo 2024-04-18 18:10:50 +02:00
Antonio Alvarez Feijoo e2fe5c4b98 boot: fix assignment of ret_* variables in initrd_prepare() 2024-04-18 14:13:38 +02:00