basic: validate timezones in get_timezones()

Depending on the packaging of tzdata, /usr/share/zoneinfo/tzdata.zi may
reference zones or links that are not actually present on the system.
E.g. on Debian and Ubuntu, there is a tzdata-legacy package that
contains "legacy" zones and links, but they are still referenced in
/usr/share/zoneinfo/tzdata.zi shipped by the main tzdata package.

Right now, get_timezoes() does not validate timezones when building the
list, which makes the following possible:

 $ timedatectl list-timezones | grep "US/Alaska"
 US/Alaska

 $ timedatectl set-timezone US/Alaska
 Failed to set time zone: Invalid or not installed time zone 'US/Alaska'

which feels buggy. Hence, simply validate timezones in get_timezones()
to avoid listing timezones that are not installed.
This commit is contained in:
Nick Rosbrook
2025-09-18 21:33:24 +02:00
committed by Lennart Poettering
parent 818bd1dfa1
commit 9fe168a92c
+8
View File
@@ -1435,6 +1435,10 @@ static int get_timezones_from_zone1970_tab(char ***ret) {
if (*cc == '#')
continue;
if (!timezone_is_valid(tz, LOG_DEBUG))
/* Don't list unusable timezones. */
continue;
r = strv_extend(&zones, tz);
if (r < 0)
return r;
@@ -1487,6 +1491,10 @@ static int get_timezones_from_tzdata_zi(char ***ret) {
/* Not a line we care about. */
continue;
if (!timezone_is_valid(tz, LOG_DEBUG))
/* Don't list unusable timezones. */
continue;
r = strv_extend(&zones, tz);
if (r < 0)
return r;