Commit Graph
100 Commits
Author SHA1 Message Date
Guido Günther 66bcb31a0e fbd-event: Add sender property
This allows us to store the DBus sender
2021-04-22 14:43:30 +02:00
Guido Günther abab07a2f2 event: Remove 'g' prefix from common C types
This matchs phosh's style.
2021-04-22 14:43:30 +02:00
Guido Günther 0936b5fb09 tests: Run event tests too 2021-04-22 14:43:30 +02:00
Guido Günther da537aff1e event: Make log-domain match source file name 2021-04-22 14:43:30 +02:00
Guido Günther 53a02c719c test-lfb-integration: Test invocation error 2021-02-05 16:56:24 +01:00
Guido Günther d6e3df7ebc tests: Run lfb_event_{get,set}_timeout 2021-02-05 16:56:24 +01:00
Guido Günther 8c8382a0d2 lfb-event: Don't leak error
Don't leak the error values in the success case
2021-02-05 16:56:24 +01:00
Guido Günther 0a5dac1e53 fbd-dev-sound: Don't warn when sound was cancelled
This is not an error per se.
2021-02-05 16:56:24 +01:00
Guido Günther c95009afd1 fbd-dev-sound: Don't leak GError 2021-02-05 16:56:23 +01:00
Guido Günther aac3306ad5 Document changes and release 0.0.0+git20210125 2021-01-25 11:00:38 +01:00
Guido Günther 40d318c9aa feedback-manager: Fix formatting
It was off in several places. Now that there's no outstanding
MRs clean it up via

   uncrustify --replace -c phosh.cfg src/fbd-feedback-manager.c
2021-01-11 10:35:03 +01:00
Guido Günther ce02a0a52d Document changes and release 0.0.0+git20201114 2020-11-14 15:55:30 +01:00
Guido Günther 3b3deddb54 debian: Don't abuse the video group
Use a separate group for users that should be able to access
the LED devices.
2020-11-14 15:39:27 +01:00
Guido Günther 5ca5d50027 udev: Update led maching for the librem5
The names changed in device tree which tickles up into userspace.
2020-11-14 15:33:27 +01:00
Guido Günther 581b83cd92 gitlab-ci: Honor PKG_ONLY
This allow us to get debs quicker
2020-09-30 19:16:37 +02:00
Guido Günther 99e39fba00 sound: Set 'event' media role
This allows pa to cork, duck, etc.
2020-09-30 19:16:25 +02:00
Guido Günther 9e2c13a1fe Document changes and release 0.0.0+git20200726 2020-07-26 13:06:35 +02:00
Guido Günther 5a75f369fc fbd: Dispose manager at the very end 2020-07-24 14:45:46 +02:00
Guido Günther 665d2abc4a feedback-led: Don't try to stop led when there's no led device
This is not a critical since we prevented submitting initially
but daemon cleanup processes all entries in the theme.
2020-07-24 12:53:13 +02:00
Guido Günther d137c5895f feedback-led: Stop the correct led color 2020-07-24 12:53:13 +02:00
Guido Günther 8a631cae3e feedback-manager: Dispose leds too 2020-07-24 12:53:13 +02:00
Guido Günther e7f527bf62 feedback-manager: Don't forget to remove not found events from the hash table
This plugs a leak.
2020-07-24 12:53:13 +02:00
Guido Günther cf56999bf7 feedback-manager: Deeply free the feedback list
Instead of freeing each elemnt after each iteration and then the list
itself at the very end just fully free the list. g_autoslist does
not work well on oder glib so do that manually.

This is just cosmetics.
2020-07-24 12:53:13 +02:00
Guido Günther fb076254c9 tests: Test event not found case too 2020-07-24 11:58:26 +02:00
Guido Günther cfab476edb tests: Don't check end reason in feedback handler
This allows to reuse the feedback handler and we check the
reason in the actual test function anyway.
2020-07-24 11:58:26 +02:00
Guido Günther e8d189ebe6 feedback-theme: Avoid warning when feedback is not found
We tell the caller so debug level is enough
2020-07-24 11:58:26 +02:00
Guido Günther 05a6bd5947 feedback-sound: Implement is_available
This avoids criticals when there's sound device available. We
can also be more precise about the reason why feedback ended.
2020-07-22 10:28:42 +00:00
Guido Günther 67ebeba2b2 feedback-vibra-periodic: Implement is_available
This avoids criticals when there's no periodic vibra available.
2020-07-22 10:28:42 +00:00
Guido Günther 1af163e7ea feedback-vibra-rumble: Implement is_available
This avoids criticals when there's no rumble vibra available.
2020-07-22 10:28:42 +00:00
Guido Günther 75e28510e4 fbd-feedback-led: Implement is_available ()
This avoids criticals when there's no Leds available.
2020-07-22 10:28:42 +00:00
Guido Günther e8dfe6974a fbd-feedback-manager: Check if feedback is usable
If we don't find any usable feedbacks for an event return
FBD_EVENT_END_REASON_NOT_FOUND.
2020-07-22 10:28:42 +00:00
Guido Günther 542fe52cc2 feedback-manager: Fix indentation 2020-07-22 10:28:42 +00:00
Guido Günther 94ef60f73e fbd-feedback-base: Add fbd_feedback_is_available ()
This allows to check if a feedback type is available
at all.
2020-07-22 10:28:42 +00:00
Guido Günther f950cfc3a2 fbd-dev-sound: Be less verbose on missing sound files
This is quite common so don't fill the logs at normal debug levels
but be more specific about what is missing.
2020-07-20 16:19:17 +02:00
Guido Günther 7d22b36208 Document changes and release 0.0.0+git20200714 2020-07-14 10:31:46 +02:00
Guido Günther 3a378552af tests: Use async feedback as the test name implies 2020-07-13 16:06:44 +02:00
Guido Günther 134d60c73b tests: Don't quiet mainloop on event end
This is needed to properly test aync where we have the
finished async event handler and the signal.
2020-07-13 10:16:20 +02:00
Guido Günther 6e30957714 lfb-event: Connect done handler in async case too
Otherwise the event state is not updated properly
2020-07-13 10:16:20 +02:00
Guido Günther bb561b0dc5 lfb-event: Clarify return values of finished functions
They just inidicate that we talked to feedbackd succesfully.
2020-07-13 10:16:20 +02:00
Guido Günther 68a1e3cda0 Document changes and release 0.0.0+git20200707 2020-07-10 11:54:52 +02:00
Guido Günther 918a047ce0 debian: Bump symbol versions
This ensures we get tighter dependencies when built against
this version with new symbols.

We don't bother with individual symbols yet.
2020-07-10 09:20:04 +00:00
Guido Günther 41304c36fd cli: Allow to set profile per event
We allowed set the global profile via `-P` use it as per event
profile when used with `-E`.

Ironically the manpage always said it'd be that way.
2020-07-10 09:20:04 +00:00
Guido Günther dfafe8d7c1 cli: Fix indentation 2020-07-10 09:20:04 +00:00
Guido Günther 50aeb79ec9 LfbEvent: Add feedback-profile property
This allows to specify the feedback profile to use for
this particular event.
2020-07-10 09:20:04 +00:00
Guido Günther 6692d8922b feedback-manager: Add hint to select feedback profile per event
This e.g. allows events that are meant for haptic only to avoid
emitting a sound by omitting the 'full' level and using "quiet"
instead.

Closes: #7
2020-07-10 09:20:04 +00:00
Guido Günther 421c163bdd feedback-manager: Prepare for per event hints
Move feedback profile level into a separate function for that.
2020-07-10 09:20:04 +00:00
Guido Günther 9c667bbc6c LfbEvent: Link to event naming specification 2020-07-10 09:20:04 +00:00
Guido Günther 69cbe39082 README: We set a feedback profile not a level 2020-07-10 09:20:04 +00:00
Guido Günther 76da62738c Revert "rumble: Use a default pause"
This reverts commit 551030b436.
2020-07-10 11:17:18 +02:00
Guido Günther 551030b436 rumble: Use a default pause
Without that multiple counts sound odd so let's have good defaults.
2020-07-09 12:53:15 +00:00
Guido Günther 200ec77362 Add generic missed notification
This can be used e.g. by the shell for general purpose notifictions
but also for in app notifications of the foreground app.
2020-07-05 19:25:44 +00:00
Guido Günther 75f6888334 data: Use LED feedback for missed calls, IMs and SMS 2020-07-05 19:25:44 +00:00
Guido Günther a5b4f99412 feedbackd: Support visual feedback via LEDs
Currently all LED feedbacks are infinite we can improve that
later on by using the 'repeat' attribute of the LED pattern
trigger.
2020-07-05 19:25:44 +00:00
Guido Günther 2f083ea5ae debian: Setup leds via udev
This allows feedbackd to set periodic feedback and makes usable
LED devices identifiable by feedbackd.
2020-07-05 19:25:44 +00:00
Guido Günther b561114800 feedbackd: Add helper to set up permissions for LEDs
This helper knows about the tiggers and necessary permission.
It's intended to be run via udev.
2020-07-05 19:25:44 +00:00
Guido Günther 20ba06a193 data: Drop phone-missed-call in 'quite' profile
Only want LEDs there.
2020-07-05 19:25:44 +00:00
Guido Günther 5efac28da9 debian: Ship manpages 2020-07-04 11:30:47 +00:00
Guido Günther d780dd4f57 docs: Add feedbackd manpage
Closes: #12
2020-07-04 11:30:46 +00:00
Guido Günther afcb57ab90 doc: Add fbcli manpage 2020-07-04 11:30:46 +00:00
Guido Günther e4c793f6b2 README: Fix spelling
It's `from` not `form`.
2020-06-25 08:36:06 +02:00
Guido Günther f5f6308fc4 README: Fix command line tool name
It's called fbcli (but was called fbdcli initially)
2020-06-25 08:22:38 +02:00
Guido Günther 58c370407f fbcli: Quit main loop on CTRL-C / SIGTERM
This makes sure we invoke the cleanup function correctly and allows
to test running event handling.
2020-06-02 16:36:24 +00:00
Guido Günther 49dab605c2 libfeedback: Cancel all running feedbacks on uninit
We keep track of the active ids and end them on uninit. This
make sure feedbacks don't continue to run if the application quits
and forgets to end a feedback.
2020-06-02 16:36:24 +00:00
Guido Günther ceef33c6a0 libfeedback: Unset _initted early
This make sure a client does not end up in our shutdown phase and sees a
half initted library.
2020-06-02 16:36:24 +00:00
Guido Günther 1af281d8e2 data: Clarify DBus wording 2020-06-02 16:36:24 +00:00
Guido Günther bdf251e565 feedback-manager: Only act on add
We would otherwise ignore the action when no vibra device was yet found.
Make sure we release the old device when updating.
2020-06-02 16:36:24 +00:00
Guido Günther 5d947f51b1 feedback-manager: Fix indentation and typo 2020-06-02 16:36:24 +00:00
Guido Günther 784152ba67 feedback-manager: Drop superfluous g_clear_error
The error is a g_autoptr
2020-06-02 16:36:24 +00:00
Guido Günther 81fda3134b feedback-vibra: Make doc strings match the class name 2020-06-02 16:36:24 +00:00
Guido Günther 35f35b8bb4 feedback-profile: Fix docstring 2020-06-02 16:36:24 +00:00
Guido Günther 6c0ac9ad6c feedback-sound: Plug a leak
We did not free the effect name
2020-06-02 16:36:24 +00:00
Guido Günther f51721b77a lfb-event: Fix comment 2020-06-02 16:36:24 +00:00
Guido Günther 7bd82a59aa Document changes and release 0.0.0+git20200527 2020-05-27 10:00:50 +02:00
Guido Günther 00c363293a Honor sound theme on GNOME
We don't set this for other DEs since they might want to pick
a good default from elsewhere.
2020-05-26 18:39:58 +02:00
Guido Günther fd5e63c0a0 Document changes and release 0.0.0+git20200420 2020-04-20 12:20:08 +02:00
Guido Günther 10b1c90d57 data: Lower rumble time for window-close and button press
It's too intrusive otherwise
2020-04-20 11:31:14 +02:00
Guido Günther 20dc8bd156 debian: Ensure smooth upgrades after package rename 2020-04-20 09:55:14 +02:00
Guido Günther 9cb62dee1d Allow to lower the feedback level per application
We munge the application id the same way as it's done
for notifications so these can eventually move into
the same schema.
2020-04-20 07:23:44 +00:00
Guido Günther eec1556d87 data: Add schema for per app settings 2020-04-20 07:23:44 +00:00
Guido Günther 49e5656ac1 theme: Add feedbacks for window-close and button-press 2020-04-20 07:23:44 +00:00
Guido Günther 4d484c9cc9 theme: order feedbacks alphabetically
We don't have better ordering but this makes is simple
to check if a feedback is present in a certain level.
2020-04-20 07:23:44 +00:00
Guido Günther e40fe3c343 debian: Add symbols file
This will allow dpkg-buildpackage to generate proper depends
2020-04-17 11:53:10 +02:00
Guido Günther 89edad123d Add symbols file 2020-04-17 11:45:02 +02:00
Guido Günther 351f56b1ad Document changes and release 0.0.0+git20200305 2020-03-23 10:21:20 +01:00
Guido Günther de3665975c feedbackd-common: Add proper Breaks/Replaces
This handles partial upgrades with newer schema but old feebackd.
2020-03-23 10:20:07 +01:00
Guido Günther d80b97ae9b Document changes and release 0.0.0+git20200304 2020-03-04 16:48:30 +01:00
Guido Günther dcae16429f Update .gitignore 2020-03-04 16:48:30 +01:00
Guido Günther 6723944782 debian: Split out shared files
This allows other programs (like gnome-control-center) to consume the
settings schema without having to depend on the daemon itself.
2020-03-04 15:28:27 +00:00
Guido Günther c5130abdac Fix typos 2020-03-04 15:28:27 +00:00
Guido Günther 524ed476a2 Expand examples
Closes: #4
2020-02-25 18:37:23 +01:00
Guido Günther a2e86bd277 docs: Move descriptive text to overview.xml
Our short intro paragraph did not get rendered otherwise.
2020-02-25 18:37:23 +01:00
Guido Günther 96dd2abef2 lfb-event: Fix property names in doc strings
This makes them render correctly in the generated docs.
2020-02-25 18:35:16 +01:00
Guido Günther e3e9ba89fc lfb-event: Document constructor
Closes: #8
2020-02-25 18:35:16 +01:00
Guido Günther c54ff7fcb9 theme: Add timeout-completed event 2020-02-25 14:05:38 +00:00
Guido Günther 0be818a1e1 theme: Fix typo 2020-02-25 14:05:38 +00:00
Guido Günther a2d3e82cf1 gitignore: Ignore more files from debian packing
The current pattern was too strict to match all the files
generated during the Debian package build.
2020-02-25 13:11:09 +00:00
Guido Günther 7abeaf8816 debian: use proper test name 2020-02-25 13:11:09 +00:00
Guido Günther e4af4eb9f7 Fix typos 2020-02-25 13:11:09 +00:00
Guido Günther 38b0fa8df5 build: Don't add lfb-enums.c to list of generated sources
Otherwise when used as a subproject the master project will try
to rebuild with it's own set of flags. These lack
LIBFEEDBACK_COMPILATION which does not end well.
2020-02-25 12:46:40 +00:00
Guido Günther 41eda0ea49 libfeedback: Drop trailing semicolon
Trips up some compilers.

Thanks: Andrea Schaefer
2020-02-21 12:44:13 +01:00