Commit Graph
427 Commits
Author SHA1 Message Date
Guido Günther 3c02259156 event: Allow to end events by level
The level here is an abstract value but in fact matches the profile
level. Well make this a property when fixing #35.
2024-06-21 19:57:29 +00:00
Guido Günther 0a16ebe4af event: Make removing feedbacks more self contained
If the feedback is in our list of feedbacks disconnect signals
and drop the reference we hold.

As we have removed the signal handler that would invoke `check_ended()`
we invoke this manually when the list becomes empty.
2024-06-21 19:57:29 +00:00
Guido Günther e7c370a589 tests/fbd-event: Check if objects are finalized
This gives us more info than just using automatic cleanup
2024-06-21 19:57:29 +00:00
Guido Günther 924320bbf9 fbd-event: Fix some indent
Gbp-Dch: Ignore
2024-06-21 19:57:29 +00:00
Guido Günther 2b6a9508a0 feedback-theme: Fix indent
Gbp-Dch: Ignore
2024-06-21 19:57:29 +00:00
Guido Günther 6cc47e3121 Merge branch 'no-fb' into 'main'
cli: Inform user when no feedback was found

Closes #76

See merge request Librem5/feedbackd!130
2024-06-21 09:39:21 +00:00
Guido Günther 212682fb0f cli: Inform user when no feedback was found
This might either be because the event doesn't exist or when the profile
doesn't have any feedback on the current level.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/76
2024-06-21 09:25:55 +00:00
Guido Günther e2c9b530b9 cli: Reindent
Gbp-Dch: Ignore
2024-06-21 09:25:55 +00:00
Guido Günther 6b3c43e25c Merge branch 'shared-gmobile' into 'main'
packaging: Build-depend on shared gmobile

See merge request Librem5/feedbackd!132
2024-06-21 08:41:40 +00:00
Guido Günther 62c92b0b09 packaging: Build-depend on shared gmobile
This ensures we don't use the subproject in packaging builds
2024-06-21 08:05:51 +00:00
Guido Günther 946611ea84 Merge branch 'rules-requires-root' into 'main'
packaging: Don't require root for building

See merge request Librem5/feedbackd!131
2024-06-21 07:51:30 +00:00
Guido Günther bdcbb08cd8 packaging: Don't require root for building
This helps the nightly builds
2024-06-21 09:50:37 +02:00
Guido Günther 6aeeef150e Merge branch 'flash' into 'main'
led: Allow to use camera flash as status LED

See merge request Librem5/feedbackd!129
2024-06-21 07:29:32 +00:00
Guido Günther 6622444c78 udev: Allow to use flash devices 2024-06-15 11:14:40 +02:00
Guido Günther 8f67dbd120 feedback-led: Allow to prefer flash LEDs over notification LEDs 2024-06-15 11:14:40 +02:00
Guido Günther ffd939c536 leds: Probe flash LED 2024-06-15 11:14:40 +02:00
Guido Günther e47ce8e09e led: Add flash LED type
Camera flashes are also exported via the LED subsystem. We use a
separate LED type so they're not picked by default.

We don't use them as fallbacks either.
2024-06-15 11:14:40 +02:00
Guido Günther e16dc3cdab feedback-led: Check if at least one LED is available
So far we didn't create any FbdDevLeds if there wasn't at least one
usable LED. Once we introduce flash LEDs we might probe the LED but the
LED might not be usable as the user hasn't enabled using it. Prepare for
that scenario.
2024-06-15 11:14:40 +02:00
Guido Günther 417b34be89 led: Drop FBD_FEEDBACK_LED_COLOR_LAST
With new led types we might not loop over all of them. This makes
it a bit more obvious.
2024-06-15 11:14:40 +02:00
Guido Günther a71fd7d470 manager: Move schema name to header
This makes it available to other compilation units
2024-06-15 11:14:40 +02:00
Guido Günther 2614b6ee41 Merge branch 'rgb-color' into 'main'
Allow to set RGB colors

See merge request Librem5/feedbackd!126
2024-06-15 09:12:36 +00:00
Guido Günther afdeb8d56f theme: Use different colors for emails and calls
This makes them a bit simpler to distinguish
2024-06-13 15:19:08 +02:00
Guido Günther a4c35a8e61 led: Parse color values and pass them down the chain
We parse RGB color values as HEX ('#RRGGBB') and use those when a RGB
LED is available. Single color LEDs won't see a change.
2024-06-13 15:19:03 +02:00
Guido Günther efd088daa8 feedback-led: Document hw LED types 2024-06-13 15:17:52 +02:00
Guido Günther 4afc8398e2 feedbackd: Pass GMOBILE_USE_UNSTABLE_API to all files
No need to ack that individually
2024-06-13 15:17:52 +02:00
Guido Günther 5bd398ed18 feedback-led: Support colors as strings
The FbdDevLedColor enum defines the hardware color of the LED. We used
it for the feedbacks color value as long as the kernel mostly had
single color LEDs. As multicolor LEDs are common nowadays switch the
color to a string which will allow us to use RGB values later on.
2024-06-13 15:17:51 +02:00
Guido Günther 4551b1c939 fbd-feedback-led: Modernize property definitions
Adapt current phosh coding style before making other changes
2024-06-13 07:44:42 +02:00
Guido Günther 8d4c2590cb doc: Fix URLs
Don't use Markdown markup as it looks odd in the generated page.
2024-06-13 07:44:39 +02:00
Guido Günther 17d910651d doc: Document feedback types
This allows us to remove the list from the README
2024-06-13 07:44:36 +02:00
Guido Günther 6e9e5700c0 dev-led-multicolor: Use correct format specifier
The values are unsigned int
2024-06-13 07:44:34 +02:00
Guido Günther 9aa6696eb8 build: Let daemon dependency depend on generated enum headers
Otherwise it might not be available in the tests
2024-06-13 07:44:25 +02:00
Guido Günther a0a0c46a26 Merge branch 'ci' into 'main'
Use shared ci from meta-phosh

See merge request Librem5/feedbackd!127
2024-06-13 05:34:39 +00:00
Guido Günther 1c51eb20ec ci: Use common jobs from meta-phosh 2024-06-12 16:24:33 +02:00
Guido Günther e9743f3daa ci: Update common files from meta-phosh
This updates to commit f3c92e90dcc0d65322888217429b75dd101bd0d3
2024-06-12 16:24:33 +02:00
Guido Günther c3b4877dfe Merge branch 'qcom-lpg' into 'main'
led-qcom: Check for LED driver

Closes #77

See merge request Librem5/feedbackd!124
2024-06-11 07:48:49 +00:00
Guido Günther 3c588fdb8f led-qcom: Check for LED driver
The hw_pattern attribute is driver specific. Ensure we don't apply the
LED pattern to unknown drivers.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/77
2024-06-10 15:50:50 +02:00
Guido Günther f581c15842 led-qcom-multicolor: Don't leak qcom_led 2024-06-10 10:33:05 +02:00
Guido Günther 255856822a led-qcom-multicolor: Drop unused defines 2024-06-10 10:33:03 +02:00
Guido Günther fcd210ef22 led-qcom: Use char instead of gchar
We prefer the C types in new code.
2024-06-10 10:33:03 +02:00
Guido Günther 12be49b9fc Merge branch 'qcom-lpg-hwpattern' into 'main'
fb-dev-leds: support hw_pattern for Qualcomm LPG

See merge request Librem5/feedbackd!100
2024-06-09 09:45:20 +00:00
Dylan Van Assche 6b1eb92b7a fbd-dev-leds: Probe QCOM HW LED types
Try first the QCOM hardware LED types which require the most features of
LED drivers. Try until we have a single color GPIO LED which is the
minimal LED driver support we require. If the LED does not meet that
expectation either, we ignore the LED.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 2b53725fcb fbd-dev-led-qcom-multicolor: Support QCOM LPG LED multicolor
QCOM LPG LEDs can also operate in a multicolor fashion.
Re-use the probing sequence of multicolor LEDs and the hw_pattern
configuration of single color QCOM LPG LEDs.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 10e6d3cba8 fbd-dev-led-qcom: Support QCOM LPG LED single color
QCOM LPG LEDs expose a hw_pattern sysfs entry which accepts a limited
set of patterns but allows to use dedicated hardware for blinking the
LED. This way, battery life can be improved and the LED still blinks,
even if the device is suspended.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 22e4c33606 fbd-dev-led-multicolor: Support red, green, blue and white LED colors
Provide our own supports_color method to specify which colors are
actually implemented by the driver. RGB LEDs could provide different
colors as well such as orange, purple, etc. but those are not supported
yet.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 60ce9ecb3c fbd-dev-led: Check max_brightness_percentage range
Percentages are always between 0.0 and 100.0.
Also fix a typo along the way.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 63b564494b fbd-ledctrl: Set permissions for hw_pattern
Allow access to hw_pattern sysfs node for feedbackd, similar to other nodes.
2024-06-09 11:21:20 +02:00
Dylan Van Assche e43126b007 fbd-dev-led: Rework color API
Drop has_color API since supported colors are set during probing
and can be handled completely separately from the classes for
each type of hardware.

Rename set_color to set_supported_color because the usage
of this API is to check if the color is supported, but not
setting it. Setting the color is also separated from
start_periodic API to re-use multicolor across multiple LED types
with a set_color API. Multicolor LEDs are actually the same as
regular LEDs but they require a few additional sysfs entries to
actually set the color. Single color LEDs only have a single color
so the set_color method just returns TRUE for these LEDs.

Supported colors are advertised through the supports_color API now.
This way, each LED driver define which colors are supported
through supports_color API. RGB multicolor LEDs will report only fixed colors
like red, blue, green and white until the kernel can expose if a diffusor
is present to mix these colors.
2024-06-09 11:21:19 +02:00
Dylan Van Assche bcd37b0aa5 fbd-dev-led-*: Adjust to method convention
fbd_dev_led_ is the convention for methods, adjust them all.
2024-06-09 11:18:09 +02:00
Dylan Van Assche 94afe719a9 fbd-dev-led: Scan for RGB color as well
Multicolor LEDs have the color 'rgb', we should also scan it
as they are also a FbdDevLed.
2024-06-07 10:15:39 +02:00
Dylan Van Assche 7f69813e84 fbd-dev-led-multicolor: Fix typo in error message
multicololo -> multicolor LED
2024-06-07 10:15:30 +02:00