Commit Graph
590 Commits
Author SHA1 Message Date
Guido Günther 32cf0758d2 vibra: Some style and comment fixes
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-05-09 19:37:41 +00:00
Guido Günther 5cbd5a2893 Merge branch 'led-prio' into 'main'
dev-led: Sort leds by priority

See merge request agx/feedbackd!173
2025-05-06 15:03:42 +00:00
Guido Günther f9f248ef23 fbd-dev-led: Sort leds by priority
This makes sure we e.g. prefer multicolor leds over single color ones
and those that can be on insuspend (qcom) over those that can't.

We can extend this to allow to set the priority via udev/hwdb in the
future.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-05-06 14:54:52 +00:00
Guido Günther 651c4f9fac fbd-dev-led: Ignore leds that can't handle patterns
While in theory we could have themes with only freq = 0 values we
currently assume there can be patterns.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-05-06 14:54:52 +00:00
Guido Günther a2cbcc624f Merge branch 'media-roles' into 'main'
sound: Allow to set media roles

See merge request agx/feedbackd!174
2025-04-30 08:56:30 +00:00
Guido Günther 1e057eaa0c doc: Document media-role property
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-30 10:52:57 +02:00
Guido Günther e23c3401f9 fbd-dev-sound: Set special media role when present
We default to "event".

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-30 10:52:57 +02:00
Guido Günther 9054862071 feedback-sound: Allow to set media role
This will allow us to specify the role when playing the sound.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-30 10:52:57 +02:00
Guido Günther 0f031521e7 feedback-sound: Modernize prop definitions
Gbp-Dch: Ignore
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-30 10:52:57 +02:00
Guido Günther aa23c8f91d tests: Test sound feedback
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-30 10:52:57 +02:00
Guido Günther a5c7adbf1b Merge branch 'rgb-multicolor' into 'main'
fbd-dev-led-multicolor: Ignore LEDs that don't have three values

See merge request agx/feedbackd!176
2025-04-30 08:52:36 +00:00
Guido Günther bbd45b7f6a examples: Add example udev rule for Framework 13 Laptop
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-30 08:50:14 +00:00
Guido Günther a3fdc4852b fbd-dev-led-multicolor: Ignore LEDs that don't have three values
We assume that multicolor LEDs are RGB so reject those that don't
have three components.

E.g. the Framework Laptop exposes a power button LED as multicolor
that only has a white component. This way it gets treated as single color LED.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-30 08:50:14 +00:00
Guido Günther 3cb34ce43f Merge branch 'breaks' into 'main'
packaging: Fix inverted Breaks

See merge request agx/feedbackd!175
2025-04-30 07:59:15 +00:00
Guido Günther f931b19756 packaging: Fix inverted Breaks
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-27 12:48:36 +02:00
Guido Günther 19e0084133 Merge branch 'doc-updates' into 'main'
doc updates

Closes #89

See merge request agx/feedbackd!172
2025-04-24 14:32:27 +00:00
Guido Günther 84b783cbf7 doc: Clarify theme use
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-24 12:57:24 +02:00
Guido Günther eb2cb76635 doc: Fix parent-name reference
Closes: https://gitlab.freedesktop.org/agx/feedbackd/-/issues/89

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-24 12:57:24 +02:00
Guido Günther a646a34741 doc: Reference manpage
Refer to manpage rather than to the classes in the source code.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-24 12:57:24 +02:00
Guido Günther 155814035d doc: Document Sound properties
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-24 12:57:24 +02:00
Guido Günther 78d82207e5 doc: Document missing VibraRumble properties
Fixes f089ad2 ("vibra-rumble: Add magnitude property")

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-24 12:57:24 +02:00
Guido Günther 047f83c6b3 doc: Fix typo
Gbp-Dch: Ignore
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-24 12:57:24 +02:00
Guido Günther 673d372aa0 Merge branch 'ci-fairy' into 'main'
ci: Add ci-fairy check

See merge request agx/feedbackd!171
2025-04-23 20:25:51 +00:00
Guido Günther 69a5174f5f ci: Add ci-fairy check
This makes sure we have Signed-off-by:

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-23 22:22:02 +02:00
Guido Günther 44e57d78b7 Merge branch 'main' into 'main'
Allow constant lighting of notification LED through the setting of frequency in theme.json to zero.

See merge request agx/feedbackd!169
2025-04-23 20:02:12 +00:00
knoppix knoppix 0e88863a3d Allow constant lighting of notification LED through the setting of frequency in theme.json to zero. 2025-04-23 20:02:12 +00:00
Guido Günther b181c942ad Merge branch 'repo-url' into 'main'
treewide: Update repo URLs

See merge request agx/feedbackd!168
2025-04-21 12:44:02 +00:00
Guido Günther b62ce975f3 README: Add CoC
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-20 22:59:13 +02:00
Guido Günther 01d909d4f3 treewide: Update repo URLs
We leave changelog and NEWS untouched as they track history.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-20 22:37:25 +02:00
Guido Günther eab27ae67a Merge branch 'ci' into 'main'
ci: Update for fdo

See merge request agx/feedbackd!167
2025-04-20 20:01:01 +00:00
Guido Günther a78941f1d8 ci: Allow coverage collection to fail
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-20 21:51:42 +02:00
Guido Günther 384ec20357 ci: Update for fdo
Drop the now unneeded tags and the arm64 build

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-04-20 21:46:53 +02:00
Guido Günther f14642cb04 Merge branch 'rel-0.8.1' into 'main'
treewide: Document changes and release 0.8.1

See merge request Librem5/feedbackd!165
2025-03-29 11:28:44 +00:00
Guido Günther 867771a25a treewide: Document changes and release 0.8.1
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-29 12:18:10 +01:00
Guido Günther 61e30a7444 packaging: Add Breaks on older device themes
This makes sure they don't throw any criticals

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-29 12:18:10 +01:00
Guido Günther cf6d048269 Merge branch 'safe-cleanup' into 'main'
libfeedback: Only cancel feedbacks if ever inited

See merge request Librem5/feedbackd!164
2025-03-29 09:06:55 +00:00
Guido Günther e8ecc3d0c1 libfeedback: Only cancel feedbacks if ever inited
If lfb_init() wasn't called before lfb_uninit() we'd otherwise raise a
critical which isn't nice for a library.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-25 21:55:34 +01:00
Guido Günther a0295286ff Merge branch 'rel-0.8.0' into 'main'
treewide: Document changes and release 0.8.0

See merge request Librem5/feedbackd!163
2025-03-21 18:59:36 +00:00
Guido Günther 98f2c6a01d treewide: Document changes and release 0.8.0 2025-03-21 19:20:56 +01:00
Guido Günther f2fde30f60 Merge branch 'periodic-magnitude' into 'main'
Use [0.0, 0.1] for periodic pattern too

Closes #86 and #84

See merge request Librem5/feedbackd!162
2025-03-21 18:15:30 +00:00
Guido Günther 3d062c0952 default/theme: Use [0.0, 1.0] for vibra-periodic
We switch `message-new-cellbroadcast` to VibraPeriodic as that is better
recognizable than the periodic pattern.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-21 12:15:57 +01:00
Guido Günther c37bfecbe0 vibra-periodic: Add a fallback for the previous [0, 0xFFFF] range
This keeps old themes working

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-21 12:15:57 +01:00
Guido Günther da93a16cda vibra-periodic: Deserialize magnitude and fade-in-level manually
This allows us to add proper fallbacks

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-21 12:15:56 +01:00
Guido Günther 91c34f4099 vibra-periodic: Use better defaults for fade-in-*
Lets start at zero when not specified otherwise and also set an
arbitrary fade-in-time as setting it to the duration isn't very helpful.

While at that move the defaults to the feedback rather than the device
so we ensure consistency over different device implementations.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-21 12:14:55 +01:00
Guido Günther 89b33dcbab vibra-periodic: Use same range as in rumble and periodic
We use [0.0, 1.0] in the other haptic feedbacks so let's make periodic
do the same.

We adjust dev-vibra to match that.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/86
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-21 12:14:55 +01:00
Guido Günther f94de01a85 vibra-periodic: Modernize doc comment and property definitions
Also untabify. No functional change.

Gpb-Dch: Ignore
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-21 12:14:55 +01:00
Guido Günther cf0a420c3f doc: Mention theme reload on SIGHUP
Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-21 12:14:55 +01:00
Guido Günther ac2f0d33c7 Merge branch 'magnitude-range' into 'main'
dev-vibra: Allow full magnitude in rumble

See merge request Librem5/feedbackd!161
2025-03-20 08:32:10 +00:00
Guido Günther 7b026b40cc dev-vibra: Allow full magnitude in rumble
Lets not artificially cap the magnitude in the device specific
implementation.

Since the default magnitude for the common rumble feedback was set to
0.5 in the previous commit the effective magnitude in existing themes
remains unchanged for that event.

The pattern feedbacks didn't make it into a release yet so there's
nothing that could get broken.

The change doubles the effective when using the Vibra DBus API but as it
seems that libmanette didn't land support yet lets just ignore that
here.

Periodic feedback is unaffected as it uses a different internal API.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-20 07:48:42 +00:00
Guido Günther f089ad2fd0 vibra-rumble: Add magnitude property
We add a magnitude property and set it to 0.5 by default. This ensure
the relative magnitude stays the same when switching from 0xFFFF to
0x7FFF in dev-vibra.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
2025-03-20 07:48:42 +00:00