Commit Graph
301 Commits
Author SHA1 Message Date
Guido Günther 1933a23172 tests: Don't leak profiles and test that
We finalize the theme first so the last reference is dropped when
finalizing the profiles.
2023-03-13 15:26:07 +01:00
Guido Günther 460985cfa0 tests: Don't leak json string 2023-03-13 15:26:04 +01:00
Guido Günther 03b0f4c2aa fbd-event: Make sure we iterate the list safely
When all feedbacks are done the event signals "feedbacks-ended" which
lets the manager dispose the feedback. When all feedbacks end instantly
and synchronously (as is the case with the dummy feedback) this triggers
the disposal of the event within the loop leading to a crash.

Make sure the object doesn't go away be referencing it during the loop
iteration.

We didn't see this before as glib's slice allocator for lists papered
over this for us.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/69
2023-03-13 15:25:41 +01:00
Guido Günther 64076e5ad0 fbd-event: Simplify
Gbp-Dch: Ignore
2023-03-13 15:25:37 +01:00
Guido Günther 847c21d78e build: Avoid meson deprecation warning 2023-03-13 15:25:31 +01:00
Guido Gunther 2db8a72ef9 Merge branch 'rel-0.1.0' into 'main'
Release 0.1.0

See merge request Librem5/feedbackd!108
2023-02-27 16:20:02 +00:00
Guido Günther f50db727a1 Document changes and release 0.1.0 2023-02-25 14:07:09 +01:00
Guido Günther b76e7f775f d/gbp.conf: Be less strict when matching the meson version field 2023-02-25 14:04:09 +01:00
Guido Gunther 397d508381 Merge branch 'led-class' into 'main'
leds: Separate single color from multicolor leds

See merge request Librem5/feedbackd!103
2023-02-10 15:26:25 +00:00
Guido Günther 995d21b587 fbd-dev-led: Move multicolor handling to separate class
Everything related to multicolor moves into the new class and we add the
necessary getters and setters so derived classes can access the parent
classes attributes where needed.
2023-02-10 15:15:12 +00:00
Guido Günther ca712e9a32 fbd-dev-led: Add class methods so derived classes can override functionality 2023-02-10 15:15:12 +00:00
Guido Günther ac0516329c fbd-dev-led: Use GInitable
Use default GObject patterns instead of stuffing things into the
fbd_dev_led_new () so derived classes can override it.
2023-02-10 15:15:12 +00:00
Guido Günther f7ec08497e fbd-dev-led: Turn into a GObject
This is just the minimal changes to switch to a derivable GObject
2023-02-10 15:15:12 +00:00
Guido Günther f17ca72c1b fbd-dev-led: Make structure opaque
This will allow us to turn it into a GObject
2023-02-10 15:15:12 +00:00
Guido Günther 5d8b2e5fe4 fbd-dev-led: Allow to lookup color
This allows us to make the led structure into an opaque in
the next commit
2023-02-10 15:15:12 +00:00
Guido Günther 8ad1c43ff1 fbd-dev-leds: Move pattern trigger into fbd-dev-led 2023-02-10 15:15:12 +00:00
Guido Günther fd852c6f69 fbd-dev-leds: Move led creation into fbd-dev-led
This will allow us to separate the different led types
2023-02-10 15:15:12 +00:00
Guido Günther 5fc0372b45 Move LED device to separate file
We separate out the led as different LED types have different
ways to set patterns, etc
2023-02-10 15:15:12 +00:00
Guido Günther 253d178cfc fbd-dev-leds: Use gi-docgen compatible format
We don't document the server classes via gi-docgen atm but
as we use it for the lib update classes we touch.
2023-02-10 15:15:12 +00:00
Guido Günther 1013974958 theme: Fix some indentation 2023-02-10 15:15:12 +00:00
Guido Gunther bc256284ee Merge branch 'udev-module-load' into 'main'
udev: load the required kernel modules

See merge request Librem5/feedbackd!106
2023-02-09 13:25:24 +00:00
Guido Günther 4ea946b059 debian: Drop obsolete conf file
As this is now handled via udev's kmod builtin we can drop this.
2023-02-09 13:56:08 +01:00
Dylan Van Assche 82c07e28f2 udev: load the required kernel modules
Loading the required kernel modules such as ledtrig-pattern via
/etc/modules-load.d may introduce a race condition on some systems such
as non-systemd based distros. Load the kernel modules using the builtin
'kmod load' udev command instead.
2023-02-08 20:46:00 +01:00
Guido Gunther 25913a6aad Merge branch 'rel-0.0.3' into 'main'
Document changes and release 0.0.3

See merge request Librem5/feedbackd!105
2023-02-02 12:59:54 +00:00
Guido Günther 45bc7bc417 Document changes and release 0.0.3 2023-02-02 13:49:09 +01:00
Guido Gunther a8bba744b1 Merge branch 'gmobile-0.0.1' into 'main'
Update to gmobile 0.0.1

See merge request Librem5/feedbackd!104
2023-02-02 12:47:58 +00:00
Guido Günther 4822be0f7c Update to gmobile 0.0.1
Adjust to the one API change. We do it all in one commit to keep
bisectability. We use a slightly newer commit than 0.0.1 to include
build fixes for older glib (as required on PureOS Byzantium).
2023-02-02 13:04:48 +01:00
Guido Günther 769fda1c68 ci: Update submodule strategy 2023-02-02 13:04:48 +01:00
Guido Gunther 3a09ea5e56 Merge branch 'doc-links' into 'main'
Fix some broken spec links

See merge request Librem5/feedbackd!102
2023-01-06 15:17:27 +00:00
Guido Günther 88cc9a2d54 libfeedback: Fix link to specs
Since we now have them as part of the API docs we can avoid any
remote URLs
2023-01-06 15:04:29 +00:00
Guido Günther ae85ac15d5 doc: Fix link to spec in manpage 2023-01-06 15:04:29 +00:00
Guido Günther d7eed4fd52 lfb-event: Fix docstring
This allows gi-docgen to pick it up
2023-01-06 15:04:29 +00:00
Guido Gunther cf50773580 Merge branch 'app-and-system-events' into 'main'
event-naming-spec: Separate application and system events

See merge request Librem5/feedbackd!101
2023-01-06 15:00:50 +00:00
Guido Günther 0d50276f94 feedback-theme: Add screen-shot event
Used to indicate that a screen shot is being taken.
2023-01-02 11:45:11 +01:00
Guido Günther b09f37b065 event-naming-spec: Separate application and system events
Make it obvious which events are meant to be used by "normal" GUI
applications in contrast to system components like desktop shells or
components monitoring the battery, etc.

This was prompted by
https://github.com/flatpak/xdg-desktop-portal/issues/929
2023-01-02 11:39:27 +01:00
Guido Gunther aa5e5e4045 Merge branch 'compile-fix' into 'main'
build: Add dbus sources to the lib dependency

See merge request Librem5/feedbackd!99
2022-12-15 18:29:26 +00:00
Guido Günther b10e699efa build: Add dbus sources to the lib dependency
Otherwise we might fail to generate it for the executables
2022-12-15 17:54:08 +01:00
Guido Gunther fca952f813 Merge branch 'rel-0.0.2' into 'main'
Release 0.0.2

See merge request Librem5/feedbackd!98
2022-12-15 15:25:21 +00:00
Guido Günther 42e9f38cc5 Add NEWS file 2022-12-15 11:52:25 +01:00
Guido Günther 089769bbcb d/gbp.conf: Bump meson version automatically 2022-12-15 11:29:03 +01:00
Guido Günther 0e98a51a5d Document changes and release 0.0.2 2022-12-15 11:29:03 +01:00
Guido Gunther 2365c0e692 Merge branch 'pkg-fixes' into 'main'
Fix nodoc and make nocheck build less

See merge request Librem5/feedbackd!97
2022-12-15 10:24:35 +00:00
Guido Günther c26eaa88b7 d/rules: Don't build tests with nocheck 2022-12-15 10:11:05 +00:00
Guido Günther f2d02050d1 d/rules: Fix nodoc build profile usage
We were checking for the wrong option
2022-12-15 10:11:05 +00:00
Guido Gunther 2514b50b32 Merge branch 'comment_example' into 'main'
extend comment about GI_TYPELIB_PATH

See merge request Librem5/feedbackd!87
2022-12-15 10:10:50 +00:00
Chris Vogel 312f0697cb example: Document usage 2022-12-15 10:57:09 +01:00
Chris Vogel d4197ed7a4 run: Don't hardcode feedbackd
This allows arbitrary executables from the source tree with
a well defined environment.
2022-12-15 10:57:09 +01:00
Chris Vogel 59e42d8332 run: Export GI_TYPELIB_PATH as well
This is needed for programs needing GObject introspection data
2022-12-15 10:57:09 +01:00
Guido Gunther 341c6844a1 Merge branch 'fbd-theme-check' into 'main'
Add theme validator

See merge request Librem5/feedbackd!95
2022-12-14 12:25:52 +00:00
Guido Günther 49f697b232 doc: Add manual page for fbd-theme-validate 2022-12-13 13:47:18 +01:00