SymbX/feedbackd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lfb-event: Don't leak error

Browse Source 
Don't leak the error values in the success case
This commit is contained in:
Guido Günther
2021-02-05 16:56:24 +01:00
parent 0a5dac1e53
commit 8c8382a0d2
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libfeedback/lfb-event.c
+4 -4
View File
@@ -148,7 +148,7 @@ on_trigger_feedback_finished (LfbGdbusFeedback *proxy,
{ {
GTask *task = data->task; GTask *task = data->task;
LfbEvent *self = data->event; LfbEvent *self = data->event;
GError *err = NULL; g_autoptr (GError) err = NULL;
gboolean success; gboolean success;
LfbEventState state; LfbEventState state;
@@ -161,7 +161,7 @@ on_trigger_feedback_finished (LfbGdbusFeedback *proxy,
res, res,
&err); &err);
if (!success) { if (!success) {
g_task_return_error (task, err); g_task_return_error (task, g_steal_pointer (&err));
state = LFB_EVENT_STATE_ERRORED; state = LFB_EVENT_STATE_ERRORED;
} else { } else {
g_task_return_boolean (task, TRUE); g_task_return_boolean (task, TRUE);
@@ -183,7 +183,7 @@ on_end_feedback_finished (LfbGdbusFeedback *proxy,
{ {
GTask *task = data->task; GTask *task = data->task;
LfbEvent *self = data->event; LfbEvent *self = data->event;
GError *err = NULL; g_autoptr (GError) err = NULL;
gboolean success; gboolean success;
g_return_if_fail (G_IS_TASK (task)); g_return_if_fail (G_IS_TASK (task));
@@ -194,7 +194,7 @@ on_end_feedback_finished (LfbGdbusFeedback *proxy,
res, res,
&err); &err);
if (!success) { if (!success) {
g_task_return_error (task, err); g_task_return_error (task, g_steal_pointer (&err));
} else } else
g_task_return_boolean (task, TRUE); g_task_return_boolean (task, TRUE);