From 8c8382a0d2a1fea94b02cd4ca91da8a3103d1003 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Fri, 5 Feb 2021 15:51:15 +0100 Subject: [PATCH] lfb-event: Don't leak error Don't leak the error values in the success case --- libfeedback/lfb-event.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libfeedback/lfb-event.c b/libfeedback/lfb-event.c index c0b5bd4..aad6a15 100644 --- a/libfeedback/lfb-event.c +++ b/libfeedback/lfb-event.c @@ -148,7 +148,7 @@ on_trigger_feedback_finished (LfbGdbusFeedback *proxy, { GTask *task = data->task; LfbEvent *self = data->event; - GError *err = NULL; + g_autoptr (GError) err = NULL; gboolean success; LfbEventState state; @@ -161,7 +161,7 @@ on_trigger_feedback_finished (LfbGdbusFeedback *proxy, res, &err); if (!success) { - g_task_return_error (task, err); + g_task_return_error (task, g_steal_pointer (&err)); state = LFB_EVENT_STATE_ERRORED; } else { g_task_return_boolean (task, TRUE); @@ -183,7 +183,7 @@ on_end_feedback_finished (LfbGdbusFeedback *proxy, { GTask *task = data->task; LfbEvent *self = data->event; - GError *err = NULL; + g_autoptr (GError) err = NULL; gboolean success; g_return_if_fail (G_IS_TASK (task)); @@ -194,7 +194,7 @@ on_end_feedback_finished (LfbGdbusFeedback *proxy, res, &err); if (!success) { - g_task_return_error (task, err); + g_task_return_error (task, g_steal_pointer (&err)); } else g_task_return_boolean (task, TRUE);