Commit Graph
5074 Commits
Author SHA1 Message Date
Ben Chan 024825042e plugin-manager: minor coding style fixes 2017-07-17 13:46:12 -05:00
Aleksander Morgado 5ee0b32298 zte,icera: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado 7b392398e4 zte: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado ef274b5fa2 simtech: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado a3c980c78b option,hso: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado f3a301db3c option: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado e2246da507 mtk: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado 15a221e88d mbm: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado 0be6e7d2ea altair-lte: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado c44fa6c681 icera: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:17 +02:00
Aleksander Morgado f1f313c214 huawei: skip unrequired explicit casts to GSimpleAsyncResult 2017-07-17 10:20:16 +02:00
Aleksander Morgado 91bbcb5c5f huawei: fix async completion in 3gpp event handlers setting 2017-07-17 10:20:16 +02:00
Aleksander Morgado c0c2e8aae8 huawei: fix async completion in voice event handlers setting 2017-07-17 10:20:16 +02:00
Aleksander Morgado 7b0c0bc96b huawei: fix async completion in cdma event handlers setting 2017-07-17 10:20:16 +02:00
Aleksander Morgado 24e8785a83 via: fix async completion in cdma event handlers setting 2017-07-17 10:14:13 +02:00
Ben Chan 94a289a1b3 modem-helpers: minor coding style fixes 2017-07-14 10:59:46 +02:00
Ben Chan 45682aa7ee sms-part-3gpp: minor coding style fixes 2017-07-14 10:59:46 +02:00
Ben Chan 057732663b broadband-modem-mbim: minor coding style fixes 2017-07-14 10:59:46 +02:00
Ben Chan da20697e18 base-call: minor coding style fixes 2017-07-14 10:59:46 +02:00
Ben Chan cb6efd8eda base-manager: minor coding style fixes 2017-07-14 10:59:46 +02:00
Ben Chan 1158c2c6e9 broadband-modem: rename load_power_state for consistency
All MMIfaceModem functions implemented by MMBroadbandModem, except
load_power_state, are prefixed with 'modem_'. For consistency, this
patch renames load_power_state{,_finish} to
modem_load_power_state{,_finish}.
2017-07-14 09:48:20 +02:00
Aleksander Morgado aafd21ac31 broadband-modem-mbim: avoid multiple MM_BROADBAND_MODEM_MBIM() casts 2017-07-12 11:21:41 +02:00
Eric Caruso 3d9510b4fd mm-broadband-modem-mbim: support SIM hot swapping
If an MBIM modem supports unsolicited notifications for
subscriber ready status, we can use it to detect when SIM cards
have been removed and reinserted. Upon detection we should re-
probe the modem so that we can configure it for the new SIM.
2017-07-12 11:15:07 +02:00
Ben Chan fe384625aa telit: fix memory leaks in unit tests 2017-07-12 11:04:09 +02:00
Ben Chan 4fbdee1e6d telit: minor coding style fixes 2017-07-12 11:04:09 +02:00
Ben Chan 39ddd34898 telit: remove unnecessary NULL checks for g_free / g_match_info_free
g_free() and g_match_info_free() already check if the given pointer is
NULL and does nothing on a NULL pointer.
2017-07-12 11:04:09 +02:00
Ben Chan 4a7190f64b telit: fix memory leak in mm_telit_get_4g_mm_bands 2017-07-12 11:04:09 +02:00
Ben Chan b6f40de1e1 telit: remove unused 'flags' variable in mm_telit_get_4g_mm_bands 2017-07-12 11:04:09 +02:00
Ben Chan 99dd037a68 iface-modem: fix mm_iface_modem_initialize_finish
This fixes commit 66f10d61a2
("iface-modem: port mm_iface_modem_initialize to use GTask"), which
didn't update mm_iface_modem_initialize_finish to use
g_task_propagate_boolean.
2017-07-12 11:03:23 +02:00
Ben Chan 4e99ca7fd5 ublox: fix memory leaks in unit tests 2017-07-12 11:01:27 +02:00
Aleksander Morgado 247890739b broadband-modem-mbim: remove unused variable
CC       ModemManager-mm-broadband-modem-mbim.o
    mm-broadband-modem-mbim.c: In function ‘mbim_port_open_ready’:
    mm-broadband-modem-mbim.c:1581:35: error: unused variable ‘ctx’ [-Werror=unused-variable]
         InitializationStartedContext *ctx;
                                       ^~~
    cc1: all warnings being treated as errors
2017-07-12 10:59:27 +02:00
Ben Chan 350aa6a461 broadband-modem-mbim: port remaining code to use GTask
This patch ports the following functions in MMBroadbandModemMbim to use GTask:
- common_enable_disable_unsolicited_events
- common_setup_cleanup_unsolicited_events
- load_initial_sms_parts
- modem_3gpp_load_enabled_facility_locks
- modem_3gpp_register_in_network
- modem_3gpp_run_registration_checks
- modem_3gpp_scan_networks
- modem_load_current_capabilities
- modem_load_own_numbers
- modem_load_power_state
- modem_load_unlock_required
- modem_load_unlock_retries
- modem_power_down
- modem_power_up
2017-07-11 19:24:23 -07:00
Ben Chan 20b3675adf broadband-modem-mbim: port initialization_started to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan e8ffefaf6f broadband-modem-mbim: port enabling_started to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan e0eb23d9a6 broadband-modem-mbim: port modem_create_bearer to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan ec14a26a7d broadband-modem-mbim: port messaging_load_supported_storages to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 5bf0af7a83 broadband-modem-mbim: port messaging_check_support to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan cc71743e26 broadband-modem-mbim: port modem_3gpp_load_imei to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 5b0b3f326e broadband-modem-mbim: port modem_3gpp_load_operator_code to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 9401aa70e5 broadband-modem-mbim: port modem_3gpp_load_operator_name to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan fb38601ef4 broadband-modem-mbim: port modem_load_supported_ip_families to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 99bb49d814 broadband-modem-mbim: port modem_load_supported_modes to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan df0049d1c2 broadband-modem-mbim: port modem_load_device_identifier to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 43aaa92ee1 broadband-modem-mbim: port modem_load_equipment_identifier to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan fb9c758f05 broadband-modem-mbim: port modem_load_revision to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 234d7810f5 broadband-modem-mbim: port modem_load_model to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 6cf6eeb0aa broadband-modem-mbim: port modem_load_manufacturer to use GTask 2017-07-11 10:30:39 -07:00
Ben Chan 3a789c0de7 bearer-qmi: replace g_new + memcpy with g_memdup 2017-07-11 11:36:53 +02:00
Ben Chan 627ef274df plugin: check error returned by g_task_propagate_error instead
mm_plugin_supports_port_finish directly casts the value returned by
g_task_propagate_int to MMPluginSupportsResult enum value, which
implicitly assumes MM_PLUGIN_SUPPORTS_PORT_UNKNOWN equals to -1.
Instead of relying on such an implicit assumption, this patch modifies
the code to check if the GError argument to g_task_propagate_error is
populated instead.
2017-07-07 10:23:46 +02:00
Ben Chan a36347eff7 broadband-bearer: check error returned by g_task_propagate_error instead
When returning an enum value via g_task_return_int, some code assumes
the enum value is always non-negative and thus considers that a negative
value implies an error. This assumption could be invalidated if a
negative value is later added to the enum. To make it less error prone
to future changes, this patch modifies the code to check if the GError
argument to g_task_propagate_error is populated instead.
2017-07-07 10:23:46 +02:00