SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm-modem-helpers-qmi: avoid SIGSEGV with mmcli --set-current-bands

Browse Source 
For devices which do not provide feature_extended_lte_band_preference
mm_modem_bands_to_qmi_band_preference() gets called from
mm_shared_qmi_set_current_bands() with extended_qmi_lte_bands
set to NULL which may cause a SIGSEGV in the memset() call in
mm_modem_bands_to_qmi_band_preference().

Avoid this by checking whether extended_qmi_lte_bands is non-NULL
before calling memset().

Reported-by: Nick <mips171@icloud.com>
This commit is contained in:
Reinhard Speyerer
2019-08-23 16:49:57 -05:00
committed by Dan Williams
parent e78ef2a67f
commit f2c878e796
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mm-modem-helpers-qmi.c
+2 -1
View File
@@ -581,7 +581,8 @@ mm_modem_bands_to_qmi_band_preference (GArray *mm_bands,
*qmi_bands = 0;
*qmi_lte_bands = 0;
memset (extended_qmi_lte_bands, 0, extended_qmi_lte_bands_size * sizeof (guint64));
if (extended_qmi_lte_bands)
memset (extended_qmi_lte_bands, 0, extended_qmi_lte_bands_size * sizeof (guint64));
for (i = 0; i < mm_bands->len; i++) {
MMModemBand band;