broadband-modem: initialize 'tac' in registration_status_check_ready()

mm-broadband-modem.c:4395:13: error: variable 'tac' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
        if (act == MM_MODEM_ACCESS_TECHNOLOGY_LTE) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm-broadband-modem.c:4407:75: note: uninitialized use occurs here
    mm_iface_modem_3gpp_update_location (MM_IFACE_MODEM_3GPP (self), lac, tac, cid);
                                                                          ^~~
mm-broadband-modem.c:4395:9: note: remove the 'if' if its condition is always true
        if (act == MM_MODEM_ACCESS_TECHNOLOGY_LTE) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm-broadband-modem.c:4380:9: error: variable 'tac' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
    if (cgreg) {
        ^~~~~
mm-broadband-modem.c:4407:75: note: uninitialized use occurs here
    mm_iface_modem_3gpp_update_location (MM_IFACE_MODEM_3GPP (self), lac, tac, cid);
                                                                          ^~~
mm-broadband-modem.c:4380:5: note: remove the 'if' if its condition is always false
    if (cgreg) {
    ^~~~~~~~~~~~
mm-broadband-modem.c:4280:15: note: initialize the variable 'tac' to silence this warning
    gulong tac;
              ^
               = 0

This commit is contained in:

Ben Chan

2018-08-10 11:06:19 +02:00

committed by

Aleksander Morgado

parent b378be0f0d

commit d21dd6cf1f

1 changed files with 1 additions and 0 deletions

									
										src/mm-broadband-modem.c
									
		+1
		
												View File
												
				@@ -4344,6 +4344,7 @@ registration_status_check_ready (MMBroadbandModem *self,

				    cereg = FALSE;

				    state = MM_MODEM_3GPP_REGISTRATION_STATE_UNKNOWN;

				    act = MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN;

				    tac = 0;

				    lac = 0;

				    cid = 0;

				    parsed = mm_3gpp_parse_creg_response (match_info,