SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libmm-glib,manager: fix manager interface proxy creation

Browse Source 
We were re-using the GDBusObjectManagerClientFlags set in the
MMManager object as GDBusProxyFlags for the Manager1 interface proxy
object, and that was completely broken.

Instead of setting "DO_NOT_AUTO_START" in the proxy, we were actually
setting "DO_NOT_LOAD_PROPERTIES"...
This commit is contained in:
Aleksander Morgado
2018-12-04 17:26:59 +00:00
committed by Dan Williams
parent 3b743dcc36
commit d0bb8d1d50
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libmm-glib/mm-manager.c
+7 -3
View File
@@ -96,7 +96,8 @@ ensure_modem_manager1_proxy (MMManager *self,
{
gchar *name = NULL;
gchar *object_path = NULL;
GDBusProxyFlags flags = G_DBUS_PROXY_FLAGS_NONE;
GDBusObjectManagerClientFlags obj_manager_flags = G_DBUS_OBJECT_MANAGER_CLIENT_FLAGS_NONE;
GDBusProxyFlags proxy_flags = G_DBUS_PROXY_FLAGS_NONE;
GDBusConnection *connection = NULL;
if (self->priv->manager_iface_proxy)
@@ -106,13 +107,16 @@ ensure_modem_manager1_proxy (MMManager *self,
g_object_get (self,
"name", &name,
"object-path", &object_path,
"flags", &flags,
"flags", &obj_manager_flags,
"connection", &connection,
NULL);
if (obj_manager_flags & G_DBUS_OBJECT_MANAGER_CLIENT_FLAGS_DO_NOT_AUTO_START)
proxy_flags |= G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START;
self->priv->manager_iface_proxy =
mm_gdbus_org_freedesktop_modem_manager1_proxy_new_sync (connection,
flags,
proxy_flags,
name,
object_path,
NULL,