SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-qmi: fix warnings with -Wswitch-enum

Browse Source 
mm-broadband-modem-qmi.c: In function ‘qmi_dbm_valid’:
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_UNKNOWN’ not handled in switch [-Werror=switch-enum]
   1385 |     switch (radio_interface) {
        |     ^~~~~~
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_NONE’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_AMPS’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_GSM’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_LTE’ not handled in switch [-Werror=switch-enum]
  mm-broadband-modem-qmi.c:1385:5: error: enumeration value ‘QMI_NAS_RADIO_INTERFACE_TD_SCDMA’ not handled in switch [-Werror=switch-enum]
  ...
This commit is contained in:
Aleksander Morgado
2020-01-30 11:59:15 +01:00
parent 92c219480b
commit 581d829eb7
1 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mm-broadband-modem-qmi.c
+21
View File
@@ -1392,6 +1392,13 @@ qmi_dbm_valid (gint8 dbm, QmiNasRadioInterface radio_interface)
return (dbm > -125 && dbm < -30);
case QMI_NAS_RADIO_INTERFACE_UMTS:
return (dbm > -125 && dbm < -30);
case QMI_NAS_RADIO_INTERFACE_UNKNOWN:
case QMI_NAS_RADIO_INTERFACE_NONE:
case QMI_NAS_RADIO_INTERFACE_AMPS:
case QMI_NAS_RADIO_INTERFACE_GSM:
case QMI_NAS_RADIO_INTERFACE_LTE:
case QMI_NAS_RADIO_INTERFACE_TD_SCDMA:
/* no explicit validation */
default:
break;
}
@@ -1994,6 +2001,10 @@ dms_get_operating_mode_ready (QmiClientDms *client,
case QMI_DMS_OPERATING_MODE_OFFLINE:
g_task_return_int (task, MM_MODEM_POWER_STATE_OFF);
break;
case QMI_DMS_OPERATING_MODE_SHUTTING_DOWN:
case QMI_DMS_OPERATING_MODE_FACTORY_TEST:
case QMI_DMS_OPERATING_MODE_RESET:
case QMI_DMS_OPERATING_MODE_UNKNOWN:
default:
g_task_return_new_error (task,
MM_CORE_ERROR,
@@ -8029,6 +8040,10 @@ signal_load_values_get_signal_strength_ready (QmiClientNas *client,
ctx->values_result->lte = mm_signal_new ();
mm_signal_set_rssi (ctx->values_result->lte, (gdouble)element->rssi);
break;
case QMI_NAS_RADIO_INTERFACE_UNKNOWN:
case QMI_NAS_RADIO_INTERFACE_NONE:
case QMI_NAS_RADIO_INTERFACE_AMPS:
case QMI_NAS_RADIO_INTERFACE_TD_SCDMA:
default:
break;
}
@@ -8058,6 +8073,12 @@ signal_load_values_get_signal_strength_ready (QmiClientNas *client,
mm_signal_set_ecio (ctx->values_result->umts, ((gdouble)element->ecio) * (-0.5));
break;
default:
case QMI_NAS_RADIO_INTERFACE_GSM:
case QMI_NAS_RADIO_INTERFACE_LTE:
case QMI_NAS_RADIO_INTERFACE_UNKNOWN:
case QMI_NAS_RADIO_INTERFACE_NONE:
case QMI_NAS_RADIO_INTERFACE_AMPS:
case QMI_NAS_RADIO_INTERFACE_TD_SCDMA:
break;
}
}