SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ublox: Mark ubandsel as unsupported on SARA-R4 and -N4

Browse Source 
See log from a SARA-R410M-02B-01 before the change:

    Feb 01 05:40:01 unit ModemManager[304]: <debug> [1612158001.012330] [modem0/ttymxc4/at] --> 'AT+UBANDSEL?<CR>'
    Feb 01 05:40:01 unit ModemManager[304]: <debug> [1612158001.026831] [modem0/ttymxc4/at] <-- '<CR><LF>ERROR<CR><LF>'
    Feb 01 05:40:01 unit ModemManager[304]: <debug> [1612158001.027113] [modem0/ttymxc4/at] operation failure: 100 (Unknown error)
    Feb 01 05:40:01 unit ModemManager[304]: <warn>  [1612158001.027298] [modem0] couldn't load current bands: Unknown error

Backed by SARA-R4 series AT commands manual, no reference to +UBANDSEL
in the manual at all.

Log after the change:

    Feb 01 06:58:25 unit ModemManager[329]: <debug> [1612162705.500845] [modem0] (u-blox) support configuration found for 'SARA-R410M-02B'
    Feb 01 06:58:25 unit ModemManager[329]: <debug> [1612162705.500961] [modem0] (u-blox)   band update requires explicit unregistration
    Feb 01 06:58:25 unit ModemManager[329]: <debug> [1612162705.501052] [modem0] (u-blox)   UACT based band configuration unsupported
    Feb 01 06:58:25 unit ModemManager[329]: <debug> [1612162705.501141] [modem0] (u-blox)   UBANDSEL based band configuration unsupported

Fixes: 437fb830c8 ("ublox,helpers: assume all SARA/LARA devices require COPS")
Signed-off-by: Alexander Dahl <ada@thorsis.com>
This commit is contained in:
Alexander Dahl
2021-07-07 17:20:23 +02:00
parent 7c9d1e45be
commit 266e98e020
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/ublox/mm-modem-helpers-ublox.c
+4 -4
View File
@@ -888,7 +888,7 @@ static const BandConfiguration band_configuration[] = {
.model = "SARA-R410M-52B",
.method = SETTINGS_UPDATE_METHOD_COPS,
.uact = FEATURE_UNSUPPORTED,
.ubandsel = FEATURE_SUPPORTED,
.ubandsel = FEATURE_UNSUPPORTED,
.mode = MM_MODEM_MODE_4G,
.bands_4g = { MM_MODEM_BAND_EUTRAN_2, MM_MODEM_BAND_EUTRAN_4, MM_MODEM_BAND_EUTRAN_5,
MM_MODEM_BAND_EUTRAN_12, MM_MODEM_BAND_EUTRAN_13 }
@@ -897,7 +897,7 @@ static const BandConfiguration band_configuration[] = {
.model = "SARA-R410M-02B",
.method = SETTINGS_UPDATE_METHOD_COPS,
.uact = FEATURE_UNSUPPORTED,
.ubandsel = FEATURE_SUPPORTED,
.ubandsel = FEATURE_UNSUPPORTED,
.mode = MM_MODEM_MODE_4G,
.bands_4g = { MM_MODEM_BAND_EUTRAN_1, MM_MODEM_BAND_EUTRAN_2, MM_MODEM_BAND_EUTRAN_3,
MM_MODEM_BAND_EUTRAN_4, MM_MODEM_BAND_EUTRAN_5, MM_MODEM_BAND_EUTRAN_8,
@@ -908,7 +908,7 @@ static const BandConfiguration band_configuration[] = {
.model = "SARA-R412M-02B",
.method = SETTINGS_UPDATE_METHOD_COPS,
.uact = FEATURE_UNSUPPORTED,
.ubandsel = FEATURE_SUPPORTED,
.ubandsel = FEATURE_UNSUPPORTED,
.mode = MM_MODEM_MODE_2G | MM_MODEM_MODE_4G,
.bands_2g = { MM_MODEM_BAND_G850, MM_MODEM_BAND_EGSM, MM_MODEM_BAND_DCS, MM_MODEM_BAND_PCS },
.bands_4g = { MM_MODEM_BAND_EUTRAN_1, MM_MODEM_BAND_EUTRAN_2, MM_MODEM_BAND_EUTRAN_3,
@@ -920,7 +920,7 @@ static const BandConfiguration band_configuration[] = {
.model = "SARA-N410-02B",
.method = SETTINGS_UPDATE_METHOD_COPS,
.uact = FEATURE_UNSUPPORTED,
.ubandsel = FEATURE_SUPPORTED,
.ubandsel = FEATURE_UNSUPPORTED,
.mode = MM_MODEM_MODE_4G,
.bands_4g = { MM_MODEM_BAND_EUTRAN_1, MM_MODEM_BAND_EUTRAN_2, MM_MODEM_BAND_EUTRAN_3,
MM_MODEM_BAND_EUTRAN_4, MM_MODEM_BAND_EUTRAN_5, MM_MODEM_BAND_EUTRAN_8,