SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
fa0cd9b79f85dc6d24cd7d3f7c554b35bd5191fd
systemd/src
T
History
Chris Mason fa0cd9b79f dissect-image: fix wrong errno on pread failure 
In acquire_sig_for_roothash() the pread() failure branch returns
-ENOMEM, which is copy-pasted from the malloc() check immediately
above it:

    _cleanup_free_ char *buf = new(char, partition_size+1);
    if (!buf)
            return -ENOMEM;

    ssize_t n = pread(fd, buf, partition_size, partition_offset);
    if (n < 0)
            return -ENOMEM;

pread() sets errno to the actual I/O failure (EIO, EINTR, EBADF,
...). Aliasing those to -ENOMEM misleads dissect_log_error() and
any caller that branches on the returned code; verity signature
lookup failures get reported as out-of-memory.

Fix by returning -errno from the pread() failure branch. The
malloc() branch above is correct and unchanged.

Fixes: 98ca65c36a ("dissect: check that roothash in signature matches before selecting partition")
Assisted-by: kres (claude-opus-4-7)
Signed-off-by: Chris Mason <clm@meta.com>
2026-05-22 22:14:48 +02:00
..
ac-power
shared/help-util: automatically append ":" in sections
2026-05-05 11:14:33 +02:00
analyze
analyze: show priority in 'nvpcrs' output
2026-05-21 16:09:25 +02:00
ask-password
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
backlight
tree-wide: use device_get_sysattr_unsigned() and friends
2026-05-18 02:55:56 +09:00
basic
Use malloc'ed strings instead of static libc buffers for user and group lookup (#42184)
2026-05-22 05:09:56 +09:00
battery-check
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
binfmt
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
bless-boot
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
boot
boot: measure select SMBIOS objects explicitly
2026-05-21 18:34:01 +02:00
bootctl
bootctl: refactor get_file_version() to use proper PE parsing
2026-05-22 12:26:25 +02:00
bpf
Various dlopen/linking cleanups from #42100 (#42166)
2026-05-19 08:54:27 +02:00
busctl
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
cgls
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
cgtop
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
core
Use malloc'ed strings instead of static libc buffers for user and group lookup (#42184)
2026-05-22 05:09:56 +09:00
coredump
user-util: return malloc'ed strings in get_user_creds
2026-05-21 18:02:05 +02:00
coverage
…
creds
user-util: return malloc'ed strings in get_user_creds
2026-05-21 18:02:05 +02:00
cryptenroll
pkcs11: switch to RSA-OAEP SHA-256/SHA-1
2026-05-22 14:09:16 +01:00
cryptsetup
pkcs11: switch to RSA-OAEP SHA-256/SHA-1
2026-05-22 14:09:16 +01:00
debug-generator
…
delta
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
detect-virt
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
dissect
dissect: convert the other parser to option macros
2026-05-16 18:36:08 +02:00
environment-d-generator
…
escape
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
factory-reset
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
firstboot
firstboot: allow configuring machine tags via firstboot
2026-05-21 18:30:16 +02:00
fsck
…
fstab-generator
fstab-generator: fix spurious quota warning for xfs
2026-05-19 13:12:43 +01:00
fundamental
boot: measure select SMBIOS objects explicitly
2026-05-21 18:34:01 +02:00
fuzz
fuzz-bootspec: apply "ruff format"
2026-05-18 02:44:46 +09:00
getty-generator
…
gpt-auto-generator
…
growfs
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
hibernate-resume
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
home
pkcs11: switch to RSA-OAEP SHA-256/SHA-1
2026-05-22 14:09:16 +01:00
hostname
hostnamectl: add support for tagging the machine
2026-05-21 18:30:16 +02:00
hwdb
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
id128
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
imds
curl-util: bring CurlGlue/CurlSlot in line with sd-bus and qmp-client
2026-05-08 16:52:57 +02:00
import
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
include
Introduce support for running code in fibers (#39771)
2026-05-21 16:21:13 +02:00
integritysetup
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
journal
meson: drop libdl, threads, and librt dependencies
2026-05-18 21:17:38 +00:00
journal-remote
Various dlopen/linking cleanups from #42100 (#42166)
2026-05-19 08:54:27 +02:00
kernel-install
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
keyutil
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
libc
musl: drop renameat2() wrapper
2026-05-21 05:06:35 +09:00
libsystemd
hwdb: reject out-of-bounds fnmatch prefixes
2026-05-22 09:17:24 +01:00
libsystemd-network
sd-dhcp-server-lease: always update all information in bound lease
2026-05-22 22:11:45 +09:00
libudev
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
locale
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
login
logind: automatically pull in systemd-pcrlogin@.service on first login
2026-05-22 12:15:14 +02:00
machine
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
machine-id-setup
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
measure
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
modules-load
cpu-set-util: introduce cpus_online().
2026-05-14 08:12:28 +02:00
mount
user-util: return malloc'ed strings in get_user_creds
2026-05-21 18:02:05 +02:00
mountfsd
Improve error logging for fstat failure
2026-04-30 08:05:54 +02:00
mstack
mstack-tool: convert to OPTION macros
2026-05-05 13:49:51 +02:00
mute-console
bootctl,mute-console,pcrextend,pcrlock,repart: allow connections from self
2026-05-05 17:23:16 +02:00
network
sd-dhcp-server: several trivial cleanups (#42235)
2026-05-22 06:44:07 +09:00
notify
user-util: return malloc'ed strings in get_user_creds
2026-05-21 18:02:05 +02:00
nspawn
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
nsresourced
nsresourced: Add more debug logging
2026-05-21 17:20:30 +00:00
nss-myhostname
…
nss-mymachines
…
nss-resolve
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
nss-systemd
…
oom
oomd: ruleset parsing
2026-05-18 21:42:56 +02:00
path
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
pcrextend
pcrextend: add support for measuring a user record, to be executed on first login of the user
2026-05-22 12:15:12 +02:00
pcrlock
pcrlock: port --help to help-util.[ch] apis
2026-05-21 21:44:06 +01:00
portable
meson: drop libdl, threads, and librt dependencies
2026-05-18 21:17:38 +00:00
pstore
meson: drop libdl, threads, and librt dependencies
2026-05-18 21:17:38 +00:00
ptyfwd
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
quotacheck
…
random-seed
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
remount-fs
…
repart
repart: canonicalize node in varlink Run method
2026-05-20 16:22:00 +02:00
reply-password
…
report
report-basic: report TPM2 vendor strings too
2026-05-22 12:24:29 +02:00
resolve
user-util: return malloc'ed strings in get_user_creds
2026-05-21 18:02:05 +02:00
rfkill
tree-wide: use device_get_sysattr_safe_string()
2026-05-18 02:55:56 +09:00
rpm
…
run
user-util: return malloc'ed strings in get_user_creds
2026-05-21 18:02:05 +02:00
run-generator
…
sbsign
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
shared
dissect-image: fix wrong errno on pread failure
2026-05-22 22:14:48 +02:00
shutdown
shutdown: prepare LUO session for FD Stores before kexec
2026-05-15 13:46:08 +01:00
sleep
tree-wide: use device_get_sysattr_unsigned() and friends
2026-05-18 02:55:56 +09:00
socket-activate
meson: drop libdl, threads, and librt dependencies
2026-05-18 21:17:38 +00:00
socket-proxy
socket-proxy: implement PROXY protocol v1
2026-05-20 04:29:59 +09:00
ssh-generator
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
stdio-bridge
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
storage
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
storagetm
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
sulogin-shell
…
sysctl
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
sysext
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
sysinstall
firstboot: make clear where the full screen console wizards end
2026-05-21 09:09:38 +09:00
system-update-generator
…
systemctl
systemctl: also attempt kexec image extraction on EINVAL
2026-05-21 19:00:58 +01:00
systemd
sd-dhcp-relay: use forward declarations
2026-05-22 08:33:48 +09:00
sysupdate
sysupdate: List default component only if transfer definition exists (#42179)
2026-05-22 14:07:06 +01:00
sysusers
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
test
meson: fix build with -Dmachine=false
2026-05-22 16:03:47 +01:00
timedate
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
timesync
meson: drop libdl, threads, and librt dependencies
2026-05-18 21:17:38 +00:00
tmpfiles
user-util: return malloc'ed strings in get_user_creds
2026-05-21 18:02:05 +02:00
tpm2-setup
pcrextend: add support for measuring a user record, to be executed on first login of the user
2026-05-22 12:15:12 +02:00
tty-ask-password-agent
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
udev
tree-wide: standardize header names across src/fundamental, src/basic and src/shared
2026-05-21 10:33:03 +09:00
ukify
test-ukify: Skip kernel images we can't access
2026-05-20 16:04:26 +00:00
update-done
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
update-utmp
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
user-sessions
…
userdb
meson: drop libdl, threads, and librt dependencies
2026-05-18 21:17:38 +00:00
validatefs
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
varlinkctl
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
vconsole
vconsole-util: move code to read EFI keyboard layout into generic code
2026-05-20 16:34:21 +02:00
veritysetup
tree-wide: get rid of old dispatch_verb
2026-05-16 18:37:10 +02:00
version
…
vmspawn
vmspawn: move --kernel=/--initrd= under the "Execution" section
2026-05-20 23:39:47 +02:00
volatile-root
…
vpick
options: get rid of "on_error" parameter to FOREACH_OPTION
2026-04-30 11:12:33 +01:00
xdg-autostart-generator
…