-1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary.
192 lines
4.8 KiB
C
192 lines
4.8 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
#include <fcntl.h>
|
|
#include <unistd.h>
|
|
|
|
#include "fd-util.h"
|
|
#include "fdset.h"
|
|
#include "macro.h"
|
|
#include "tests.h"
|
|
#include "tmpfile-util.h"
|
|
|
|
TEST(fdset_new_fill) {
|
|
int fd = -EBADF;
|
|
_cleanup_fdset_free_ FDSet *fdset = NULL;
|
|
char name[] = "/tmp/test-fdset_new_fill.XXXXXX";
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
assert_se(fdset_new_fill(&fdset) >= 0);
|
|
assert_se(fdset_contains(fdset, fd));
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_put_dup) {
|
|
_cleanup_close_ int fd = -EBADF;
|
|
int copyfd = -EBADF;
|
|
_cleanup_fdset_free_ FDSet *fdset = NULL;
|
|
char name[] = "/tmp/test-fdset_put_dup.XXXXXX";
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
|
|
fdset = fdset_new();
|
|
assert_se(fdset);
|
|
copyfd = fdset_put_dup(fdset, fd);
|
|
assert_se(copyfd >= 0 && copyfd != fd);
|
|
assert_se(fdset_contains(fdset, copyfd));
|
|
assert_se(!fdset_contains(fdset, fd));
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_cloexec) {
|
|
int fd = -EBADF;
|
|
_cleanup_fdset_free_ FDSet *fdset = NULL;
|
|
int flags = -1;
|
|
char name[] = "/tmp/test-fdset_cloexec.XXXXXX";
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
|
|
fdset = fdset_new();
|
|
assert_se(fdset);
|
|
assert_se(fdset_put(fdset, fd));
|
|
|
|
assert_se(fdset_cloexec(fdset, false) >= 0);
|
|
flags = fcntl(fd, F_GETFD);
|
|
assert_se(flags >= 0);
|
|
assert_se(!(flags & FD_CLOEXEC));
|
|
|
|
assert_se(fdset_cloexec(fdset, true) >= 0);
|
|
flags = fcntl(fd, F_GETFD);
|
|
assert_se(flags >= 0);
|
|
assert_se(flags & FD_CLOEXEC);
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_close_others) {
|
|
int fd = -EBADF;
|
|
int copyfd = -EBADF;
|
|
_cleanup_fdset_free_ FDSet *fdset = NULL;
|
|
int flags = -1;
|
|
char name[] = "/tmp/test-fdset_close_others.XXXXXX";
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
|
|
fdset = fdset_new();
|
|
assert_se(fdset);
|
|
copyfd = fdset_put_dup(fdset, fd);
|
|
assert_se(copyfd >= 0);
|
|
|
|
assert_se(fdset_close_others(fdset) >= 0);
|
|
flags = fcntl(fd, F_GETFD);
|
|
assert_se(flags < 0);
|
|
flags = fcntl(copyfd, F_GETFD);
|
|
assert_se(flags >= 0);
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_remove) {
|
|
_cleanup_close_ int fd = -EBADF;
|
|
FDSet *fdset = NULL;
|
|
char name[] = "/tmp/test-fdset_remove.XXXXXX";
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
|
|
fdset = fdset_new();
|
|
assert_se(fdset);
|
|
assert_se(fdset_put(fdset, fd) >= 0);
|
|
assert_se(fdset_remove(fdset, fd) >= 0);
|
|
assert_se(!fdset_contains(fdset, fd));
|
|
fdset_free(fdset);
|
|
|
|
assert_se(fcntl(fd, F_GETFD) >= 0);
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_iterate) {
|
|
int fd = -EBADF;
|
|
FDSet *fdset = NULL;
|
|
char name[] = "/tmp/test-fdset_iterate.XXXXXX";
|
|
int c = 0;
|
|
int a;
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
|
|
fdset = fdset_new();
|
|
assert_se(fdset);
|
|
assert_se(fdset_put(fdset, fd) >= 0);
|
|
assert_se(fdset_put(fdset, fd) >= 0);
|
|
assert_se(fdset_put(fdset, fd) >= 0);
|
|
|
|
FDSET_FOREACH(a, fdset) {
|
|
c++;
|
|
assert_se(a == fd);
|
|
}
|
|
assert_se(c == 1);
|
|
|
|
fdset_free(fdset);
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_isempty) {
|
|
int fd;
|
|
_cleanup_fdset_free_ FDSet *fdset = NULL;
|
|
char name[] = "/tmp/test-fdset_isempty.XXXXXX";
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
|
|
fdset = fdset_new();
|
|
assert_se(fdset);
|
|
|
|
assert_se(fdset_isempty(fdset));
|
|
assert_se(fdset_put(fdset, fd) >= 0);
|
|
assert_se(!fdset_isempty(fdset));
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_steal_first) {
|
|
int fd;
|
|
_cleanup_fdset_free_ FDSet *fdset = NULL;
|
|
char name[] = "/tmp/test-fdset_steal_first.XXXXXX";
|
|
|
|
fd = mkostemp_safe(name);
|
|
assert_se(fd >= 0);
|
|
|
|
fdset = fdset_new();
|
|
assert_se(fdset);
|
|
|
|
assert_se(fdset_steal_first(fdset) < 0);
|
|
assert_se(fdset_put(fdset, fd) >= 0);
|
|
assert_se(fdset_steal_first(fdset) == fd);
|
|
assert_se(fdset_steal_first(fdset) < 0);
|
|
assert_se(fdset_put(fdset, fd) >= 0);
|
|
|
|
unlink(name);
|
|
}
|
|
|
|
TEST(fdset_new_array) {
|
|
int fds[] = {10, 11, 12, 13};
|
|
_cleanup_fdset_free_ FDSet *fdset = NULL;
|
|
|
|
assert_se(fdset_new_array(&fdset, fds, 4) >= 0);
|
|
assert_se(fdset_size(fdset) == 4);
|
|
assert_se(fdset_contains(fdset, 10));
|
|
assert_se(fdset_contains(fdset, 11));
|
|
assert_se(fdset_contains(fdset, 12));
|
|
assert_se(fdset_contains(fdset, 13));
|
|
}
|
|
|
|
DEFINE_TEST_MAIN(LOG_INFO);
|