Commit Graph
3248 Commits
Author SHA1 Message Date
Yu Watanabe d96d8a81ef test: add tests for RouteTable= setting 2021-02-03 14:39:25 +09:00
Yu Watanabe 552b90a2f2 network: use defined route table name in debug logs
And rename route_table_from_string_full() to
manager_get_route_table_from_string().
2021-02-03 14:36:50 +09:00
Yu Watanabe 310eff7274 network: make RouteTable= setting can take multiple name:number pairs in a line
Follow-up for c038ce4606.
2021-02-03 14:32:26 +09:00
Yu Watanabe 8ccc31d498 network: drop one more link_dirty()
Follow-up for 9092113d93.

link_dirty() will be called later in this function when a DNS or domain
is dropped.
2021-02-01 01:11:44 +09:00
Daan De Meyer bc556335b1 tree-wide: Drop custom formatting for print() help messages
I think this formatting was originally used because it simplified
adding new options to the help messages. However, these days, most
tools their help message end with "\nSee the %s for details.\n" so
the final line almost never has to be edited which eliminates the
benefit of the custom formatting used for printf() help messages.
Let's make things more consistent and use the same formatting for
printf() help messages that we use everywhere else.

Prompted by https://github.com/systemd/systemd/pull/18355#discussion_r567241580
2021-01-31 13:14:02 +09:00
Zbigniew Jędrzejewski-Szmek ea3640ac96 Merge pull request #18320 from yuwata/network-reduce-trigger-network-events
network: do not trigger unnecessary network events
2021-01-30 15:30:17 +01:00
Zbigniew Jędrzejewski-Szmek 1d3a473b4a man: use ellipses for ranges in range descriptions
… and in few other places ;)
2021-01-29 17:02:23 +01:00
Zbigniew Jędrzejewski-Szmek 4c30eb573c networkd: add header to distributed "config" files 2021-01-28 09:55:36 +01:00
Zbigniew Jędrzejewski-Szmek 9ee03516df tree-wide: add spdx header on all scripts and helpers
Even though many of those scripts are very simple, it is easier to include
the header than to try to say whether each of those files is trivial enough
not to require one.
2021-01-28 09:55:35 +01:00
Yu Watanabe 190d05c0e7 network: drop unnecessary condition in error path
See neigh_add() in kernel. It does not return EEXIST.
2021-01-27 01:28:28 +09:00
Yu Watanabe 4816e7bb75 network: drop wrong flag for neighbor entry
NLM_F_REQUEST is a nlmsg flag, not a neighbor flag.
2021-01-27 01:28:28 +09:00
Yu Watanabe af664001f5 network: use conservative_rename() to reduce to trigger network events
networkd part to fix #17577.

Note resolved part is f3e1f00d03.
2021-01-22 12:55:54 +09:00
Yu Watanabe 9092113d93 network: drop many unnecessary link_dirty() calls
Now link state saves mostly link state, DNS and NTP settings, .network
file name. So, it is not necessary to call link_dirty() e.g. when an
address is updated. This drops such unnecessary link_dirty() calls.
2021-01-22 12:55:51 +09:00
Yu Watanabe 92395e0e83 network: do not re-assign static routes when dynamic IPv6 addresses are updated
This effectively reverts 6545067aa9.

Unlike IPv4 addresses, routes are not removed when IPv6 addresses are
removed. So, it is not necessary to re-assign routes.
2021-01-22 12:53:18 +09:00
Dan Streetman a853652ae9 save link activation policy to state file and display in networkctl 2021-01-21 12:05:17 -05:00
Dan Streetman 61135582e0 network: add ActivationPolicy= configuration parameter
This parameter allows configuring the activation policy for an interface,
meaning how it manages the interface's administrative state (IFF_UP flag).
The policy can be configured to bring the interface either up or down when
the interface is (re)configured, to always force the interface either up or
down, or to never change the interface administrative state.

If the interface is bound with BindCarrier=, its administrative state is
controlled by the interface(s) it's bound to, and this parameter is forced
to 'bound'.

This changes the default behavior of how systemd-networkd sets the IFF_UP
flag; previously, it was set up (if not already up) every time the
link_joined() function was called. Now, with the default ActivationPolicy=
setting of 'up', it will only set the IFF_UP flag once, the first time
link_joined() is called, during an interface's configuration; and on
the first link_joined() call each time the interface is reconfigured.

Fixes: #3031
Fixes: #17437
2021-01-21 11:49:43 -05:00
Susant Sahani 0c7bd7ecbd network: networkd-network use TAKE_PTR 2021-01-20 15:09:26 +01:00
Susant Sahani 6de530f2b8 network: Use hashmap_ensure_put 2021-01-20 15:09:20 +01:00
Susant Sahani 9b1fd1f55b network: ndisc - Use ordered_set_ensure_put 2021-01-20 15:09:14 +01:00
Susant Sahani c038ce4606 network: add support to RoutingPolicyRule lookup table name 2021-01-19 16:37:46 +00:00
Yu Watanabe 7b5ed18779 Merge pull request #18294 from ssahani/net-2
tree wide use ensure_put
2021-01-19 16:46:41 +09:00
Yu Watanabe 7e2757c42f Merge pull request #18038 from yuwata/meson-split
meson: various cleanups
2021-01-19 12:22:34 +09:00
Yu Watanabe 8d40961c3c meson: slightly disentangle code dependencies
But, still sd-id128 is used in src/basic.
2021-01-19 07:06:32 +09:00
Yu Watanabe b09f01463a meson: enable several tests even if the relevant features are disabled 2021-01-19 07:04:19 +09:00
Yu Watanabe 5acb3cabd1 meson: make the second and third elements of tests or fuzzers optional
Then, we can shorten many test definitions.
2021-01-19 07:04:19 +09:00
Yu Watanabe 99b9f8fddd sd-journal: move source files for sd-journal to src/libsystemd/sd-journal 2021-01-19 07:04:18 +09:00
Susant Sahani ee9ead76bb network: wait-online - add a assert 2021-01-18 21:35:24 +01:00
Susant Sahani 3f70f938a0 network: wait-online - use hashmap_ensure_put 2021-01-18 21:35:20 +01:00
Susant Sahani b2cb2e82c8 network: radv - use hashmap_ensure_put 2021-01-18 21:34:46 +01:00
Susant Sahani b5b9b0e7ba network: Use TAKE_PTR 2021-01-18 21:11:31 +01:00
Susant Sahani 9fa3e794ac network: network -- use ordered_hashmap_ensure_put 2021-01-18 21:11:01 +01:00
Susant Sahani 28d9587be5 network: address - use ordered_hashmap_ensure_put 2021-01-18 21:09:27 +01:00
Susant Sahani 9d6bb21f37 network: macsec - use ordered_hashmap_ensure_put 2021-01-18 20:16:50 +01:00
Susant Sahani d1ce835989 network: bond - use ordered_set_ensure_put 2021-01-18 13:00:35 +01:00
Yu Watanabe aac6673f02 network: address-pool: also check conflicts with foreign addresses
Fixes CI issue found in
https://github.com/systemd/systemd-centos-ci/pull/334.
2021-01-17 23:23:08 +00:00
Susant Sahani 5a3e1cb918 network: tc use TAKE_PTR 2021-01-17 23:26:14 +09:00
Susant Sahani ebffea2a25 network: Use ordered_hashmap_ensure_put (#18233) 2021-01-17 20:07:02 +09:00
Yu Watanabe f9ead1a2f4 Merge pull request #18230 from ssahani/macvlan-bcqueuelen
network: macvlan - add support to configure rx queue for broadcast / multicast
2021-01-17 20:05:22 +09:00
Susant Sahani dca0a4e131 network: macvlan - add support to configure rx queue for broadcast/multicast 2021-01-17 08:39:28 +01:00
Yu Watanabe 16ed53658a Merge pull request #18243 from ssahani/ensure-put-use
tree-wide: introduce hashmap_ensure_put() and use it
2021-01-17 15:39:41 +09:00
Yu Watanabe 95dd454edc Merge pull request #18261 from ssahani/net2
network: modernize routing policy rule and add 0 validation where needed
2021-01-17 15:39:01 +09:00
Susant Sahani cda7fc8db3 network: tighten variable scope used in loop (#18277) 2021-01-17 15:38:33 +09:00
Susant Sahani a307a7dd38 network: nexthop - use hashmap_ensure_put 2021-01-16 23:10:32 +01:00
Susant Sahani dcd46cc42d network: use hashmap_ensure_put 2021-01-16 23:10:18 +01:00
Susant Sahani 8eeffefbf0 network: routing-policy-rule - TAKE_PTR 2021-01-16 23:04:07 +01:00
Susant Sahani fd9d7de176 network: route - add a zero verification for tcp window 2021-01-16 23:04:07 +01:00
Susant Sahani 0132453c40 network: tc - use TAKE_PTR (#18266)
* network: tc cake - use TAKE_PTR

* network: tc htb - use TAKE_PTR

* network: tc pie - use TAKE_PTR

* network: tc netem - use TAKE_PTR

* network: tc hhf - use TAKE_PTR

* network: tc gred - use TAKE_PTR

* network: tc fq codel - use TAKE_PTR

* network: tc fifo - use TAKE_PTR

* network: tc drr - use TAKE_PTR

* network: tc qdisc - use TAKE_PTR
2021-01-17 06:08:36 +09:00
Luca Boccassi 55eeb47631 Merge pull request #18264 from ssahani/net3
network: Use TAKE_PTR
2021-01-16 12:16:43 +00:00
Luca Boccassi 66e27e698e Merge pull request #18268 from ssahani/net5
network: tighten variable scope used in loop
2021-01-16 12:13:14 +00:00
Susant Sahani 995606ad5b network: manager tighten variable scope used in loop 2021-01-16 12:07:33 +00:00