Neal Gompa
6ea4cb975f
rpm: Fix typo in %_environmentdir
...
Signed-off-by: Neal Gompa <ngompa13@gmail.com >
2018-06-25 12:56:50 -04:00
Zbigniew Jędrzejewski-Szmek
dfe23d4145
Merge pull request #4522 from lucaswerkmeister/unescape-template
...
escape: support --unescape with --template
2018-06-25 18:48:01 +02:00
Lennart Poettering
5e4c5bde5c
busctl: make parameter const
...
it's initialized from an argv[] entry, hence let's be make it
non-writable by default.
2018-06-25 18:26:17 +02:00
Filipe Brandenburger
b02a7e1aea
resolved: assert t->server is set in dns_transaction_emit_tcp.
...
Uncovered by Coverity. Fixes CID 1393390.
2018-06-25 13:17:25 +02:00
Filipe Brandenburger
53a2383b8b
core/job: add check for return of job_type_merge_and_collapse()
...
Using an assertion is fine, since calls to job_merge_into_installed()
are protected by a check for job_type_is_conflicting().
Uncovered by Coverity, fixes CID 996307.
2018-06-25 13:16:38 +02:00
Lennart Poettering
2919425bab
Merge pull request #9398 from yuwata/lgtm-fixes
...
fixes error handlings and several cleanups suggested by LGTM
2018-06-25 13:12:44 +02:00
Michal Koutný
1e75824cb0
core/manager: Make sure jobs statistics are not double after daemon-reload
...
We add n_installed_jobs and n_failed_jobs to our inner state after
deserialization. This is fine during daemon-reexec when we start with clear
Manager (and some jobs possibly queued before deserialization), however,
daemon-reload works with the same manager and adding the values would
effectively double the counters. Reset the counters before we deserialize and
add their values again.
2018-06-25 11:18:44 +02:00
Lucas Werkmeister
d936cddcb5
escape: add --instance option
...
Suggested by @keszybz in #4522 .
2018-06-25 11:17:55 +02:00
Zbigniew Jędrzejewski-Szmek
d3a27ed402
boot: do not assume the last character in cmdline is a newline
...
Fixes #9401 .
2018-06-25 11:17:53 +02:00
Lucas Werkmeister
e563e2534c
escape: support --unescape with --template
2018-06-25 11:13:38 +02:00
Yu Watanabe
fb14aa7ecc
network: fix log message
2018-06-25 10:31:08 +02:00
Yu Watanabe
a9061d97a7
timesync: update log message
...
Fixes #9388 .
2018-06-25 10:27:18 +02:00
Yu Watanabe
75ca1621db
timesync: changes type of drift_freq to int64_t
...
drift_freq is used for storing timex.freq, and is a 64bit integer.
To support x32 ABI, this changes the type of drift_freq to int64_t.
Fixes #9387 .
2018-06-25 10:27:18 +02:00
Yu Watanabe
d5c3091122
install: fix error handling in is_symlink_with_known_name()
2018-06-25 14:07:16 +09:00
Yu Watanabe
99c89da02d
portable: fix error handling
2018-06-25 13:56:27 +09:00
Yu Watanabe
d61b34f1b2
import: drop unnecessary condition
2018-06-25 13:54:44 +09:00
Yu Watanabe
712fdfd609
sd-dhcp: drop unnecessary condition
2018-06-25 13:51:34 +09:00
Yu Watanabe
8838f46f93
machine-pool: drop unnecessary condition
2018-06-25 13:49:56 +09:00
Yu Watanabe
6da95857c1
resolve: drop dead code
2018-06-25 13:46:52 +09:00
Yu Watanabe
fa6a69d783
resolve: drop dead code
2018-06-25 13:42:31 +09:00
Yu Watanabe
33987ba0c2
bootctl: drop dead code
2018-06-25 13:40:36 +09:00
Yu Watanabe
29bfb683a8
journal: drop redundant condition
2018-06-25 13:36:49 +09:00
Yu Watanabe
a5042ec4d7
resolve: fix return value type of dns_answer_has_dname_for_cname()
2018-06-25 13:25:42 +09:00
Yu Watanabe
86b112a315
resolve: dns_scope_network_good() does not returns negative errno
2018-06-25 13:25:34 +09:00
Yu Watanabe
b4dec49f83
core/cgroup: drop unnecessary condition
2018-06-25 13:09:48 +09:00
Yu Watanabe
0ceff9068d
bus-util: fix error handling
2018-06-25 13:08:02 +09:00
Yu Watanabe
f18edd8a0a
tree-wide: add multiple inclusion guard
2018-06-25 13:04:59 +09:00
Yu Watanabe
6302d1ea07
core: drop unused log message
...
temporary_filesystem_add() does not parse mount options.
2018-06-24 19:06:24 +02:00
YmrDtnJu
a26fec2408
core: Actually use the resolved path for TemporaryFileSystem= ( #9385 )
...
The code already resolves specifiers using unit_full_printf() but then uses the
unresolved version again for temporary_filesystem_add().
2018-06-23 08:17:07 +09:00
Zbigniew Jędrzejewski-Szmek
25612ecba4
tree-wide: drop copyright lines for more authors
...
Acks in https://github.com/systemd/systemd/issues/9320 .
2018-06-22 16:39:45 +02:00
Kevin Kuehler
321ed3643a
journalctl: handle inotify exhaustion nicer
...
Instead of failing, log that inotify wds
are exhausted and fallback to -n switch.
Fixes #1296 .
2018-06-21 14:46:53 +02:00
Roland Kammerer
fee854ee8c
udev: exclude DRBD from block device ownership event locking
...
It does not make sense for udev to even open DRBD block devices
(/dev/drbdX). It is on one hand not necessary as DRBD is controlled by
something else in the stack (e.g., pacemaker), and it even can get
cumbersome in various scenarios (e.g., DRBD9 auto-promote).
Closes : #9371
Signed-off-by: Roland Kammerer <roland.kammerer@linbit.com >
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com >
2018-06-21 14:46:27 +02:00
Lennart Poettering
88116909ec
core: explicitly trigger changing udev SYSTEMD_WANTS properties
...
This compensates for the unsynchronized reload cycles of systemd and
udev: we manually trigger the deps listed in SYSTEMD_WANTS properties if
they change for device units that are already up. That way all deps
defined that way will be triggered at least once: the first time the
unit goes up by the usual dependency logic, and if it already is up by
the device.c specific logic.
Fixes : #9323
2018-06-20 23:59:29 +02:00
Lennart Poettering
b5c9144cb7
analyze: use _cleanup_ for freeing the manager object
2018-06-20 23:59:29 +02:00
Lennart Poettering
4d2a7ffd5b
analyze: use log_unit_error_errno()'s return value where we can
2018-06-20 23:59:29 +02:00
Lennart Poettering
7675251663
tree-wide: pass NULL arguments to manager_startup() directly, avoid declaring unneeded variables
2018-06-20 23:59:29 +02:00
Lennart Poettering
01d32c0030
core: use fflush_and_check() where appropriate
2018-06-20 23:59:29 +02:00
Zbigniew Jędrzejewski-Szmek
fc65dabdb5
test-condition: extend tests to all ConditionSecurity= values
...
Also print out what we detect, for manual verification.
2018-06-20 22:46:18 +02:00
Lennart Poettering
be405b909e
condition: add new conditon ConditionSecurity=uefi-secureboot
...
We have the detector call for this anyway, and it's useful for
conditioning out dbxtool.service, hence let's add this tiny new option.
2018-06-20 22:33:47 +02:00
Zbigniew Jędrzejewski-Szmek
92963e74df
Merge pull request #9363 from yuwata/specifier-config-dir
...
core: add unit specifier for configuration directory root
2018-06-20 22:30:18 +02:00
Yu Watanabe
56ddbf1009
meson: make DNS-over-TLS support optional
...
This adds dns-over-tls option to meson. If set to 'false',
systemd-resolved is not linked with libgnutls.
2018-06-20 22:28:01 +02:00
Franck Bui
25c59b5d85
systemctl: mask always reports the same unit names when different unknown units are passed
...
Before this patch:
# systemctl --runtime mask abuild.mount does-not-exist.mount does-also-not-exist.mount
Unit abuild.mount does not exist, proceeding anyway.
Unit abuild.mount does not exist, proceeding anyway.
Unit abuild.mount does not exist, proceeding anyway.
Created symlink /run/systemd/system/abuild.mount → /dev/null.
Created symlink /run/systemd/system/does-not-exist.mount → /dev/null.
Created symlink /run/systemd/system/does-also-not-exist.mount → /dev/null.
After this patch:
# systemctl --runtime mask abuild.mount does-not-exist.mount does-also-not-exist.mount
Unit abuild.mount does not exist, proceeding anyway.
Unit does-not-exist.mount does not exist, proceeding anyway.
Unit does-also-not-exist.mount does not exist, proceeding anyway.
Created symlink /run/systemd/system/abuild.mount → /dev/null.
Created symlink /run/systemd/system/does-not-exist.mount → /dev/null.
Created symlink /run/systemd/system/does-also-not-exist.mount → /dev/null.
2018-06-20 21:53:23 +02:00
Yu Watanabe
969309c2b4
core: add unit specifier for configuration directory root
...
Follow-up for 14068e17f3 .
2018-06-21 03:20:37 +09:00
Zbigniew Jędrzejewski-Szmek
54781addb7
test-sizeof: another aproach to _Float128 availability detection
2018-06-20 17:06:21 +02:00
Lennart Poettering
a6887cc03e
tree-wide: drop MSG_NOSIGNAL flag from recvmsg() invocations
...
MSG_NOSIGNAL is only defined for sendmsg(), not for recvmsg(), hence
let's drop it's use, in particular as it appears to create problems on
older kernels. See:
https://lists.freedesktop.org/archives/systemd-devel/2018-June/040869.html
2018-06-20 16:12:55 +02:00
Lennart Poettering
41145af8a9
Revert "mention alias for poweroff in machinectl --help"
...
This reverts commit bebd5382ba4c820377f05e1e518c6dfd96b278be.
For the reasoning, see: https://github.com/systemd/systemd/pull/9342#issuecomment-398715417
2018-06-20 13:25:42 +02:00
Lennart Poettering
6dd9477dde
Merge pull request #9348 from keszybz/copyright-removal
...
Copyright removal
2018-06-20 12:27:56 +02:00
Zbigniew Jędrzejewski-Szmek
68ad174eb8
Drop copyrights tags for "systemd authors"
2018-06-20 12:11:12 +02:00
Zbigniew Jędrzejewski-Szmek
5b4f9cc15b
basic/bpf-program: drop obsolete comment
...
As far as I can see, nothing in that particular file is from the
kernel. Let's just drop the comment.
2018-06-20 12:07:38 +02:00
Zbigniew Jędrzejewski-Szmek
d9b02e1697
tree-wide: drop copyright headers from frequent contributors
...
Fixes #9320 .
for p in Shapovalov Chevalier Rozhkov Sievers Mack Herrmann Schmidt Rudenberg Sahani Landden Andersen Watanabe; do
git grep -e 'Copyright.*'$p -l|xargs perl -i -0pe 's|/([*][*])?[*]\s+([*#]\s+)?Copyright[^\n]*'$p'[^\n]*\s*[*]([*][*])?/\n*|\n|gms; s|\s+([*#]\s+)?Copyright[^\n]*'$p'[^\n]*\n*|\n|gms'
done
2018-06-20 11:58:53 +02:00