Thanks-To: Tobias Klauser <tklauser@access.unizh.ch>
While crawling through the udev manpage I noticed some typos and other
grammatical errors. English is not my native language, so I'm not sure
if I fixed everything right. I would be glad if any English-speaking
person could check this patch before applying.
Initialize the defaults in udev_config.c instead of namedev.c.
Replace macro by expanded code. Switch to mode_t instead
of string value. Add and clarify some comments.
Remove udev.bus, cause it's currently unused and newer kernels will pass
it in the hotplug environment as PHYSDEVBUS.
Remove udev.action, cause it's unused.
Rename udev_set_values() to udev_init_device().
Add UDEV_LOG to the man udev man page. Remove mention of specific
variables from the udevd/udevsend man page as we changed to pass
the whole environment.
Correct printed Usage: of udevtest and udevinfo.
Init the config in udevtest earlier to accept input with and without
the sysfs mount point.
The /etc/dev.d/input/input.dev was called twice for /dev/input/mouse.
Skip the execution if we get a directory named after the subsystem.
Move UDEV_NO_DEVD where it belongs.
This cuts the size of the binaries, as only objects that
are actually used are linked into the binary:
45592 -> 43608 udev
4380 -> 4380 udevsend
10380 -> 4652 udevd
34732 -> 33100 udevinfo
45432 -> 37208 udevtest
I just noticed that the DEVNAME enviroment variable isn't being set anymore
in udev 0.046 on device removal, while it was being set in 0.042. We're using
the property tto do umount -l <devices> when a block device is removed. Afaik
there is no other way to associate a device with it's DEVNAME on removal ?
Also are there cases where doing umount -l on the removed devices is wrong?
I guess the device is gone, so there is no sense in keeping it mounted (it's
not like the filesystem is gonna come back in a sane state again)..
Attached (trivial) patch brings back the DEVNAME variable on device removal.
> I just put const's at some places. It cut down data segments, but
> increased code size.
> Overall still smaller:
>
> -rwxr-xr-x 1 user users 50420 Nov 19 10:53 ../udev-046/udev
> -rwxr-xr-x 1 user users 49556 Nov 19 10:53 udev
> text data bss dec hex filename
> 47245 968 22480 70693 11425 ../udev-046/udev
> 48089 104 22064 70257 11271 udev
>
> Also, the instance of utsname in udev_lib.c is used only once.
greg@kroah.com
Greg KH
klauser@access.unizh.ch
kay.sievers@vrfy.org
sschweizer@gmail.com
sjoerd@spring.luon.net