env-util: fix memory leak (#5962)

If cunescape succeeds, but the assignment is not valid, uce is not freed.
2017-05-14 10:30:40 -04:00
parent 0839f42ebf
commit 16eefcafed
2 changed files with 13 additions and 1 deletions
@@ -799,8 +799,10 @@ int deserialize_environment(char ***environment, const char *line) {
        if (r < 0)
                return r;

-        if (!env_assignment_is_valid(uce))
+        if (!env_assignment_is_valid(uce)) {
+                free(uce);
                return -EINVAL;
+        }

        return strv_env_replace(environment, uce);
 }