From ef1e299047306534d8ef0a28019f4cb065a0e14a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Tue, 19 Aug 2025 18:54:51 +0200 Subject: [PATCH] feedback-manager: Let app level cap important level MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As per DBus spec the `important` hint is meant to override the global feedback level not any per app level the user might have configured as otherwise there's no way to override this. Closes: https://gitlab.freedesktop.org/agx/feedbackd/-/issues/93 Signed-off-by: Guido Günther --- src/fbd-feedback-manager.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/fbd-feedback-manager.c b/src/fbd-feedback-manager.c index 5293629..bc12a4e 100644 --- a/src/fbd-feedback-manager.c +++ b/src/fbd-feedback-manager.c @@ -758,10 +758,11 @@ fbd_feedback_manager_get_effective_level (FbdFeedbackManager *self, app_level = app_get_feedback_level (app_id); can_important = app_is_important (self, app_id); - if (important && can_important) - level = want_level; - else + if (important && can_important) { + level = MIN (want_level, app_level); + } else { level = get_max_level (self->level, app_level, want_level); + } return level; }