From bdf4403b9da49031468dde638bee755b5e91afa4 Mon Sep 17 00:00:00 2001 From: Evangelos Ribeiro Tzaras Date: Wed, 15 Jun 2022 19:29:04 +0200 Subject: [PATCH] spec: Clarify feedback noisiness The old wording could be interpreted as the feedback being discarded if it's noisier than the currently selected profile which is not the case. Also take the new per application settings into account. --- Feedback-theme-spec-0.0.0.md | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/Feedback-theme-spec-0.0.0.md b/Feedback-theme-spec-0.0.0.md index fd96446..bae695c 100644 --- a/Feedback-theme-spec-0.0.0.md +++ b/Feedback-theme-spec-0.0.0.md @@ -25,14 +25,18 @@ theme for a given device. # Implementation -When an application triggers feedback for an event in the feedback -daemon the daemon selects the provided feedback like this: +When an application requests feedback for an event via the feedback daemon +the daemon selects the provided feedback like this, +capping the noisiness for each limit: -1. feedbacks from a nosier profiles like the currently selected are - ignored +1. The currently selected profile provides the (global) upper limit for noisiness -2. All other feedbacks for this event are selected and run to provide - feedback to the user +2. Per application settings impose another upper limit + +3. Per event noisiness is the last noisiness constraint + +4. All feedback consistent with the resulting limit are selected + and run to provide the feedback to the user With the above a feedback theme in YAML format could look like: