From bd7701220ddcef6bfe672a224c7d884c55d00560 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Tue, 19 Aug 2025 19:02:02 +0200 Subject: [PATCH] treewide: Clarify that `important` affects the global level MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The DBus spec had it right but the other places weren't clear on that. Signed-off-by: Guido Günther --- data/org.sigxcpu.feedbackd.gschema.xml | 2 +- doc/feedbackd.rst | 4 ++-- libfeedback/lfb-event.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/data/org.sigxcpu.feedbackd.gschema.xml b/data/org.sigxcpu.feedbackd.gschema.xml index 25bc6e3..857144d 100644 --- a/data/org.sigxcpu.feedbackd.gschema.xml +++ b/data/org.sigxcpu.feedbackd.gschema.xml @@ -39,7 +39,7 @@ 'sm.puri.OSK0'] List of apps that can override the feedback level - Apps listed here can override the configured feedback level by + Apps listed here can override the configured global feedback level by setting the 'important' hint on the submitted event. diff --git a/doc/feedbackd.rst b/doc/feedbackd.rst index 005a09a..a44f648 100644 --- a/doc/feedbackd.rst +++ b/doc/feedbackd.rst @@ -51,8 +51,8 @@ These gsettings are used by ``feedbackd``: - `profile`: The current overall feedback profile. Valid values are `full`, `quiet` and `silent`. - - `allow-important`: List of apps that can override the feedback level - (useful for e.g. allowing the alarm clock to also emit sound when + - `allow-important`: List of apps that can override the global feedback + level (useful for e.g. allowing the alarm clock to also emit sound when device is in silent mode). - `prefer-flash`: Prefer camera flash over status LED - `theme`: The feedback theme to use. This can be used to override diff --git a/libfeedback/lfb-event.c b/libfeedback/lfb-event.c index ffbf9cf..3057cdb 100644 --- a/libfeedback/lfb-event.c +++ b/libfeedback/lfb-event.c @@ -817,7 +817,7 @@ lfb_event_get_feedback_profile (LfbEvent *self) * * Tells the feedback server that the sender deems this to be an * important event. A feedback server might allow the sender to - * override the current feedback level when this is set. + * override the current global feedback level when this is set. */ void lfb_event_set_important (LfbEvent *self, gboolean important)