From efa14947b489e170ed09b3563840fe789061273f Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Mon, 9 Jul 2018 12:00:42 +0200 Subject: [PATCH] shared-qmi,loc: setup reports every 5s may be broken Configuring reports every 5s may lead to GPGGA traces reported like this: $GPGGA,211645.00,,,,,0,,,,,,,,*4D $GPGGA,211646.00,4030.003988,N,00330.761876,W,1,07,1.0,691.6,M,53.0,M,,*74 $GPGGA,211650.00,,,,,0,,,,,,,,*49 $GPGGA,211651.00,4030.005405,N,00330.763540,W,1,07,1.0,688.9,M,53.0,M,,*71 $GPGGA,211655.00,,,,,0,,,,,,,,*4C $GPGGA,211656.00,4030.008074,N,00330.765338,W,1,07,0.9,679.9,M,53.0,M,,*70 $GPGGA,211700.00,,,,,0,,,,,,,,*4D $GPGGA,211701.00,4030.009258,N,00330.765510,W,1,07,1.0,678.3,M,53.0,M,,*71 $GPGGA,211705.00,,,,,0,,,,,,,,*48 Which is totally undesirable, as the GPS location would be flapping between set and unset. Use the default of 1s explicitly, which behaves properly. --- src/mm-shared-qmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mm-shared-qmi.c b/src/mm-shared-qmi.c index 1ff96844..15de2ae4 100644 --- a/src/mm-shared-qmi.c +++ b/src/mm-shared-qmi.c @@ -1161,7 +1161,7 @@ start_gps_engine (MMSharedQmi *self, input = qmi_message_loc_start_input_new (); qmi_message_loc_start_input_set_session_id (input, DEFAULT_LOC_SESSION_ID, NULL); qmi_message_loc_start_input_set_intermediate_report_state (input, QMI_LOC_INTERMEDIATE_REPORT_STATE_DISABLE, NULL); - qmi_message_loc_start_input_set_minimum_interval_between_position_reports (input, 5000, NULL); + qmi_message_loc_start_input_set_minimum_interval_between_position_reports (input, 1000, NULL); qmi_message_loc_start_input_set_fix_recurrence_type (input, QMI_LOC_FIX_RECURRENCE_TYPE_REQUEST_PERIODIC_FIXES, NULL); qmi_client_loc_start (QMI_CLIENT_LOC (client), input,