From d7288861a595db7f07b8ecf6bdc30d957b8b6843 Mon Sep 17 00:00:00 2001 From: Andrew Lassalle Date: Tue, 3 Nov 2020 12:36:31 -0800 Subject: [PATCH] mm-kernel-device: Fix cmp to exclude subtypes If multiple kernel device types inherit from MMKernerDevice, and those are compared against each other, the current logic returns TRUE if the G_OBJECT_TYPE of one of them is smaller than the other. This function is checking for equality, so returning FALSE is enough. --- src/kerneldevice/mm-kernel-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kerneldevice/mm-kernel-device.c b/src/kerneldevice/mm-kernel-device.c index fa865394..cf45447f 100644 --- a/src/kerneldevice/mm-kernel-device.c +++ b/src/kerneldevice/mm-kernel-device.c @@ -204,7 +204,7 @@ mm_kernel_device_cmp (MMKernelDevice *a, g_return_val_if_fail (MM_IS_KERNEL_DEVICE (b), FALSE); if (G_OBJECT_TYPE (a) != G_OBJECT_TYPE (b)) - return G_OBJECT_TYPE (a) < G_OBJECT_TYPE (b); + return FALSE; return (MM_KERNEL_DEVICE_GET_CLASS (a)->cmp ? MM_KERNEL_DEVICE_GET_CLASS (a)->cmp (a, b) :