From b529b69fb60b139222f1712957669b6da0e073bd Mon Sep 17 00:00:00 2001 From: Richard Acayan Date: Mon, 14 Apr 2025 19:08:06 -0400 Subject: [PATCH] shared-qmi: always set NMEA types By default, the Pixel 3a only emits $PQXXX traces, even when all the desired traces are reported as enabled. A request to set the NMEA types must still be sent to enable the GGA/GSA/GSV traces. Remove the optimization that prevents the request from happening automatically. Signed-off-by: Richard Acayan --- src/mm-shared-qmi.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/mm-shared-qmi.c b/src/mm-shared-qmi.c index d4880a73..2f597c76 100644 --- a/src/mm-shared-qmi.c +++ b/src/mm-shared-qmi.c @@ -5355,14 +5355,6 @@ loc_get_nmea_types_indication_cb (QmiClientLoc *client, qmi_indication_loc_get_nmea_types_output_get_nmea_types (output, &nmea_types_mask, NULL); - /* If the configured NMEA types already include GGA, GSV and GSA, we're fine. For raw - * GPS sources GGA is the only required one, the other two are given for completeness */ - if ((nmea_types_mask & desired_nmea_types_mask) == desired_nmea_types_mask) { - g_task_return_boolean (task, TRUE); - g_object_unref (task); - return; - } - input = qmi_message_loc_set_nmea_types_input_new (); qmi_message_loc_set_nmea_types_input_set_nmea_types (input, (nmea_types_mask | desired_nmea_types_mask), NULL); qmi_client_loc_set_nmea_types (ctx->client,