Merge request !1490 from 'test-multipart-sms-pdu-type'

test-sms-list: test multipart concatenation differentiating by PDU type

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1490

src/tests/test-sms-list.c

@@ -127,6 +127,116 @@ test_mbim_multipart_zero_index (void)
 
 /****************************************************************/
 
+static void
+test_multipart_match_pdu_type (void)
+{
+    MMSmsPart *part1, *part2;
+    MMSmsList *list;
+    MMBaseSms *sms1, *sms2;
+    GError *error = NULL;
+
+    static const gchar *deliver_part1_pdu =
+        "07919471227210244405852122F039F101506271217180A005000319020198E9B2B82C0759DFE4"
+        "B0F9ED2EB7967537B9CC02B5D37450122D2FCB41EE303DFD7687D96537881A96A7CD6F383DFD76"
+        "83F46134BBEC064DD36550DA0D22A7CBF3721BE42CD3F5A0198B56036DCA20B8FC0D6A0A417076"
+        "7D0EAAE540433A082E7F83A6E5F93CFD76BB40D7B2DB0D9AA6CB2072BA3C2F83926EF31BE44E8F"
+        "D17450BB8C9683CA";
+    static const gchar *deliver_part2_pdu =
+        "07919471227210244405852122F039F1015062712181804F050003190202E4E8309B5E7683DAFC"
+        "319A5E76B340F73D9A5D7683A6E93268FD9ED3CB6EF67B0E5AD172B19B2C2693C9602E90355D66"
+        "83A6F0B007946E8382F5393BEC26BB00";
+
+    static const gchar *submit_part1_pdu =
+        "0791947122721024511905812122F000000BA005000319020198E9B2B82C0759DFE4B0F9ED2EB7"
+        "967537B9CC02B5D37450122D2FCB41EE303DFD7687D96537881A96A7CD6F383DFD7683F46134BB"
+        "EC064DD36550DA0D22A7CBF3721BE42CD3F5A0198B56036DCA20B8FC0D6A0A4170767D0EAAE540"
+        "433A082E7F83A6E5F93CFD76BB40D7B2DB0D9AA6CB2072BA3C2F83926EF31BE44E8FD17450BB8C"
+        "9683CA";
+
+    static const gchar *submit_part2_pdu =
+        "0791947122721024511905812122F000000B4F050003190202E4E8309B5E7683DAFC319A5E76B3"
+        "40F73D9A5D7683A6E93268FD9ED3CB6EF67B0E5AD172B19B2C2693C9602E90355D6683A6F0B007"
+        "946E8382F5393BEC26BB00";
+
+    list = mm_sms_list_new (NULL);
+
+    /* Add the initial SUBMIT PDU */
+    part1 = mm_sms_part_3gpp_new_from_pdu (SMS_PART_INVALID_INDEX, submit_part1_pdu, NULL, &error);
+    g_assert_no_error (error);
+    sms1 = MM_BASE_SMS (g_object_new (MM_TYPE_BASE_SMS,
+                                      MM_BASE_SMS_IS_3GPP, TRUE,
+                                      MM_BASE_SMS_DEFAULT_STORAGE, MM_SMS_STORAGE_MT,
+                                      NULL));
+    mm_sms_list_take_part (list,
+                           sms1,
+                           part1,
+                           MM_SMS_STATE_RECEIVED,
+                           MM_SMS_STORAGE_MT,
+                           &error);
+    g_assert_no_error (error);
+    g_clear_object (&sms1);
+
+    part2 = mm_sms_part_3gpp_new_from_pdu (SMS_PART_INVALID_INDEX, submit_part2_pdu, NULL, &error);
+    g_assert_no_error (error);
+    sms2 = MM_BASE_SMS (g_object_new (MM_TYPE_BASE_SMS,
+                                      MM_BASE_SMS_IS_3GPP, TRUE,
+                                      MM_BASE_SMS_DEFAULT_STORAGE, MM_SMS_STORAGE_MT,
+                                      NULL));
+    mm_sms_list_take_part (list,
+                           sms2,
+                           part2,
+                           MM_SMS_STATE_RECEIVED,
+                           MM_SMS_STORAGE_MT,
+                           &error);
+    g_assert_no_error (error);
+    g_clear_object (&sms2);
+
+    g_assert_cmpint (mm_sms_list_get_count (list), ==, 1);
+
+    /* Now take the DELIVER PDU */
+    part1 = mm_sms_part_3gpp_new_from_pdu (SMS_PART_INVALID_INDEX, deliver_part1_pdu, NULL, &error);
+    g_assert_no_error (error);
+    sms1 = MM_BASE_SMS (g_object_new (MM_TYPE_BASE_SMS,
+                                      MM_BASE_SMS_IS_3GPP, TRUE,
+                                      MM_BASE_SMS_DEFAULT_STORAGE, MM_SMS_STORAGE_MT,
+                                      NULL));
+    mm_sms_list_take_part (list,
+                           sms1,
+                           part1,
+                           MM_SMS_STATE_RECEIVED,
+                           MM_SMS_STORAGE_MT,
+                           &error);
+    g_assert_no_error (error);
+
+    part2 = mm_sms_part_3gpp_new_from_pdu (SMS_PART_INVALID_INDEX, deliver_part2_pdu, NULL, &error);
+    g_assert_no_error (error);
+    sms2 = MM_BASE_SMS (g_object_new (MM_TYPE_BASE_SMS,
+                                      MM_BASE_SMS_IS_3GPP, TRUE,
+                                      MM_BASE_SMS_DEFAULT_STORAGE, MM_SMS_STORAGE_MT,
+                                      NULL));
+    mm_sms_list_take_part (list,
+                           sms2,
+                           part2,
+                           MM_SMS_STATE_RECEIVED,
+                           MM_SMS_STORAGE_MT,
+                           &error);
+    g_assert_no_error (error);
+
+    /* Ensure we have two SMSs; the DELIVER and the SUBMIT */
+    g_assert_cmpint (mm_sms_list_get_count (list), ==, 2);
+    /* Ensure the DELIVER is complete */
+    g_assert (mm_base_sms_is_multipart (sms1));
+    g_assert (mm_base_sms_multipart_is_complete (sms1));
+    /* sms2 should have no parts because sms1 took the second PDU */
+    g_assert (!mm_base_sms_is_multipart (sms2));
+
+    g_clear_object (&sms1);
+    g_clear_object (&sms2);
+    g_clear_object (&list);
+}
+
+/****************************************************************/
+
 int main (int argc, char **argv)
 {
     setlocale (LC_ALL, "");
@@ -135,6 +245,7 @@ int main (int argc, char **argv)
 
     g_test_add_func ("/MM/SMS/3GPP/sms-list/zero-index", test_mbim_multipart_zero_index);
     g_test_add_func ("/MM/SMS/3GPP/sms-list/mbim-multipart-unstored", test_mbim_multipart_unstored);
+    g_test_add_func ("/MM/SMS/3GPP/sms-list/multipart-match-pdu-type", test_multipart_match_pdu_type);
 
     return g_test_run ();
 }