From 8c04cc036782dab0e80c1f2314baa3376eecad02 Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Mon, 3 Apr 2017 14:50:01 -0500 Subject: [PATCH] telit: fix AT+SERVICE 3GPP2 access technology reporting Looks like a C&P error from the AT#PSNT codepath; all the docs I can find indicate that AT+SERVICE returns only an integer and no commas: (ttyUSB2): --> 'AT+SERVICE?' (ttyUSB2): <-- '+SERVICE: 3OK' Couldn't refresh access technologies: 'Failed to parse +SERVICE response: '+SERVICE: 3'' --- plugins/telit/mm-broadband-modem-telit.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/plugins/telit/mm-broadband-modem-telit.c b/plugins/telit/mm-broadband-modem-telit.c index 8b873106..fb169fd2 100644 --- a/plugins/telit/mm-broadband-modem-telit.c +++ b/plugins/telit/mm-broadband-modem-telit.c @@ -828,7 +828,7 @@ response_processor_service_ignore_at_errors (MMBaseModem *self, GVariant **result, GError **result_error) { - const gchar *service, *mode; + const gchar *service; if (error) { /* Ignore AT errors (ie, ERROR or CMx ERROR) */ @@ -838,9 +838,8 @@ response_processor_service_ignore_at_errors (MMBaseModem *self, } service = mm_strip_tag (response, "+SERVICE:"); - mode = strchr (service, ','); - if (mode) { - switch (atoi (++mode)) { + if (service) { + switch (atoi (service)) { case 1: *result = g_variant_new_uint32 (MM_MODEM_ACCESS_TECHNOLOGY_1XRTT); return TRUE;