From 839af5553fb753bb3162997283e9b713f8c12dc8 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Mon, 14 Feb 2022 10:32:45 +0100 Subject: [PATCH] mm-call-audio-format: avoid redundant condition --- libmm-glib/mm-call-audio-format.c | 33 +++++++++++++++---------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/libmm-glib/mm-call-audio-format.c b/libmm-glib/mm-call-audio-format.c index 452fa721..a3d617c6 100644 --- a/libmm-glib/mm-call-audio-format.c +++ b/libmm-glib/mm-call-audio-format.c @@ -167,25 +167,24 @@ mm_call_audio_format_get_dictionary (MMCallAudioFormat *self) return NULL; g_variant_builder_init (&builder, G_VARIANT_TYPE ("a{sv}")); - if (self) { - if (self->priv->encoding) - g_variant_builder_add (&builder, - "{sv}", - PROPERTY_ENCODING, - g_variant_new_string (self->priv->encoding)); - if (self->priv->resolution) - g_variant_builder_add (&builder, - "{sv}", - PROPERTY_RESOLUTION, - g_variant_new_string (self->priv->resolution)); + if (self->priv->encoding) + g_variant_builder_add (&builder, + "{sv}", + PROPERTY_ENCODING, + g_variant_new_string (self->priv->encoding)); - if (self->priv->rate) - g_variant_builder_add (&builder, - "{sv}", - PROPERTY_RATE, - g_variant_new_uint32 (self->priv->rate)); - } + if (self->priv->resolution) + g_variant_builder_add (&builder, + "{sv}", + PROPERTY_RESOLUTION, + g_variant_new_string (self->priv->resolution)); + + if (self->priv->rate) + g_variant_builder_add (&builder, + "{sv}", + PROPERTY_RATE, + g_variant_new_uint32 (self->priv->rate)); return g_variant_builder_end (&builder); }