SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

base-manager: increase suspend timeout for each active bearer

Browse Source 
Some modems can take a very long time (~20s) to reply to bearer
disconnect requests especially in marginal signal situations where
the modem must resend messages to the network after internal
timeouts. Give the modem a chance to suspend successfully if
there are active bearers.

Related: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1311#note_2938638

Signed-off-by: Dan Williams <dan@ioncontrol.co>
This commit is contained in:
Dan Williams
2025-07-28 09:46:13 -05:00
parent e867a49d92
commit 79d495c892
1 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mm-base-manager.c
+21 -1
View File
@@ -1167,6 +1167,7 @@ mm_base_manager_cleanup (MMBaseManager *self,
GHashTableIter iter;
MMDevice *device;
gboolean disable, remove, low_power, terse;
guint active_bearers = 0;
g_return_if_fail (self != NULL);
g_return_if_fail (MM_IS_BASE_MANAGER (self));
@@ -1194,6 +1195,19 @@ mm_base_manager_cleanup (MMBaseManager *self,
while (g_hash_table_iter_next (&iter, NULL, (gpointer) &device)) {
DeviceCleanupContext *dctx;
GTask *task;
MMBaseModem *modem;
modem = mm_device_peek_modem (device);
if (modem) {
guint count = 0;
mm_iface_modem_count_bearers (MM_IFACE_MODEM (modem),
MM_IFACE_MODEM_COUNT_BEARERS_FLAG_ACTIVE,
&count,
NULL,
NULL);
active_bearers += count;
}
task = g_task_new (device,
NULL,
@@ -1201,12 +1215,18 @@ mm_base_manager_cleanup (MMBaseManager *self,
ctx);
ctx->tasks = g_slist_append (ctx->tasks, task);
dctx = device_cleanup_context_new (mm_device_peek_modem (device), flags);
dctx = device_cleanup_context_new (modem, flags);
g_task_set_task_data (task, dctx, (GDestroyNotify)device_cleanup_context_free);
device_cleanup_step (task);
}
/* Increase cleanup timeout for each connected bearer; disconnecting a
* bearer can take many seconds.
*/
if (active_bearers)
mm_sleep_context_timeout_backoff (sleep_ctx, active_bearers * 20);
/* Complete cleanup if there were no devices */
manager_cleanup_context_maybe_complete (ctx, NULL, NULL, FALSE);
}