From 63d21151e22ed2bb81e2165e26ce5cd83791d678 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Fri, 31 Jan 2020 07:37:08 +0100 Subject: [PATCH] cinterion: fix warnings with -Wimplicit-fallthrough MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cinterion/mm-shared-cinterion.c: In function ‘disable_location_gathering_context_gps_step’: cinterion/mm-shared-cinterion.c:414:22: error: this statement may fall through [-Werror=implicit-fallthrough=] 414 | ctx->gps_step++; | ~~~~~~~~~~~~~^~ cinterion/mm-shared-cinterion.c:417:5: note: here 417 | case DISABLE_LOCATION_GATHERING_GPS_STEP_SGPSS: | ^~~~ --- plugins/cinterion/mm-shared-cinterion.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/plugins/cinterion/mm-shared-cinterion.c b/plugins/cinterion/mm-shared-cinterion.c index 2089fd1a..9846bfa0 100644 --- a/plugins/cinterion/mm-shared-cinterion.c +++ b/plugins/cinterion/mm-shared-cinterion.c @@ -412,7 +412,7 @@ disable_location_gathering_context_gps_step (GTask *task) switch (ctx->gps_step) { case DISABLE_LOCATION_GATHERING_GPS_STEP_FIRST: ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case DISABLE_LOCATION_GATHERING_GPS_STEP_SGPSS: if (priv->sgpss_support == FEATURE_SUPPORTED) { @@ -422,7 +422,7 @@ disable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case DISABLE_LOCATION_GATHERING_GPS_STEP_SGPSC_ENGINE: if (priv->sgpsc_support == FEATURE_SUPPORTED) { @@ -433,7 +433,7 @@ disable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case DISABLE_LOCATION_GATHERING_GPS_STEP_SGPSC_ANTENNA: if (priv->sgpsc_support == FEATURE_SUPPORTED) { @@ -444,7 +444,7 @@ disable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case DISABLE_LOCATION_GATHERING_GPS_STEP_SGPSC_OUTPUT: if (priv->sgpsc_support == FEATURE_SUPPORTED) { @@ -455,7 +455,7 @@ disable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case DISABLE_LOCATION_GATHERING_GPS_STEP_LAST: /* Only use the GPS port in NMEA/RAW setups */ @@ -668,7 +668,7 @@ enable_location_gathering_context_gps_step (GTask *task) switch (ctx->gps_step) { case ENABLE_LOCATION_GATHERING_GPS_STEP_FIRST: ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case ENABLE_LOCATION_GATHERING_GPS_STEP_SGPSS: if (priv->sgpss_support == FEATURE_SUPPORTED) { @@ -678,7 +678,7 @@ enable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case ENABLE_LOCATION_GATHERING_GPS_STEP_SGPSC_OUTPUT: if (priv->sgpsc_support == FEATURE_SUPPORTED) { @@ -689,8 +689,7 @@ enable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ - + /* fall through */ case ENABLE_LOCATION_GATHERING_GPS_STEP_SGPSC_ANTENNA: if (priv->sgpsc_support == FEATURE_SUPPORTED) { @@ -701,7 +700,7 @@ enable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case ENABLE_LOCATION_GATHERING_GPS_STEP_SGPSC_ENGINE: if (priv->sgpsc_support == FEATURE_SUPPORTED) { @@ -712,7 +711,7 @@ enable_location_gathering_context_gps_step (GTask *task) return; } ctx->gps_step++; - /* Fall down to next step */ + /* fall through */ case ENABLE_LOCATION_GATHERING_GPS_STEP_LAST: /* Only use the GPS port in NMEA/RAW setups */