From 588f9550ed1acd792ee09c2b43dbf13788ce7663 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander@lanedo.com>
Date: Fri, 30 Sep 2011 15:01:13 +0200
Subject: [PATCH] api: remove GetInfo() from the Modem API and use read-only
 properties instead.

New 'Manufacturer', 'Model' and 'Revision properties are added, all being
read-only strings.
---
 new/org.freedesktop.ModemManager1.Modem.xml | 37 ++++++++++-----------
 1 file changed, 18 insertions(+), 19 deletions(-)

diff --git a/new/org.freedesktop.ModemManager1.Modem.xml b/new/org.freedesktop.ModemManager1.Modem.xml
index 15eb1b9c..cc970c64 100644
--- a/new/org.freedesktop.ModemManager1.Modem.xml
+++ b/new/org.freedesktop.ModemManager1.Modem.xml
@@ -82,25 +82,6 @@
       </arg>
     </method>
 
-    <method name="GetInfo">
-      <tp:docstring>
-        Retrieve modem information, like the manufacturer, hardware version,
-        firmware version, etc.
-      </tp:docstring>
-      <annotation name="org.freedesktop.DBus.GLib.Async" value=""/>
-      <annotation name="org.freedesktop.DBus.GLib.CSymbol" value="impl_modem_get_info"/>
-      <arg name="info" type="a{sv}" direction="out">
-        <tp:docstring>
-          Dictionary containing various information about the modem, including
-          zero or more of the following items:
-          
-             manufacturer     : (string)
-             model            : (string)
-             version/revision : (string)
-        </tp:docstring>
-      </arg>
-    </method>
-
     <method name="Reset">
       <tp:docstring>
         Clear non-persistent configuration and state, and return the device to
@@ -179,6 +160,24 @@
       </tp:docstring>
     </property>
 
+    <property name="Manufacturer" type="s" access="read">
+      <tp:docstring>
+	The equipment manufacturer, as reported by the modem.
+      </tp:docstring>
+    </property>
+
+    <property name="Model" type="s" access="read">
+      <tp:docstring>
+	The equipment model, as reported by the modem.
+      </tp:docstring>
+    </property>
+
+    <property name="Revision" type="s" access="read">
+      <tp:docstring>
+	The revision identification of the software, as reported by the modem.
+      </tp:docstring>
+    </property>
+
     <property name="DeviceIdentifier" type="s" access="read">
       <tp:docstring>
 	A best-effort device identifier based on various device information like